upstream: add load_assigment field to Cluster #3261

dio · 2018-05-01T10:30:53Z

upstream: add load_assigment field to CDS' Cluster

This patch introduces load_assigment field in CDS' Cluster.
This change specifically adds the implementation of the new load_assigment field
for clusters with discovery-type: STATIC, STRICT_DNS and LOGICAL_DNS.

Risk Level: medium.

Testing: unit tests.

Docs Changes:

This unhides docs for endpoint health check config
This adds docs for Cluster's load_assigment field.

Release Notes:

upstream: added a new load_assigment field to CDS' Cluster.

Fixes #439

… member health check config This patch introduces endpoints field in Cluster to allow specifiying per cluster member's health check config. This change specifically adds the implementation of endpoints field for clusters with discovery type STATIC, STRICT_DNS and LOGICAL_DNS. Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

zuercher

Some small stuff, but that looks pretty good to me. Thanks for taking this on.

zuercher · 2018-05-02T16:33:56Z

api/envoy/api/v2/cds.proto

@@ -157,6 +158,45 @@ message Cluster {
  // then hosts is required.
  repeated core.Address hosts = 7;


From my reading of #439, the suggestion was to deprecate this field in favor of the endpoints field you added. Please add a comment on this field that says as much. Also, I believe hosts should have the [deprecated = true] annotation. (@mattklein123/@htuch is that right?)

You'll also need to add an entry in DEPRECATED.md.

Also I think you can remove the [:not-implemented-hide:] tag on HealthCheckConfig in this change.

zuercher · 2018-05-02T16:35:28Z

api/envoy/api/v2/cds.proto

+  //
+  //   Setting this overrides :ref:`hosts<envoy_api_field_Cluster.hosts>` values.
+  //
+  //   As shown bellow, expressing a set of hosts as


I think you can remove from here down.

zuercher · 2018-05-02T16:42:25Z

api/envoy/api/v2/cds.proto

@@ -157,6 +158,45 @@ message Cluster {
  // then hosts is required.
  repeated core.Address hosts = 7;

+  // Setting this instead of :ref:`hosts<envoy_api_field_Cluster.hosts>`, to allow specifying


This should describe endpoints as a required field for specifying members of STATIC, STRICT_DNS, or LOGICAL_DNS clusters and that it supersedes hosts. I would move discussion of per-member health check to a new section in docs/root/intro/arch_overview/health_checking.rst (basically saying you can configure some aspects of health check configuration on a per-member basis via HealthCheckConfig).

zuercher · 2018-05-02T16:43:11Z

docs/root/intro/version_history.rst

@@ -60,6 +60,8 @@ Version history
  <envoy_api_field_Listener.transparent>`.
 * sockets: added `SO_KEEPALIVE` socket option for upstream connections
  :ref:`per cluster <envoy_api_field_Cluster.upstream_connection_options>`.
+* upstream: added a new :ref:`endpoints field<envoy_api_field_Cluster.endpoints>` to allow specifying
+  health check config for each cluster member.


Note that Cluster.hosts is deprecated.

zuercher · 2018-05-02T16:46:57Z

source/common/upstream/logical_dns_cluster.h

@@ -80,14 +87,16 @@ class LogicalDnsCluster : public ClusterImplBase {
    }
    // TODO(dio): To support different address port.


You can remove your TODO

zuercher · 2018-05-02T17:00:48Z

source/common/upstream/logical_dns_cluster.cc

@@ -28,7 +28,8 @@ LogicalDnsCluster::LogicalDnsCluster(const envoy::api::v2::Cluster& cluster,
      tls_(tls.allocateSlot()),
      resolve_timer_(dispatcher.createTimer([this]() -> void { startResolve(); })) {
  const auto& hosts = cluster.hosts();
-  if (hosts.size() != 1) {
+  const auto& endpoints = cluster.endpoints();
+  if (hosts.size() != 1 && endpoints.size() != 1) {


This isn't quite right (it allows an arbitrary number of hosts or endpoints as long as the other only has 1 element).

Maybe if ((endpoints.empty() && hosts.size() != 1) || endpoints.size() != 1)? That at least makes certain that the vector you'll use has exactly one element.

zuercher · 2018-05-02T17:13:48Z

source/common/upstream/logical_dns_cluster.cc

@@ -46,11 +47,16 @@ LogicalDnsCluster::LogicalDnsCluster(const envoy::api::v2::Cluster& cluster,
    NOT_REACHED;
  }

-  const auto& socket_address = hosts[0].socket_address();
+  const auto& socket_address =


You might consider some utility function to convert Cluster.hosts to endpoints (with default HealthCheckConfigs) that could be used here in and in the static and strict dns implementations. I'm not exactly sure where you'd put it, but I think it'll make the hosts/endpoints transition easier to maintain until hosts can be removed.

zuercher · 2018-05-02T17:20:52Z

source/common/upstream/logical_dns_cluster.cc

@@ -88,6 +94,8 @@ void LogicalDnsCluster::startResolve() {
            // Capture URL to avoid a race with another update.
            tls_->runOnAllThreads([this, new_address]() -> void {
              tls_->getTyped<PerThreadCurrentHostData>().current_resolved_address_ = new_address;
+              tls_->getTyped<PerThreadCurrentHostData>().health_check_config_ =
+                  health_check_config_;


Assign the result of tls_->getTyped<PerThreadCurrentHostData>() to local reference and then assign the fields.

Add the deprecation message of using Cluster's hosts field in favor of the new endpoints field. Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Simplify the doc and make it clear the hosts field is deprecated. Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

htuch · 2018-05-03T02:25:38Z

api/envoy/api/v2/cds.proto

+  // .. attention::
+  //
+  //   Setting this overrides :ref:`hosts<envoy_api_field_Cluster.hosts>` values.
+  repeated endpoint.Endpoint endpoints = 31;


Can you update the [#comment:next free field: 31] comment above?

htuch · 2018-05-03T02:28:52Z

api/envoy/api/v2/cds.proto

+  //
+  // .. attention::
+  //
+  //   Setting this overrides :ref:`hosts<envoy_api_field_Cluster.hosts>` values.


I have a higher level API issue I'd like to raise if we're going to add this. From time-to-time, folks wonder if we can provide the full set of EDS capabilities embedded in a CDS response (i.e. in a Cluster). To do this, we would effectively need to have a LocalityLbEndpoints here, rather than repeated Endpoint. It would close one weird inconsistency in the Envoy API, where you can basically get all the behaviors with a static bootstrap config except for some EDS special ones (e.g. locality balancing). @mattklein123 for thoughts as well.

@htuch @mattklein123 could we keep both of them ((core.Address) hosts and (endpoint.LocalityLbEndpoints) endpoints)?

Reason is, I'm not sure if it makes sense: by having hosts will be easier to digest for e.g. a newcomer like me. It's simple and the depth of the config is shallow for specifying cluster members "statically".

A config accommodating endpoint.LocalityLbEndpoints will be something like:

endpoints: lb_endpoints: - endpoint: address: socket_address: address: localhost1 port_value: 11001 health_check_config: port_value: 8000

Which is not only deep but it also has that lb_endpoints. IMO, not super obvious at the first glance for defining cluster members statically.

Agree with @htuch that this is a good opportunity to fix this inconsistency. In general, I agree with @dio that the lb_endpoints construct is more confusing, however, we also optimize for machine generated config. My feeling is to support lb_endpoints, and just have a good example in the docs of a sample configuration. I think with that it should be pretty straightforward for people to use.

Changed to LocalityLbEndpoints in e92c5e5.

About the docs (e.g. example in getting started etc), should I update it together in this PR or I can do that later?

@htuch/@mattklein123 should it be repeated LocalityLbEndpoints as in eds?

@htuch can we consider this, in EDS context, as a config update (onConfigUpdate)?

@dio not sure if I fully grok the question. Are you asking if we can use onConfigUpdate to process the ClusterLoadAssignment when embedded in a Cluster? If so, I don't think you use exactly that method, but you can factor out the logic to somewhere shared between EDS and Cluster load, sure, it's the same code in both cases.

@htuch yes, I meant to take out the logic from eds and use that for other clusters.

I have another question, while refactoring the StaticClusterImpl, I failed to satisfy these conditions: https://github.com/envoyproxy/envoy/blob/master/test/common/upstream/upstream_impl_test.cc#L646-L648. Could you enlight me about those assertions a bit more (why they have to be zero)? Thanks!

@dio those assertions are just an artifact of the old code not supporting localities. If you add support the expectations are likely to change.

An interesting aspect of this PR is that we now support logical DNS in embedded ClusterLoadAssignments. This didn't use to work, we had a number of questions about this IIRC.

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

zuercher · 2018-05-03T17:08:29Z

api/envoy/api/v2/cds.proto

@@ -150,12 +151,24 @@ message Cluster {
  // when picking a host in the cluster.
  LbPolicy lb_policy = 6 [(validate.rules).enum.defined_only = true];

-  // If the service discovery type is
+  // Setting this as a requirement for clusters with discovery type


nit: s/as/is/

zuercher · 2018-05-03T17:09:47Z

api/envoy/api/v2/cds.proto

-  // then hosts is required.
-  repeated core.Address hosts = 7;
+  // or :ref:`LOGICAL_DNS<envoy_api_enum_value_Cluster.DiscoveryType.LOGICAL_DNS>`
+  // is deprecated. Set the :ref:`endpoints<envoy_api_field_Cluster.endpoints>` field


End the sentence after the LOGICAL_DNS reference. And then just "This field is deprecated. Set..."

zuercher · 2018-05-03T17:22:43Z

docs/root/intro/arch_overview/health_checking.rst

+Per cluster member health checking config
+-----------------------------------------
+
+If the active health checking is configured for an upstream cluster, a specific additional configuration


nit: remove the

zuercher · 2018-05-03T17:24:17Z

docs/root/intro/arch_overview/health_checking.rst

+-----------------------------------------
+
+If the active health checking is configured for an upstream cluster, a specific additional configuration
+for each registered member in that cluster's :ref:`endpoints<envoy_api_field_Cluster.endpoints>` can be


I think just "in the cluster can be" -- the HealtchCheckConfig applies to cluster members obtained via EDS as well.

zuercher · 2018-05-03T17:24:42Z

docs/root/intro/arch_overview/health_checking.rst

+If the active health checking is configured for an upstream cluster, a specific additional configuration
+for each registered member in that cluster's :ref:`endpoints<envoy_api_field_Cluster.endpoints>` can be
+specified by setting the :ref:`health check config<envoy_api_msg_endpoint.Endpoint.HealthCheckConfig>`
+of each of them.


nit: remove "of each of them"

zuercher · 2018-05-03T17:26:50Z

api/envoy/api/v2/cds.proto

+  //
+  // .. attention::
+  //
+  //   Setting this overrides :ref:`hosts<envoy_api_field_Cluster.hosts>` values.


@htuch/@mattklein123 should it be repeated LocalityLbEndpoints as in eds?

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

htuch · 2018-05-10T18:30:39Z

@dio friendly ping.

dio · 2018-05-10T21:51:08Z

@htuch sorry for the lag in here. I’ll try to update it today. 🙂

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

htuch · 2018-05-14T14:42:41Z

@dio sure, let me know when you'd like another pass.

mattklein123

@dio thanks this is really great. When we land this we will have lots of consistency. I added some comments from a first pass. I will take another pass once these are resolved.

Also, I would definitely call the regression risk on this change "medium." This is editing a lot of core/scary code and we should definitely give this a very thorough review.

mattklein123 · 2018-05-14T21:16:59Z

DEPRECATED.md

@@ -21,6 +21,9 @@ A logged warning is expected for each deprecated item that is in deprecation win
 * `SAN` is replaced by `URI` in the `x-forwarded-client-cert` header.
 * The `endpoint` field in the http health check filter is deprecated in favor of the `headers`
  field where one can specify HeaderMatch objects to match on.
+* The `hosts` field in the `Cluster` is deprecated in favor of the `load_assigment` field. This change
+  allows CDS assignments to have contained embedded EDS equivalent endpoint assignments and


"CDS assignments" -> "CDS static/DNS assignments"
"to have contained" -> "to contain"

mattklein123 · 2018-05-14T21:17:59Z

api/envoy/api/v2/cds.proto

+  //
+  // .. attention::
+  //
+  //   Setting this allows to use logical DNS for CDS by defining it as an embedded


"allows to use logical DNS for CDS" -> kind of confusing? Maybe word similarly to what I recommended in DEPRECATED.md?

mattklein123 · 2018-05-14T21:19:15Z

docs/root/intro/arch_overview/health_checking.rst

+
+If active health checking is configured for an upstream cluster, a specific additional configuration
+for each registered member can be specified by setting the
+:ref:`health check config<envoy_api_msg_endpoint.Endpoint.HealthCheckConfig>`.


maybe add "in the ... message ..." ? (Basically guide the user and link to where this would be defined as part of the load assignment?) An example would be even better. :)

mattklein123 · 2018-05-14T21:39:22Z

source/common/upstream/logical_dns_cluster.cc

+      priority_state_manager_(new PriorityStateManager(*this, local_info)) {
+  const auto& load_assignment = cluster.has_load_assignment()
+                                    ? cluster.load_assignment()
+                                    : Config::Utility::translateClusterHosts(cluster.hosts());


Technically you are storing reference to temporary here.

mattklein123 · 2018-05-14T21:42:33Z

source/common/upstream/logical_dns_cluster.h

@@ -105,6 +116,9 @@ class LogicalDnsCluster : public ClusterImplBase {
  Network::Address::InstanceConstSharedPtr current_resolved_address_;
  HostSharedPtr logical_host_;
  Network::ActiveDnsQuery* active_dns_query_{};
+  ResolveTargetContextSharedPtr context_;
+


nit: del newline

mattklein123 · 2018-05-14T21:54:37Z

source/common/upstream/upstream_impl.h

+class PriorityStateManager {
+public:
+  PriorityStateManager(ClusterImplBase& cluster, const LocalInfo::LocalInfo& local_info);
+  ~PriorityStateManager() {}


nit: del empty destructor.

mattklein123 · 2018-05-14T21:57:29Z

source/common/upstream/logical_dns_cluster.cc

  dns_url_ = fmt::format("tcp://{}:{}", socket_address.address(), socket_address.port_value());
  hostname_ = Network::Utility::hostFromTcpUrl(dns_url_);
  Network::Utility::portFromTcpUrl(dns_url_);
+  priority_state_manager_->initializePerPriority(locality_lb_endpoint);
+  context_ = std::make_shared<ResolveTargetContext>(locality_lb_endpoint, lb_endpoint);


I'm a little confused about why we need context_. Isn't locality_lb_endpoint and lb_endpoint effectively constant? Can't we just refer to them directly as constance references?

mattklein123 · 2018-05-14T21:58:04Z

source/common/upstream/upstream_impl.h

+ * Wrapper of the current locality LB endpoint and its corresponding LB endpoint context of a
+ * resolved upstream host.
+ */
+class ResolveTargetContext {


See my other comment. I'm a little confused why we need this class.

mattklein123 · 2018-05-14T21:58:21Z

source/common/upstream/upstream_impl.h

@@ -561,6 +623,8 @@ class StrictDnsClusterImpl : public BaseDynamicClusterImpl {
  std::list<ResolveTargetPtr> resolve_targets_;
  const std::chrono::milliseconds dns_refresh_rate_ms_;
  Network::DnsLookupFamily dns_lookup_family_;
+


nit: del newline

mattklein123 · 2018-05-14T22:01:02Z

test/common/upstream/cluster_manager_impl_test.cc

@@ -171,6 +171,7 @@ TEST_F(ClusterManagerImplTest, MultipleProtocolCluster) {
      http_protocol_options: {}
      protocol_selection: USE_DOWNSTREAM_PROTOCOL
  )EOF";
+  EXPECT_CALL(factory_.local_info_, node());


In general, expectations like these don't add much test value since we aren't really testing any actual behavior. Can you instead convert to NiceMock<> so they don't error and then remove these expectations? (Same comment applies everywhere).

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

dio · 2018-05-15T06:19:23Z

@mattklein123 @htuch I think I have addressed all of the comments. PTAL, especially on how to "hold" the ref to load assignment data, currently I make a copy of it and I think I can force it to by-ref when we don't need to translate hosts() to load_assignment().

Also, I would definitely call the regression risk on this change "medium." This is editing a lot of core/scary code and we should definitely give this a very thorough review.

Yes, I'm thinking to add more tests. Do you think it's worth to split upstream_impl_test and put static and strict_dns to their own dedicated test files?

htuch · 2018-05-15T10:49:55Z

api/envoy/api/v2/cds.proto

+  repeated core.Address hosts = 7 [deprecated = true];
+
+  // Setting this is required for specifying members of
+  // :ref:`STATIC<envoy_api_enum_value_Cluster.DiscoveryType.STATIC>`,


Can you update

envoy/api/envoy/api/v2/endpoint/endpoint.proto

Line 21 in 71c0fd6

// The upstream host address.

to indicate that the interpretation of the Address depends on the cluster type. For static, it will be expected to be a direct IP address (or something resolvable by the specified resolver in the Address). For logical/static DNS, it will be expected to be a hostname, resolved via DNS.

This is actually a bit more complicated thinking about it. See the wording at

envoy/api/envoy/api/v2/core/address.proto

Line 36 in 71c0fd6

// hostname to be resolved via DNS. If it is a hostname, :ref:`resolver_name

. I think we should try and get clear in the API (with some implementation TODOs) what the final relationship is going to be between the custom resolvers (which can apply to listener addresses as well, and act on port values/names) and the DNS resolvers for Clusters. @mattklein123 WDYT on this? Seems a rough edge in the API.

Yeah I don't know. That's a good question. Should we just say that custom resolvers can't be used at all with DNS discovery types and block it? I don't think it really makes sense and is confusing. If we do that, I think we can have error checking / error messages to guide people in the right direction...

This would be reasonable. I think if we had the custom resolvers able to operate async, and some hooks to detect DNS changes, we could replace the hardcoded DNS cluster types with just resolver extensions. But, moving the resolver extension model to be expressive enough and then plumbing this would be a fair chunk of work.

htuch

Looks good, some nice potential consolidation/generalization of the EDS behavior here. @alyssawilk probably should take a look w.r.t priority handling.

htuch · 2018-05-15T10:58:15Z

source/common/upstream/upstream_impl.cc

+      if (locality_weighted_lb) {
+        locality_weights->emplace_back(locality_weights_map.at(entry.first));
+      }
+    }


Is this code from eds.cc? Should there be some refactoring?

If there is, I'd suggest pulling the refactor into its own PR - I'm leery of mixing large refactors and functional changes. I think pulling the eds code into its own reusuable class makes total sense but would be easier to consume as a standalone change.

Big +1 on multiple changes. @dio I think this change is great but the size/complexity is scaring me. Can we break up into multiple PRs? The first PRs can just be code movement / adding new utility classes? Then we can merge that PR into this one?

While still missing some tests, I took out the utility class and refactor EDS here: #3783

htuch · 2018-05-15T11:01:43Z

source/common/upstream/logical_dns_cluster.h

+  }
+
+  const envoy::api::v2::endpoint::LbEndpoint& lbEndpoint() const {
+    ASSERT(localityLbEndpoint().lb_endpoints().size() == 1);


htuch · 2018-05-15T11:02:36Z

source/common/upstream/logical_dns_cluster.cc

+  const auto& locality_lb_endpoints = load_assignment_.endpoints();
+  if (locality_lb_endpoints.size() != 1 || locality_lb_endpoints[0].lb_endpoints().size() != 1) {
+    throw EnvoyException(
+        "LOGICAL_DNS clusters must have a single locality_lb_endpoint and a single lb_endpoint");


Is there a test for this?

If I were using the deprecated hosts I'd be really confused at Envoy throwing an error message about there needing to be a single lb_endpoint. I'd encourage switching on the configuration type so for we still have helpful error messages during the transition.

htuch · 2018-05-15T11:03:05Z

source/common/upstream/logical_dns_cluster.h

    HostConstSharedPtr logical_host_;
  };

  struct PerThreadCurrentHostData : public ThreadLocal::ThreadLocalObject {
    Network::Address::InstanceConstSharedPtr current_resolved_address_;
  };

+  const envoy::api::v2::endpoint::LocalityLbEndpoints& localityLbEndpoint() const {
+    ASSERT(load_assignment_.endpoints().size() == 1);


Can you add a comment explaining this is checked in the constructor (at config load time)?

htuch · 2018-05-15T11:04:38Z

source/common/upstream/logical_dns_cluster.cc

-                                       {}, *new_hosts, {});
+
+            const uint32_t priority = localityLbEndpoint().priority();
+            priority_state_manager_->registerHostPerPriority(logical_host_, priority);


registerHostForPriority?

htuch · 2018-05-15T11:07:25Z

source/common/upstream/upstream_impl.h

+                          const envoy::api::v2::endpoint::LbEndpoint& lb_endpoint);
+  void registerHostPerPriority(const HostSharedPtr& host, const uint32_t priority);
+
+  void updateClusterPrioritySet(const uint32_t priority,


Maybe add some comments explaining the contract/relationship between this and the above two methods.

htuch · 2018-05-15T11:08:58Z

source/common/upstream/upstream_impl.cc

+      cluster.has_load_assignment() ? cluster.load_assignment()
+                                    : Config::Utility::translateClusterHosts(cluster.hosts()));
+  for (const auto& locality_lb_endpoint : cluster_load_assignment.endpoints()) {
+    priority_state_manager_->initializePerPriority(locality_lb_endpoint);


initializePriorityFor?

htuch · 2018-05-15T11:10:08Z

source/common/upstream/upstream_impl.h

@@ -490,6 +494,37 @@ class ClusterImplBase : public Cluster, protected Logger::Loggable<Logger::Id::u
  uint64_t pending_initialize_health_checks_{};
 };

+/**
+ * Manage priority state of a cluster.


Is this really used at runtime once state is loaded, or just as a temporary holding ground for priority/host/locality information prior to an update (via updateClusterPrioritySet)?

alyssawilk

+1 - this is going to be great for adding flexibility to backend config. At first pass I think I agree with htuch@ I'd like to avoid the code duplication from eds into upstream - I'll take another pass once we've decided if it's worth splitting this up or not.

alyssawilk · 2018-05-15T13:16:13Z

source/common/upstream/logical_dns_cluster.cc

+  const auto& locality_lb_endpoints = load_assignment_.endpoints();
+  if (locality_lb_endpoints.size() != 1 || locality_lb_endpoints[0].lb_endpoints().size() != 1) {
+    throw EnvoyException(
+        "LOGICAL_DNS clusters must have a single locality_lb_endpoint and a single lb_endpoint");


If I were using the deprecated hosts I'd be really confused at Envoy throwing an error message about there needing to be a single lb_endpoint. I'd encourage switching on the configuration type so for we still have helpful error messages during the transition.

alyssawilk · 2018-05-15T13:23:51Z

source/common/upstream/upstream_impl.h

@@ -490,6 +494,37 @@ class ClusterImplBase : public Cluster, protected Logger::Loggable<Logger::Id::u
  uint64_t pending_initialize_health_checks_{};
 };

+/**
+ * Manage priority state of a cluster.


Do we comment what the PriorityState of a cluster is anywhere? I don't see comments on the typedef and I'd encourage explaining in a bit more depth here or there.

alyssawilk · 2018-05-15T13:25:15Z

source/common/upstream/upstream_impl.cc

+      if (locality_weighted_lb) {
+        locality_weights->emplace_back(locality_weights_map.at(entry.first));
+      }
+    }


If there is, I'd suggest pulling the refactor into its own PR - I'm leery of mixing large refactors and functional changes. I think pulling the eds code into its own reusuable class makes total sense but would be easier to consume as a standalone change.

alyssawilk · 2018-05-15T13:33:37Z

api/envoy/api/v2/cds.proto

+  // or :ref:`LOGICAL_DNS<envoy_api_enum_value_Cluster.DiscoveryType.LOGICAL_DNS>`.
+  // **This field is deprecated**. Set the :ref:`load_assignment<envoy_api_field_Cluster.load_assignment>`
+  // field instead.
+  repeated core.Address hosts = 7 [deprecated = true];


@htuch what's our policy on docs and deprecation? I'd be inclined to say when we deprecate a field we should update the relevant docs (i.e. updating use of hosts in v2_overview.html) so folks cribbing configuration will be cribbing the new way of doing things and not the deprecated way of doing things.

Ideally, yes.

alyssawilk · 2018-05-15T13:44:50Z

source/common/upstream/upstream_impl.cc

+    priority_state_[priority].first.reset(new HostVector());
+  }
+  if (locality_lb_endpoint.has_locality() && locality_lb_endpoint.has_load_balancing_weight()) {
+    priority_state_[priority].second[locality_lb_endpoint.locality()] =


I think this line is untested. I think this PR might benefit from some tests aimed at PriorityStateManager - bounds checking, making sure it handles ill formed updates gracefully and has comments and ASSERTs for cases we believe can't be hit) etc. The decoupling of resizing and adding hosts with priorities, for example, makes me a bit concerned a future user might end up with out of bounds crashes so commenting up the functions could be helpful theer

dio · 2018-05-15T17:35:05Z

@mattklein123 @htuch @alyssawilk thank you for all the reviews! I will continue to work on this in the morning. Yes, I agree this is too big (the first intention was to allow adding custom HealthCheckConfig for each host, but it seems it evolved this far 😄). Seems like I'll create another PR to take out some utilities as @mattklein123 suggested.

Thanks!

zuercher · 2018-05-21T23:14:09Z

Should we close this in favor of replacement PRs in smaller chunks?

dio · 2018-05-22T00:12:02Z

@zuercher Yes, I'm closing it. Thanks for the reminder.

I have several tasks on my plate lately, will update again on weekend. Thanks!

Add load_assignment field in Cluster This patch introduces load_assigment field in CDS' Cluster. This is an API change only. This is part of effort on breaking #3261 into multiple PRs. Risk Level: Low, since it is hidden. Testing: Build api and envoy-static without error Docs Changes: Add load_assignment in Cluster of cds.proto. Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Description: This patch introduces PriorityStateManager to manage priorities/hosts/localities as requirement prior updating the cluster's PrioritySet. Since most of the codes are taken from eds.cc, this patch also refactors EDS codes. This is part of the effort on adding load_assignment field to Cluster as signalled in #3261. Risk Level: Medium Testing: bazel test //test/... Docs Changes: N/A Release Notes: N/A Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

dio · 2018-07-17T04:11:11Z

This PR is resurrected as #3864.

…2 updates (#35076) Bumps the pip group in /examples/grpc-bridge/client with 2 updates: [certifi](https://github.com/certifi/python-certifi) and [urllib3](https://github.com/urllib3/urllib3). Updates `certifi` from 2023.7.22 to 2024.7.4 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/certifi/python-certifi/commit/bd8153872e9c6fc98f4023df9c2deaffea2fa463"><code>bd81538</code></a> 2024.07.04 (<a href="https://redirect.github.com/certifi/python-certifi/issues/295">#295</a>)</li> <li><a href="https://github.com/certifi/python-certifi/commit/06a2cbf21f345563dde6c28b60e29d57e9b210b3"><code>06a2cbf</code></a> Bump peter-evans/create-pull-request from 6.0.5 to 6.1.0 (<a href="https://redirect.github.com/certifi/python-certifi/issues/294">#294</a>)</li> <li><a href="https://github.com/certifi/python-certifi/commit/13bba02b72bac97c432c277158bc04b4d2a6bc23"><code>13bba02</code></a> Bump actions/checkout from 4.1.6 to 4.1.7 (<a href="https://redirect.github.com/certifi/python-certifi/issues/293">#293</a>)</li> <li><a href="https://github.com/certifi/python-certifi/commit/e8abcd0e62b334c164b95d49fcabdc9ecbca0554"><code>e8abcd0</code></a> Bump pypa/gh-action-pypi-publish from 1.8.14 to 1.9.0 (<a href="https://redirect.github.com/certifi/python-certifi/issues/292">#292</a>)</li> <li><a href="https://github.com/certifi/python-certifi/commit/124f4adf171e15cd9a91a8b6e0325ecc97be8fe1"><code>124f4ad</code></a> 2024.06.02 (<a href="https://redirect.github.com/certifi/python-certifi/issues/291">#291</a>)</li> <li><a href="https://github.com/certifi/python-certifi/commit/c2196ce5d6ee675b27755a19948480a7823e2c6a"><code>c2196ce</code></a> --- (<a href="https://redirect.github.com/certifi/python-certifi/issues/290">#290</a>)</li> <li><a href="https://github.com/certifi/python-certifi/commit/fefdeec7588ff1c05214b85a552afcad5fdb51b2"><code>fefdeec</code></a> Bump actions/checkout from 4.1.4 to 4.1.5 (<a href="https://redirect.github.com/certifi/python-certifi/issues/289">#289</a>)</li> <li><a href="https://github.com/certifi/python-certifi/commit/3c5fb1560b826a7f83f1f9750173ff766492c9cf"><code>3c5fb15</code></a> Bump actions/download-artifact from 4.1.6 to 4.1.7 (<a href="https://redirect.github.com/certifi/python-certifi/issues/286">#286</a>)</li> <li><a href="https://github.com/certifi/python-certifi/commit/4a9569a3eb58db8548536fc16c5c5c7af946a5b1"><code>4a9569a</code></a> Bump actions/checkout from 4.1.2 to 4.1.4 (<a href="https://redirect.github.com/certifi/python-certifi/issues/287">#287</a>)</li> <li><a href="https://github.com/certifi/python-certifi/commit/1fc808626a895a916b1e4c2b63abae6c5eafdbe3"><code>1fc8086</code></a> Bump peter-evans/create-pull-request from 6.0.4 to 6.0.5 (<a href="https://redirect.github.com/certifi/python-certifi/issues/288">#288</a>)</li> <li>Additional commits viewable in <a href="https://github.com/certifi/python-certifi/compare/2023.07.22...2024.07.04">compare view</a></li> </ul> </details> <br /> Updates `urllib3` from 2.0.7 to 2.2.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>2.2.2</h2> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Changes</h2> <ul> <li>Added the <code>Proxy-Authorization</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>.</li> <li>Allowed passing negative integers as <code>amt</code> to read methods of <code>http.client.HTTPResponse</code> as an alternative to <code>None</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3122">#3122</a>)</li> <li>Fixed return types representing copying actions to use <code>typing.Self</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3363">#3363</a>)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/urllib3/urllib3/compare/2.2.1...2.2.2">https://github.com/urllib3/urllib3/compare/2.2.1...2.2.2</a></p> <h2>2.2.1</h2> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Changes</h2> <ul> <li>Fixed issue where <code>InsecureRequestWarning</code> was emitted for HTTPS connections when using Emscripten. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3331">#3331</a>)</li> <li>Fixed <code>HTTPConnectionPool.urlopen</code> to stop automatically casting non-proxy headers to <code>HTTPHeaderDict</code>. This change was premature as it did not apply to proxy headers and <code>HTTPHeaderDict</code> does not handle byte header values correctly yet. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3343">#3343</a>)</li> <li>Changed <code>ProtocolError</code> to <code>InvalidChunkLength</code> when response terminates before the chunk length is sent. (<a href="https://redirect.github.com/urllib3/urllib3/issues/2860">#2860</a>)</li> <li>Changed <code>ProtocolError</code> to be more verbose on incomplete reads with excess content. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3261">#3261</a>)</li> </ul> <h2>2.2.0</h2> <h2>🖥️ urllib3 now works in the browser</h2> <p>:tada: <strong>This release adds experimental support for <a href="https://urllib3.readthedocs.io/en/stable/reference/contrib/emscripten.html">using urllib3 in the browser with Pyodide</a>!</strong> 🎉</p> <p>Thanks to Joe Marshall (<a href="https://github.com/joemarshall"><code>@joemarshall</code></a>) for contributing this feature. This change was possible thanks to work done in urllib3 v2.0 to detach our API from <code>http.client</code>. Please report all bugs to the <a href="https://github.com/urllib3/urllib3/issues">urllib3 issue tracker</a>.</p> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Changes</h2> <ul> <li>Added support for <a href="https://urllib3.readthedocs.io/en/latest/reference/contrib/emscripten.html">Emscripten and Pyodide</a>, including streaming support in cross-origin isolated browser environments where threading is enabled. (<a href="https://redirect.github.com/urllib3/urllib3/issues/2951">#2951</a>)</li> <li>Added support for <code>HTTPResponse.read1()</code> method. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3186">#3186</a>)</li> <li>Added rudimentary support for HTTP/2. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3284">#3284</a>)</li> <li>Fixed issue where requests against urls with trailing dots were failing due to SSL errors when using proxy. (<a href="https://redirect.github.com/urllib3/urllib3/issues/2244">#2244</a>)</li> <li>Fixed <code>HTTPConnection.proxy_is_verified</code> and <code>HTTPSConnection.proxy_is_verified</code> to be always set to a boolean after connecting to a proxy. It could be <code>None</code> in some cases previously. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3130">#3130</a>)</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h1>2.2.2 (2024-06-17)</h1> <ul> <li>Added the <code>Proxy-Authorization</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>.</li> <li>Allowed passing negative integers as <code>amt</code> to read methods of <code>http.client.HTTPResponse</code> as an alternative to <code>None</code>. (<code>[#3122](urllib3/urllib3#3122) <https://github.com/urllib3/urllib3/issues/3122></code>__)</li> <li>Fixed return types representing copying actions to use <code>typing.Self</code>. (<code>[#3363](urllib3/urllib3#3363) <https://github.com/urllib3/urllib3/issues/3363></code>__)</li> </ul> <h1>2.2.1 (2024-02-16)</h1> <ul> <li>Fixed issue where <code>InsecureRequestWarning</code> was emitted for HTTPS connections when using Emscripten. (<code>[#3331](urllib3/urllib3#3331) <https://github.com/urllib3/urllib3/issues/3331></code>__)</li> <li>Fixed <code>HTTPConnectionPool.urlopen</code> to stop automatically casting non-proxy headers to <code>HTTPHeaderDict</code>. This change was premature as it did not apply to proxy headers and <code>HTTPHeaderDict</code> does not handle byte header values correctly yet. (<code>[#3343](urllib3/urllib3#3343) <https://github.com/urllib3/urllib3/issues/3343></code>__)</li> <li>Changed <code>InvalidChunkLength</code> to <code>ProtocolError</code> when response terminates before the chunk length is sent. (<code>[#2860](urllib3/urllib3#2860) <https://github.com/urllib3/urllib3/issues/2860></code>__)</li> <li>Changed <code>ProtocolError</code> to be more verbose on incomplete reads with excess content. (<code>[#3261](urllib3/urllib3#3261) <https://github.com/urllib3/urllib3/issues/3261></code>__)</li> </ul> <h1>2.2.0 (2024-01-30)</h1> <ul> <li>Added support for <code>Emscripten and Pyodide <https://urllib3.readthedocs.io/en/latest/reference/contrib/emscripten.html></code><strong>, including streaming support in cross-origin isolated browser environments where threading is enabled. (<code>[#2951](urllib3/urllib3#2951) <https://github.com/urllib3/urllib3/issues/2951></code></strong>)</li> <li>Added support for <code>HTTPResponse.read1()</code> method. (<code>[#3186](urllib3/urllib3#3186) <https://github.com/urllib3/urllib3/issues/3186></code>__)</li> <li>Added rudimentary support for HTTP/2. (<code>[#3284](urllib3/urllib3#3284) <https://github.com/urllib3/urllib3/issues/3284></code>__)</li> <li>Fixed issue where requests against urls with trailing dots were failing due to SSL errors when using proxy. (<code>[#2244](urllib3/urllib3#2244) <https://github.com/urllib3/urllib3/issues/2244></code>__)</li> <li>Fixed <code>HTTPConnection.proxy_is_verified</code> and <code>HTTPSConnection.proxy_is_verified</code> to be always set to a boolean after connecting to a proxy. It could be <code>None</code> in some cases previously. (<code>[#3130](urllib3/urllib3#3130) <https://github.com/urllib3/urllib3/issues/3130></code>__)</li> <li>Fixed an issue where <code>headers</code> passed in a request with <code>json=</code> would be mutated (<code>[#3203](urllib3/urllib3#3203) <https://github.com/urllib3/urllib3/issues/3203></code>__)</li> <li>Fixed <code>HTTPSConnection.is_verified</code> to be set to <code>False</code> when connecting from a HTTPS proxy to an HTTP target. It was set to <code>True</code> previously. (<code>[#3267](urllib3/urllib3#3267) <https://github.com/urllib3/urllib3/issues/3267></code>__)</li> <li>Fixed handling of new error message from OpenSSL 3.2.0 when configuring an HTTP proxy as HTTPS (<code>[#3268](urllib3/urllib3#3268) <https://github.com/urllib3/urllib3/issues/3268></code>__)</li> <li>Fixed TLS 1.3 post-handshake auth when the server certificate validation is disabled (<code>[#3325](urllib3/urllib3#3325) <https://github.com/urllib3/urllib3/issues/3325></code>__)</li> <li>Note for downstream distributors: To run integration tests, you now need to run the tests a second time with the <code>--integration</code> pytest flag. (<code>[#3181](urllib3/urllib3#3181) <https://github.com/urllib3/urllib3/issues/3181></code>__)</li> </ul> <h1>2.1.0 (2023-11-13)</h1> <ul> <li>Removed support for the deprecated urllib3[secure] extra. (<code>[#2680](urllib3/urllib3#2680) <https://github.com/urllib3/urllib3/issues/2680></code>__)</li> <li>Removed support for the deprecated SecureTransport TLS implementation. (<code>[#2681](urllib3/urllib3#2681) <https://github.com/urllib3/urllib3/issues/2681></code>__)</li> <li>Removed support for the end-of-life Python 3.7. (<code>[#3143](urllib3/urllib3#3143) <https://github.com/urllib3/urllib3/issues/3143></code>__)</li> <li>Allowed loading CA certificates from memory for proxies. (<code>[#3065](urllib3/urllib3#3065) <https://github.com/urllib3/urllib3/issues/3065></code>__)</li> <li>Fixed decoding Gzip-encoded responses which specified <code>x-gzip</code> content-encoding. (<code>[#3174](urllib3/urllib3#3174) <https://github.com/urllib3/urllib3/issues/3174></code>__)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/27e2a5c5a7ab6a517252cc8dcef3ffa6ffb8f61a"><code>27e2a5c</code></a> Release 2.2.2 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3406">#3406</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/accff72ecc2f6cf5a76d9570198a93ac7c90270e"><code>accff72</code></a> Merge pull request from GHSA-34jh-p97f-mpxf</li> <li><a href="https://github.com/urllib3/urllib3/commit/34be4a57e59eb7365bcc37d52e9f8271b5b8d0d3"><code>34be4a5</code></a> Pin CFFI to a new release candidate instead of a Git commit (<a href="https://redirect.github.com/urllib3/urllib3/issues/3398">#3398</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/da410581b6b3df73da976b5ce5eb20a4bd030437"><code>da41058</code></a> Bump browser-actions/setup-chrome from 1.6.0 to 1.7.1 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3399">#3399</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b07a669bd970d69847801148286b726f0570b625"><code>b07a669</code></a> Bump github/codeql-action from 2.13.4 to 3.25.6 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3396">#3396</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b8589ec9f8c4da91511e601b632ac06af7e7c10e"><code>b8589ec</code></a> Measure coverage with v4 of artifact actions (<a href="https://redirect.github.com/urllib3/urllib3/issues/3394">#3394</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/f3bdc5585111429e22c81b5fb26c3ec164d98b81"><code>f3bdc55</code></a> Allow triggering CI manually (<a href="https://redirect.github.com/urllib3/urllib3/issues/3391">#3391</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/52392654b30183129cf3ec06010306f517d9c146"><code>5239265</code></a> Fix HTTP version in debug log (<a href="https://redirect.github.com/urllib3/urllib3/issues/3316">#3316</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b34619f94ece0c40e691a5aaf1304953d88089de"><code>b34619f</code></a> Bump actions/checkout to 4.1.4 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3387">#3387</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/9961d14de7c920091d42d42ed76d5d479b80064d"><code>9961d14</code></a> Bump browser-actions/setup-chrome from 1.5.0 to 1.6.0 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3386">#3386</a>)</li> <li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/2.0.7...2.2.2">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/envoyproxy/envoy/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…e/client in the pip group (#34784) Bumps the pip group in /examples/grpc-bridge/client with 1 update: [urllib3](https://github.com/urllib3/urllib3). Updates `urllib3` from 2.0.7 to 2.2.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>2.2.2</h2> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Changes</h2> <ul> <li>Added the <code>Proxy-Authorization</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>.</li> <li>Allowed passing negative integers as <code>amt</code> to read methods of <code>http.client.HTTPResponse</code> as an alternative to <code>None</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3122">#3122</a>)</li> <li>Fixed return types representing copying actions to use <code>typing.Self</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3363">#3363</a>)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/urllib3/urllib3/compare/2.2.1...2.2.2">https://github.com/urllib3/urllib3/compare/2.2.1...2.2.2</a></p> <h2>2.2.1</h2> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Changes</h2> <ul> <li>Fixed issue where <code>InsecureRequestWarning</code> was emitted for HTTPS connections when using Emscripten. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3331">#3331</a>)</li> <li>Fixed <code>HTTPConnectionPool.urlopen</code> to stop automatically casting non-proxy headers to <code>HTTPHeaderDict</code>. This change was premature as it did not apply to proxy headers and <code>HTTPHeaderDict</code> does not handle byte header values correctly yet. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3343">#3343</a>)</li> <li>Changed <code>ProtocolError</code> to <code>InvalidChunkLength</code> when response terminates before the chunk length is sent. (<a href="https://redirect.github.com/urllib3/urllib3/issues/2860">#2860</a>)</li> <li>Changed <code>ProtocolError</code> to be more verbose on incomplete reads with excess content. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3261">#3261</a>)</li> </ul> <h2>2.2.0</h2> <h2>🖥️ urllib3 now works in the browser</h2> <p>:tada: <strong>This release adds experimental support for <a href="https://urllib3.readthedocs.io/en/stable/reference/contrib/emscripten.html">using urllib3 in the browser with Pyodide</a>!</strong> 🎉</p> <p>Thanks to Joe Marshall (<a href="https://github.com/joemarshall"><code>@joemarshall</code></a>) for contributing this feature. This change was possible thanks to work done in urllib3 v2.0 to detach our API from <code>http.client</code>. Please report all bugs to the <a href="https://github.com/urllib3/urllib3/issues">urllib3 issue tracker</a>.</p> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Changes</h2> <ul> <li>Added support for <a href="https://urllib3.readthedocs.io/en/latest/reference/contrib/emscripten.html">Emscripten and Pyodide</a>, including streaming support in cross-origin isolated browser environments where threading is enabled. (<a href="https://redirect.github.com/urllib3/urllib3/issues/2951">#2951</a>)</li> <li>Added support for <code>HTTPResponse.read1()</code> method. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3186">#3186</a>)</li> <li>Added rudimentary support for HTTP/2. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3284">#3284</a>)</li> <li>Fixed issue where requests against urls with trailing dots were failing due to SSL errors when using proxy. (<a href="https://redirect.github.com/urllib3/urllib3/issues/2244">#2244</a>)</li> <li>Fixed <code>HTTPConnection.proxy_is_verified</code> and <code>HTTPSConnection.proxy_is_verified</code> to be always set to a boolean after connecting to a proxy. It could be <code>None</code> in some cases previously. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3130">#3130</a>)</li> </ul>  </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h1>2.2.2 (2024-06-17)</h1> <ul> <li>Added the <code>Proxy-Authorization</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>.</li> <li>Allowed passing negative integers as <code>amt</code> to read methods of <code>http.client.HTTPResponse</code> as an alternative to <code>None</code>. (<code>[#3122](urllib3/urllib3#3122) <https://github.com/urllib3/urllib3/issues/3122></code>__)</li> <li>Fixed return types representing copying actions to use <code>typing.Self</code>. (<code>[#3363](urllib3/urllib3#3363) <https://github.com/urllib3/urllib3/issues/3363></code>__)</li> </ul> <h1>2.2.1 (2024-02-16)</h1> <ul> <li>Fixed issue where <code>InsecureRequestWarning</code> was emitted for HTTPS connections when using Emscripten. (<code>[#3331](urllib3/urllib3#3331) <https://github.com/urllib3/urllib3/issues/3331></code>__)</li> <li>Fixed <code>HTTPConnectionPool.urlopen</code> to stop automatically casting non-proxy headers to <code>HTTPHeaderDict</code>. This change was premature as it did not apply to proxy headers and <code>HTTPHeaderDict</code> does not handle byte header values correctly yet. (<code>[#3343](urllib3/urllib3#3343) <https://github.com/urllib3/urllib3/issues/3343></code>__)</li> <li>Changed <code>InvalidChunkLength</code> to <code>ProtocolError</code> when response terminates before the chunk length is sent. (<code>[#2860](urllib3/urllib3#2860) <https://github.com/urllib3/urllib3/issues/2860></code>__)</li> <li>Changed <code>ProtocolError</code> to be more verbose on incomplete reads with excess content. (<code>[#3261](urllib3/urllib3#3261) <https://github.com/urllib3/urllib3/issues/3261></code>__)</li> </ul> <h1>2.2.0 (2024-01-30)</h1> <ul> <li>Added support for <code>Emscripten and Pyodide <https://urllib3.readthedocs.io/en/latest/reference/contrib/emscripten.html></code><strong>, including streaming support in cross-origin isolated browser environments where threading is enabled. (<code>[#2951](urllib3/urllib3#2951) <https://github.com/urllib3/urllib3/issues/2951></code></strong>)</li> <li>Added support for <code>HTTPResponse.read1()</code> method. (<code>[#3186](urllib3/urllib3#3186) <https://github.com/urllib3/urllib3/issues/3186></code>__)</li> <li>Added rudimentary support for HTTP/2. (<code>[#3284](urllib3/urllib3#3284) <https://github.com/urllib3/urllib3/issues/3284></code>__)</li> <li>Fixed issue where requests against urls with trailing dots were failing due to SSL errors when using proxy. (<code>[#2244](urllib3/urllib3#2244) <https://github.com/urllib3/urllib3/issues/2244></code>__)</li> <li>Fixed <code>HTTPConnection.proxy_is_verified</code> and <code>HTTPSConnection.proxy_is_verified</code> to be always set to a boolean after connecting to a proxy. It could be <code>None</code> in some cases previously. (<code>[#3130](urllib3/urllib3#3130) <https://github.com/urllib3/urllib3/issues/3130></code>__)</li> <li>Fixed an issue where <code>headers</code> passed in a request with <code>json=</code> would be mutated (<code>[#3203](urllib3/urllib3#3203) <https://github.com/urllib3/urllib3/issues/3203></code>__)</li> <li>Fixed <code>HTTPSConnection.is_verified</code> to be set to <code>False</code> when connecting from a HTTPS proxy to an HTTP target. It was set to <code>True</code> previously. (<code>[#3267](urllib3/urllib3#3267) <https://github.com/urllib3/urllib3/issues/3267></code>__)</li> <li>Fixed handling of new error message from OpenSSL 3.2.0 when configuring an HTTP proxy as HTTPS (<code>[#3268](urllib3/urllib3#3268) <https://github.com/urllib3/urllib3/issues/3268></code>__)</li> <li>Fixed TLS 1.3 post-handshake auth when the server certificate validation is disabled (<code>[#3325](urllib3/urllib3#3325) <https://github.com/urllib3/urllib3/issues/3325></code>__)</li> <li>Note for downstream distributors: To run integration tests, you now need to run the tests a second time with the <code>--integration</code> pytest flag. (<code>[#3181](urllib3/urllib3#3181) <https://github.com/urllib3/urllib3/issues/3181></code>__)</li> </ul> <h1>2.1.0 (2023-11-13)</h1> <ul> <li>Removed support for the deprecated urllib3[secure] extra. (<code>[#2680](urllib3/urllib3#2680) <https://github.com/urllib3/urllib3/issues/2680></code>__)</li> <li>Removed support for the deprecated SecureTransport TLS implementation. (<code>[#2681](urllib3/urllib3#2681) <https://github.com/urllib3/urllib3/issues/2681></code>__)</li> <li>Removed support for the end-of-life Python 3.7. (<code>[#3143](urllib3/urllib3#3143) <https://github.com/urllib3/urllib3/issues/3143></code>__)</li> <li>Allowed loading CA certificates from memory for proxies. (<code>[#3065](urllib3/urllib3#3065) <https://github.com/urllib3/urllib3/issues/3065></code>__)</li> <li>Fixed decoding Gzip-encoded responses which specified <code>x-gzip</code> content-encoding. (<code>[#3174](urllib3/urllib3#3174) <https://github.com/urllib3/urllib3/issues/3174></code>__)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/27e2a5c5a7ab6a517252cc8dcef3ffa6ffb8f61a"><code>27e2a5c</code></a> Release 2.2.2 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3406">#3406</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/accff72ecc2f6cf5a76d9570198a93ac7c90270e"><code>accff72</code></a> Merge pull request from GHSA-34jh-p97f-mpxf</li> <li><a href="https://github.com/urllib3/urllib3/commit/34be4a57e59eb7365bcc37d52e9f8271b5b8d0d3"><code>34be4a5</code></a> Pin CFFI to a new release candidate instead of a Git commit (<a href="https://redirect.github.com/urllib3/urllib3/issues/3398">#3398</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/da410581b6b3df73da976b5ce5eb20a4bd030437"><code>da41058</code></a> Bump browser-actions/setup-chrome from 1.6.0 to 1.7.1 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3399">#3399</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b07a669bd970d69847801148286b726f0570b625"><code>b07a669</code></a> Bump github/codeql-action from 2.13.4 to 3.25.6 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3396">#3396</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b8589ec9f8c4da91511e601b632ac06af7e7c10e"><code>b8589ec</code></a> Measure coverage with v4 of artifact actions (<a href="https://redirect.github.com/urllib3/urllib3/issues/3394">#3394</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/f3bdc5585111429e22c81b5fb26c3ec164d98b81"><code>f3bdc55</code></a> Allow triggering CI manually (<a href="https://redirect.github.com/urllib3/urllib3/issues/3391">#3391</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/52392654b30183129cf3ec06010306f517d9c146"><code>5239265</code></a> Fix HTTP version in debug log (<a href="https://redirect.github.com/urllib3/urllib3/issues/3316">#3316</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b34619f94ece0c40e691a5aaf1304953d88089de"><code>b34619f</code></a> Bump actions/checkout to 4.1.4 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3387">#3387</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/9961d14de7c920091d42d42ed76d5d479b80064d"><code>9961d14</code></a> Bump browser-actions/setup-chrome from 1.5.0 to 1.6.0 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3386">#3386</a>)</li> <li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/2.0.7...2.2.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=urllib3&package-manager=pip&previous-version=2.0.7&new-version=2.2.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/envoyproxy/envoy/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ip group (#34786) Bumps the pip group in /tools/base with 1 update: [urllib3](https://github.com/urllib3/urllib3). Updates `urllib3` from 2.2.0 to 2.2.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/releases">urllib3's releases</a>.</em></p> <blockquote> <h2>2.2.2</h2> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Changes</h2> <ul> <li>Added the <code>Proxy-Authorization</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>.</li> <li>Allowed passing negative integers as <code>amt</code> to read methods of <code>http.client.HTTPResponse</code> as an alternative to <code>None</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3122">#3122</a>)</li> <li>Fixed return types representing copying actions to use <code>typing.Self</code>. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3363">#3363</a>)</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/urllib3/urllib3/compare/2.2.1...2.2.2">https://github.com/urllib3/urllib3/compare/2.2.1...2.2.2</a></p> <h2>2.2.1</h2> <h2>🚀 urllib3 is fundraising for HTTP/2 support</h2> <p><a href="https://sethmlarson.dev/urllib3-is-fundraising-for-http2-support">urllib3 is raising ~$40,000 USD</a> to release HTTP/2 support and ensure long-term sustainable maintenance of the project after a sharp decline in financial support for 2023. If your company or organization uses Python and would benefit from HTTP/2 support in Requests, pip, cloud SDKs, and thousands of other projects <a href="https://opencollective.com/urllib3">please consider contributing financially</a> to ensure HTTP/2 support is developed sustainably and maintained for the long-haul.</p> <p>Thank you for your support.</p> <h2>Changes</h2> <ul> <li>Fixed issue where <code>InsecureRequestWarning</code> was emitted for HTTPS connections when using Emscripten. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3331">#3331</a>)</li> <li>Fixed <code>HTTPConnectionPool.urlopen</code> to stop automatically casting non-proxy headers to <code>HTTPHeaderDict</code>. This change was premature as it did not apply to proxy headers and <code>HTTPHeaderDict</code> does not handle byte header values correctly yet. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3343">#3343</a>)</li> <li>Changed <code>ProtocolError</code> to <code>InvalidChunkLength</code> when response terminates before the chunk length is sent. (<a href="https://redirect.github.com/urllib3/urllib3/issues/2860">#2860</a>)</li> <li>Changed <code>ProtocolError</code> to be more verbose on incomplete reads with excess content. (<a href="https://redirect.github.com/urllib3/urllib3/issues/3261">#3261</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/urllib3/urllib3/blob/main/CHANGES.rst">urllib3's changelog</a>.</em></p> <blockquote> <h1>2.2.2 (2024-06-17)</h1> <ul> <li>Added the <code>Proxy-Authorization</code> header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via <code>Retry.remove_headers_on_redirect</code>.</li> <li>Allowed passing negative integers as <code>amt</code> to read methods of <code>http.client.HTTPResponse</code> as an alternative to <code>None</code>. (<code>[#3122](urllib3/urllib3#3122) <https://github.com/urllib3/urllib3/issues/3122></code>__)</li> <li>Fixed return types representing copying actions to use <code>typing.Self</code>. (<code>[#3363](urllib3/urllib3#3363) <https://github.com/urllib3/urllib3/issues/3363></code>__)</li> </ul> <h1>2.2.1 (2024-02-16)</h1> <ul> <li>Fixed issue where <code>InsecureRequestWarning</code> was emitted for HTTPS connections when using Emscripten. (<code>[#3331](urllib3/urllib3#3331) <https://github.com/urllib3/urllib3/issues/3331></code>__)</li> <li>Fixed <code>HTTPConnectionPool.urlopen</code> to stop automatically casting non-proxy headers to <code>HTTPHeaderDict</code>. This change was premature as it did not apply to proxy headers and <code>HTTPHeaderDict</code> does not handle byte header values correctly yet. (<code>[#3343](urllib3/urllib3#3343) <https://github.com/urllib3/urllib3/issues/3343></code>__)</li> <li>Changed <code>InvalidChunkLength</code> to <code>ProtocolError</code> when response terminates before the chunk length is sent. (<code>[#2860](urllib3/urllib3#2860) <https://github.com/urllib3/urllib3/issues/2860></code>__)</li> <li>Changed <code>ProtocolError</code> to be more verbose on incomplete reads with excess content. (<code>[#3261](urllib3/urllib3#3261) <https://github.com/urllib3/urllib3/issues/3261></code>__)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/urllib3/urllib3/commit/27e2a5c5a7ab6a517252cc8dcef3ffa6ffb8f61a"><code>27e2a5c</code></a> Release 2.2.2 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3406">#3406</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/accff72ecc2f6cf5a76d9570198a93ac7c90270e"><code>accff72</code></a> Merge pull request from GHSA-34jh-p97f-mpxf</li> <li><a href="https://github.com/urllib3/urllib3/commit/34be4a57e59eb7365bcc37d52e9f8271b5b8d0d3"><code>34be4a5</code></a> Pin CFFI to a new release candidate instead of a Git commit (<a href="https://redirect.github.com/urllib3/urllib3/issues/3398">#3398</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/da410581b6b3df73da976b5ce5eb20a4bd030437"><code>da41058</code></a> Bump browser-actions/setup-chrome from 1.6.0 to 1.7.1 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3399">#3399</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b07a669bd970d69847801148286b726f0570b625"><code>b07a669</code></a> Bump github/codeql-action from 2.13.4 to 3.25.6 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3396">#3396</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b8589ec9f8c4da91511e601b632ac06af7e7c10e"><code>b8589ec</code></a> Measure coverage with v4 of artifact actions (<a href="https://redirect.github.com/urllib3/urllib3/issues/3394">#3394</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/f3bdc5585111429e22c81b5fb26c3ec164d98b81"><code>f3bdc55</code></a> Allow triggering CI manually (<a href="https://redirect.github.com/urllib3/urllib3/issues/3391">#3391</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/52392654b30183129cf3ec06010306f517d9c146"><code>5239265</code></a> Fix HTTP version in debug log (<a href="https://redirect.github.com/urllib3/urllib3/issues/3316">#3316</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/b34619f94ece0c40e691a5aaf1304953d88089de"><code>b34619f</code></a> Bump actions/checkout to 4.1.4 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3387">#3387</a>)</li> <li><a href="https://github.com/urllib3/urllib3/commit/9961d14de7c920091d42d42ed76d5d479b80064d"><code>9961d14</code></a> Bump browser-actions/setup-chrome from 1.5.0 to 1.6.0 (<a href="https://redirect.github.com/urllib3/urllib3/issues/3386">#3386</a>)</li> <li>Additional commits viewable in <a href="https://github.com/urllib3/urllib3/compare/2.2.0...2.2.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=urllib3&package-manager=pip&previous-version=2.2.0&new-version=2.2.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/envoyproxy/envoy/network/alerts). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

dio added 2 commits May 1, 2018 17:03

Update version history

a974b87

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

ggreenway assigned zuercher May 1, 2018

zuercher reviewed May 2, 2018

View reviewed changes

dio added 7 commits May 3, 2018 08:45

review: update DEPRECATED.md

036a319

Add the deprecation message of using Cluster's hosts field in favor of the new endpoints field. Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: update cds.proto doc

88090ed

Simplify the doc and make it clear the hosts field is deprecated. Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: add discussion about HealthCheckConfig

8da2c60

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: add deprecation note

ed08cd2

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: translate hosts to endpoints

9ba78d3

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: remove TODO

14b0d23

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Fix version history entry

bd6ac42

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

htuch suggested changes May 3, 2018

View reviewed changes

dio added 3 commits May 3, 2018 16:09

review: use LocalityLbEndpoints instead of Endpoints

8b2ee7f

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: implement Cluster.endpoints as LocalityLbEndpoints

e92c5e5

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Fix logical dns cluster test

1626fab

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

zuercher reviewed May 3, 2018

View reviewed changes

htuch self-assigned this May 3, 2018

htuch mentioned this pull request May 8, 2018

Create script that uses /config_dump to create a static Envoy config #3310

Open

dio added 6 commits May 8, 2018 13:06

Use ClusterLoadAssignment instead

3213dd1

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Merge remote-tracking branch 'upstream/master'

d887de6

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Back to square 1

8629c7b

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Merge remote-tracking branch 'upstream/master'

11c77b3

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Merge remote-tracking branch 'upstream/master'

f2bbd12

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Refactor static cluster

cf34a06

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

dio added 4 commits May 11, 2018 15:51

Merge remote-tracking branch 'upstream/master'

c019448

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: add load_assignment

df77682

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: health check docs update

2708782

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Translate cluster hosts to load_assignment

c5db329

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

mattklein123 reviewed May 14, 2018

View reviewed changes

dio added 9 commits May 15, 2018 08:01

review: reword DEPRECATED.md

9c6254f

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: update health checking config doc

1a2f404

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: update CDS doc

572cf12

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: NiceMock-ing LocalInfo

decca86

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

review: remove context

d3ed76e

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Copy the temporary

b79ddbe

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Fix unnecessary additions and removals

af559be

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Remove more unnecessary additions and removals

b88200c

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

Update cds.proto next free field

3cc11be

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>

htuch reviewed May 15, 2018

View reviewed changes

htuch suggested changes May 15, 2018

View reviewed changes

alyssawilk reviewed May 15, 2018

View reviewed changes

dio closed this May 22, 2018

dio mentioned this pull request May 30, 2018

Add load_assignment field in Cluster #3504

Merged

dio mentioned this pull request Jul 3, 2018

upstream: introduce PriorityStateManager, refactor EDS #3783

Merged

dio mentioned this pull request Jul 19, 2018

upstream: implement Cluster's load_assignment field #3864

Merged

dio mentioned this pull request Nov 5, 2018

Remove cluster.hosts #4959

Closed

dio mentioned this pull request Jul 22, 2019

v1 cleanup: delete several unused conversion paths #7681

Merged

		@@ -157,6 +158,45 @@ message Cluster {
		// then hosts is required.
		repeated core.Address hosts = 7;

		@@ -80,14 +87,16 @@ class LogicalDnsCluster : public ClusterImplBase {
		}
		// TODO(dio): To support different address port.

upstream: add load_assigment field to Cluster #3261

upstream: add load_assigment field to Cluster #3261

Conversation

dio commented May 1, 2018 • edited Loading

zuercher left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

htuch commented May 10, 2018

dio commented May 10, 2018

htuch commented May 14, 2018

mattklein123 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dio commented May 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

htuch left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dio Jul 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alyssawilk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dio commented May 15, 2018

zuercher commented May 21, 2018

dio commented May 22, 2018

dio commented Jul 17, 2018

dio commented May 1, 2018 •

edited

Loading

dio Jul 3, 2018 •

edited

Loading