-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upstream: add load_assigment field to Cluster #3261
Closed
Closed
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
0c95fab
upstream cluster: introduce endpoints to allow specifying per cluster…
dio a974b87
Update version history
dio 036a319
review: update DEPRECATED.md
dio 88090ed
review: update cds.proto doc
dio 8da2c60
review: add discussion about HealthCheckConfig
dio ed08cd2
review: add deprecation note
dio 9ba78d3
review: translate hosts to endpoints
dio 14b0d23
review: remove TODO
dio bd6ac42
Fix version history entry
dio 8b2ee7f
review: use LocalityLbEndpoints instead of Endpoints
dio e92c5e5
review: implement Cluster.endpoints as LocalityLbEndpoints
dio 1626fab
Fix logical dns cluster test
dio 3213dd1
Use ClusterLoadAssignment instead
dio d887de6
Merge remote-tracking branch 'upstream/master'
dio 8629c7b
Back to square 1
dio 11c77b3
Merge remote-tracking branch 'upstream/master'
dio f2bbd12
Merge remote-tracking branch 'upstream/master'
dio cf34a06
Refactor static cluster
dio c019448
Merge remote-tracking branch 'upstream/master'
dio df77682
review: add load_assignment
dio 2708782
review: health check docs update
dio c5db329
Translate cluster hosts to load_assignment
dio fc8251e
Update DEPRECATED.md
dio 675bb90
Fix build api
dio 5879fd5
review: remove const for translateClusterHosts
dio 4bfd57e
Locality-aware StrictDnsCluster
dio 1a48994
Use common function for STATIC and STRICT_DNS
dio a34c195
review: update docs
dio 669fa63
Local info for LOGICAL_DNS
dio cb69f92
Add simple tests using load_assignment
dio 307e247
Fix comments breakpoints
dio c724f2a
Context namespacing
dio 37c6c72
Introduce priority state manager
dio 81fc59d
Remove initializePrioritySet
dio 9c6254f
review: reword DEPRECATED.md
dio 1a2f404
review: update health checking config doc
dio 572cf12
review: update CDS doc
dio decca86
review: NiceMock-ing LocalInfo
dio d3ed76e
review: remove context
dio b79ddbe
Copy the temporary
dio af559be
Fix unnecessary additions and removals
dio b88200c
Remove more unnecessary additions and removals
dio 3cc11be
Update cds.proto next free field
dio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
review: add discussion about HealthCheckConfig
Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
- Loading branch information
commit 8da2c6087116837ec2bccab221a36a2050dac36d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,14 @@ unhealthy, successes required before marking a host healthy, etc.): | |
maintenance by setting the specified key to any value and waiting for traffic to drain. See | ||
:ref:`redis_key <config_cluster_manager_cluster_hc_redis_key>`. | ||
|
||
Per cluster member health checking config | ||
----------------------------------------- | ||
|
||
If the active health checking is configured for an upstream cluster, a specific additional configuration | ||
for each registered member in that cluster's :ref:`endpoints<envoy_api_field_Cluster.endpoints>` can be | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think just "in the cluster can be" -- the HealtchCheckConfig applies to cluster members obtained via EDS as well. |
||
specified by setting the :ref:`health check config<envoy_api_msg_endpoint.Endpoint.HealthCheckConfig>` | ||
of each of them. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: remove "of each of them" |
||
|
||
Passive health checking | ||
----------------------- | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove the