Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 cleanup: delete several unused conversion paths #7681

Merged
merged 3 commits into from
Jul 23, 2019

Conversation

mattklein123
Copy link
Member

Risk Level: Low
Testing: Existing and modified tests. Note that I removed some redundant tests and error messages.
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Matt Klein <mklein@lyft.com>
@mattklein123
Copy link
Member Author

@derekargueta PTAL

derekargueta
derekargueta previously approved these changes Jul 22, 2019
Copy link
Member

@derekargueta derekargueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good. Just one nit.

source/common/upstream/logical_dns_cluster.cc Outdated Show resolved Hide resolved
Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Copy link
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mattklein123 mattklein123 merged commit 8d6cd7e into master Jul 23, 2019
@mattklein123 mattklein123 deleted the delete_cds_json branch July 23, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants