Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unread message/mention comes back after closing the browser and re-opening #23847

Closed
MomentQYC opened this issue Nov 28, 2022 · 3 comments · Fixed by matrix-org/matrix-js-sdk#2916
Closed

Unread message/mention comes back after closing the browser and re-opening #23847

MomentQYC opened this issue Nov 28, 2022 · 3 comments · Fixed by matrix-org/matrix-js-sdk#2916
Assignees
@germain-gg
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@MomentQYC
Copy link
Contributor

Steps to reproduce

When a message is last sent by a contact with a mention/response after logging in or after closing the client/browser and reopening it, it will still show up as an unread messages even if the message was read before.

Outcome

What did you expect?

Normal use.

What happened instead?

There is a problem with the display.

Operating system

Ubuntu (Actually all clients have this problem)

Browser information

Edge 107.0

URL for webapp

No response

Application version

Element Web/Desktop 1.11.15 Element iOS 1.9.12

Homeserver

Synapse 1.72.0

Will you send logs?

No
@MadLittleMods MadLittleMods added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 29, 2022
@MadLittleMods
Copy link
Contributor

MadLittleMods commented Nov 29, 2022 •
edited
Loading

@MomentQYC matrix-js-sdk only persists /sync data to IndexDB every 5 minutes so it's possible you see the mention, close the app before 5 minutes has passed and when you open the app again, the app re-syncs and you see the notification again.

Does this sound accurate to your scenario?

@MadLittleMods MadLittleMods changed the title There is a problem with the display of unread messages Unread message/mention comes back after closing the browser and re-opening it Nov 29, 2022
@MadLittleMods MadLittleMods changed the title Unread message/mention comes back after closing the browser and re-opening it Unread message/mention comes back after closing the browser and re-opening Nov 29, 2022
@MomentQYC
Copy link
Contributor Author

@MomentQYC matrix-js-sdk only persists /sync data to IndexDB every 5 minutes so it's possible you see the mention, close the app before 5 minutes has passed and when you open the app again, the app re-syncs and you see the notification again.

Does this sound accurate to your scenario?

No.
This problem still occurs when reopening after a long period of time without closing.It is known that Desktop client and iOS client (Android client I have not tested) will also have the problem, and, for example, the problem will still occur when opening Element Web B when Element Web A is open for a long time.

@germain-gg germain-gg mentioned this issue Nov 29, 2022
Merged
3 tasks
@germain-gg germain-gg self-assigned this Nov 29, 2022
@ThoreKr
Copy link

ThoreKr commented Nov 29, 2022

Not sure if this is related or a separate issue, but were observing very similar issues with Element Web/Desktop 1.11.15 and since updating to 1.11.14.

However, the issue is somewhat inverted, as the unread message notification count status (icon in the room list, favicon indicator) resets about every 5 minutes. It goes away when klicking at the room again, but other clients won't notice.

Synapse is version 1.72.0 as well.

When opening the rooms in element android or with cinny, they are properly considered as read on all devices.

@MomentQYC MomentQYC mentioned this issue Nov 30, 2022
Open
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Dec 6, 2022
@su-ex
Merge tag 'v22.0.0' into sc
789e2bf 
* Enable users to join group calls from multiple devices ([\matrix-org#2902](matrix-org#2902)).
* Deprecate a function containing a typo ([\matrix-org#2904](matrix-org#2904)).
* sliding sync: add receipts extension ([\matrix-org#2912](matrix-org#2912)).
* Define a spec support policy for the js-sdk ([\matrix-org#2882](matrix-org#2882)).
* Further improvements to e2ee logging ([\matrix-org#2900](matrix-org#2900)).
* sliding sync: add support for typing extension ([\matrix-org#2893](matrix-org#2893)).
* Improve logging on Olm session errors ([\matrix-org#2885](matrix-org#2885)).
* Improve logging of e2ee messages ([\matrix-org#2884](matrix-org#2884)).
* Fix 3pid invite acceptance not working due to mxid being sent in body ([\matrix-org#2907](matrix-org#2907)). Fixes element-hq/element-web#23823.
* Don't hang up calls that haven't started yet ([\matrix-org#2898](matrix-org#2898)).
* Read receipt accumulation for threads ([\matrix-org#2881](matrix-org#2881)).
* Make GroupCall work better with widgets ([\matrix-org#2935](matrix-org#2935)).
* Fix highlight notifications increasing when total notification is zero ([\matrix-org#2937](matrix-org#2937)). Fixes element-hq/element-web#23885.
* Fix synthesizeReceipt ([\matrix-org#2916](matrix-org#2916)). Fixes element-hq/element-web#23827 element-hq/element-web#23754 and element-hq/element-web#23847.
@ThoreKr ThoreKr mentioned this issue Dec 25, 2022
Closed
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Jan 15, 2023
@su-ex
Merge tag 'v23.0.0' into sc
b9afe23 
* Process `m.room.encryption` events before emitting `RoomMember` events ([\matrix-org#2914](matrix-org#2914)). Fixes element-hq/element-web#23819.
* Don't expose `calls` on `GroupCall` ([\matrix-org#2941](matrix-org#2941)).
* Support MSC3391: Account data deletion ([\matrix-org#2967](matrix-org#2967)).
* Add a message ID on each to-device message ([\matrix-org#2938](matrix-org#2938)).
* Enable multiple users' power levels to be set at once ([\matrix-org#2892](matrix-org#2892)). Contributed by @GoodGuyMarco.
* Include pending events in thread summary and count again ([\matrix-org#2922](matrix-org#2922)). Fixes element-hq/element-web#23642.
* Make GroupCall work better with widgets ([\matrix-org#2935](matrix-org#2935)).
* Add method to get outgoing room key requests for a given event ([\matrix-org#2930](matrix-org#2930)).
* Fix messages loaded during initial fetch ending up out of order ([\matrix-org#2971](matrix-org#2971)). Fixes element-hq/element-web#23972.
* Fix #23919: Root message for new thread loaded from network ([\matrix-org#2965](matrix-org#2965)). Fixes element-hq/element-web#23919.
* Fix #23916: Prevent edits of the last message in a thread getting lost ([\matrix-org#2951](matrix-org#2951)). Fixes element-hq/element-web#23916 and element-hq/element-web#23942.
* Fix infinite loop when restoring cached read receipts ([\matrix-org#2963](matrix-org#2963)). Fixes element-hq/element-web#23951.
* Don't swallow errors coming from the shareSession call ([\matrix-org#2962](matrix-org#2962)). Fixes element-hq/element-web#23792.
* Make sure that MegolmEncryption.setupPromise always resolves  ([\matrix-org#2960](matrix-org#2960)).
* Do not calculate highlight notifs for threads unknown to the room ([\matrix-org#2957](matrix-org#2957)).
* Cache read receipts for unknown threads ([\matrix-org#2953](matrix-org#2953)).
* bugfix: sliding sync initial room timelines shouldn't notify ([\matrix-org#2933](matrix-org#2933)).
* Redo key sharing after own device verification ([\matrix-org#2921](matrix-org#2921)). Fixes element-hq/element-web#23333.
* Move updated threads to the end of the thread list ([\matrix-org#2923](matrix-org#2923)). Fixes element-hq/element-web#23876.
* Fix highlight notifications increasing when total notification is zero ([\matrix-org#2937](matrix-org#2937)). Fixes element-hq/element-web#23885.
* Fix synthesizeReceipt ([\matrix-org#2916](matrix-org#2916)). Fixes element-hq/element-web#23827 element-hq/element-web#23754 and element-hq/element-web#23847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix synthesizeReceipt matrix-org/matrix-js-sdk
4 participants
@MadLittleMods @germain-gg @ThoreKr @MomentQYC