Read receipt accumulation for threads #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following MSC3771, read receipts are not unique per room per user id. It is now possible for a single user id to have multiple read receipts across threads and the main room timeline. The sync accumulator was not taking this into consideration and was always persisting the last read receipt it had received
justjanne
approved these changes
Nov 16, 2022
germain-gg
deleted the
gsouquet/sync-accumulator-thread-read-receipts
branch
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Dec 6, 2022
* Enable users to join group calls from multiple devices ([\matrix-org#2902](matrix-org#2902)). * Deprecate a function containing a typo ([\matrix-org#2904](matrix-org#2904)). * sliding sync: add receipts extension ([\matrix-org#2912](matrix-org#2912)). * Define a spec support policy for the js-sdk ([\matrix-org#2882](matrix-org#2882)). * Further improvements to e2ee logging ([\matrix-org#2900](matrix-org#2900)). * sliding sync: add support for typing extension ([\matrix-org#2893](matrix-org#2893)). * Improve logging on Olm session errors ([\matrix-org#2885](matrix-org#2885)). * Improve logging of e2ee messages ([\matrix-org#2884](matrix-org#2884)). * Fix 3pid invite acceptance not working due to mxid being sent in body ([\matrix-org#2907](matrix-org#2907)). Fixes element-hq/element-web#23823. * Don't hang up calls that haven't started yet ([\matrix-org#2898](matrix-org#2898)). * Read receipt accumulation for threads ([\matrix-org#2881](matrix-org#2881)). * Make GroupCall work better with widgets ([\matrix-org#2935](matrix-org#2935)). * Fix highlight notifications increasing when total notification is zero ([\matrix-org#2937](matrix-org#2937)). Fixes element-hq/element-web#23885. * Fix synthesizeReceipt ([\matrix-org#2916](matrix-org#2916)). Fixes element-hq/element-web#23827 element-hq/element-web#23754 and element-hq/element-web#23847.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following MSC3771, read receipts are not unique per room per user id.
It is now possible for a single user id to have multiple read receipts across threads and the main room timeline.
The sync accumulator was not taking this into consideration and was always persisting the last read receipt it had received
Checklist
Here's what your changelog entry will look like:
🐛 Bug Fixes