Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't join a room through an invitation link #23823

Closed
tsouza-squid opened this issue Nov 23, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2907
Closed

Can't join a room through an invitation link #23823

tsouza-squid opened this issue Nov 23, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2907
Assignees
@t3chguy
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@tsouza-squid
Copy link

Steps to reproduce

  1. Click on an invitation link that looks like https://app.element.io/#/room/...
  2. Login into Element using Google Account.
  3. Click the Join the discussion button.

Outcome

What did you expect?

Accept the invitation and enter the room

What happened instead?

An error was returned: MatrixError: [400] Missing parameters: private_key,token (https://vector.im/_matrix/identity/api/v1/sign-ed25519?token=<some_token>)

Operating system

macOS Ventura 13.0.1

Browser information

Chrome Version 107.0.5304.110 (Official Build) (arm64)

URL for webapp

app.element.io

Application version

Element version: 1.11.15, Olm version: 3.2.12

Homeserver

I don't know

Will you send logs?

Yes
@t3chguy t3chguy self-assigned this Nov 23, 2022
@andybalaam andybalaam added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Invite labels Nov 24, 2022
@t3chguy t3chguy added X-Regression X-Release-Blocker and removed S-Minor Impairs non-critical functionality or suitable workarounds exist A-Invite O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 24, 2022
@t3chguy t3chguy mentioned this issue Nov 24, 2022
Merged
@kittykat kittykat added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Nov 24, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Dec 6, 2022
@su-ex
Merge tag 'v22.0.0' into sc
789e2bf 
* Enable users to join group calls from multiple devices ([\matrix-org#2902](matrix-org#2902)).
* Deprecate a function containing a typo ([\matrix-org#2904](matrix-org#2904)).
* sliding sync: add receipts extension ([\matrix-org#2912](matrix-org#2912)).
* Define a spec support policy for the js-sdk ([\matrix-org#2882](matrix-org#2882)).
* Further improvements to e2ee logging ([\matrix-org#2900](matrix-org#2900)).
* sliding sync: add support for typing extension ([\matrix-org#2893](matrix-org#2893)).
* Improve logging on Olm session errors ([\matrix-org#2885](matrix-org#2885)).
* Improve logging of e2ee messages ([\matrix-org#2884](matrix-org#2884)).
* Fix 3pid invite acceptance not working due to mxid being sent in body ([\matrix-org#2907](matrix-org#2907)). Fixes element-hq/element-web#23823.
* Don't hang up calls that haven't started yet ([\matrix-org#2898](matrix-org#2898)).
* Read receipt accumulation for threads ([\matrix-org#2881](matrix-org#2881)).
* Make GroupCall work better with widgets ([\matrix-org#2935](matrix-org#2935)).
* Fix highlight notifications increasing when total notification is zero ([\matrix-org#2937](matrix-org#2937)). Fixes element-hq/element-web#23885.
* Fix synthesizeReceipt ([\matrix-org#2916](matrix-org#2916)). Fixes element-hq/element-web#23827 element-hq/element-web#23754 and element-hq/element-web#23847.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 3pid invite acceptance not working due to mxid being sent in body matrix-org/matrix-js-sdk
4 participants
@kittykat @andybalaam @t3chguy @tsouza-squid