Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timelion] Fix tests flakiness on suggestion click #87273

Merged
merged 3 commits into from
Jan 11, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Jan 5, 2021

Summary

Closes #86514.
It seems that on cloud there is a latency on clicking the suggestions which result on messing up with the timelion expression.
The screenshots from the Cloud failures indicate this.

timelion app expression typeahead dynamic suggestions for argument values es should show field suggestions for metric argument when index pattern set

split and metric are messed up as the split field is not defined correctly. The correct expression is depicted below

image

I increased the waitTime from 1000 to 2000 for the clickSuggestion in order to give more time to the test to click the suggestion and then proceed to the rest checks.

@stratoula stratoula added Feature:Timelion Timelion app and visualization test-cloud labels Jan 5, 2021
@stratoula stratoula marked this pull request as ready for review January 5, 2021 10:29
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula added v8.0.0 v7.12.0 v7.11.0 release_note:skip Skip the PR/issue when compiling release notes labels Jan 5, 2021
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit bfac16e into elastic:master Jan 11, 2021
stratoula added a commit to stratoula/kibana that referenced this pull request Jan 11, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula added a commit to stratoula/kibana that referenced this pull request Jan 11, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 11, 2021
* master:
  [APM] Define placement “Right” to offset tooltip (elastic#87729)
  Fix UI glitch on SOM delete confirmation modal (elastic#87623)
  Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies (elastic#86988)
  [Timelion] Fix tests flakiness on suggestion click (elastic#87273)
  [Uptime] Fix/details page tabs (elastic#86296)
  [ML] Fix earliest and latest texts for date fields (elastic#87482)
  chore(NA): move grokdebugger plugin test fixtures out of __tests__ folder (elastic#87765)
  [Security Solution] Refactor Cypress scenarios to use internal contex… (elastic#86609)
  [Security Solution] Unskip cypress tests (elastic#86653)
stratoula added a commit that referenced this pull request Jan 11, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
stratoula added a commit that referenced this pull request Jan 11, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Timelion Timelion app and visualization release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test-cloud v7.11.0 v7.12.0 v8.0.0
Projects
None yet
4 participants