Fixes flakiness on timelion suggestions

[stratoula]

Summary

Closes #89352
Flaky cloud tester run for 15 times https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/
This is going to remove the flakiness (I hope). What we want is to test that the suggestions are returned.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[stratoula]

@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[stratoula]

@elasticmachine merge upstream

[flash1293]

@stratoula Can you explain what the original issue was? It seems like it's showing one additional suggestion?

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 9a9e49d

Metrics [docs]

✅ unchanged

History

• 💚 Build #102115 succeeded e45ac45
• 💚 Build #102077 succeeded e21ea20
• 💚 Build #101725 succeeded 278ce2f
• 💔 Build #101707 failed 37999e5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[stratoula]

@flash1293 yes. When it failed for the first time I noticed this:

I thought that there was a latency on the suggestion click so on this PR I increased the timeout #87273

But this was not the problem. I used a 7.11 cloud instance and I saw at first that the suggestions loaded for the split on the cloud are not the same as locally (locally never fails).

And an additional note here: The way that these timelion tests work is: update the expression, click a suggestion from the list, then update again the expression, clicking another suggestion. Imho, it seems to be very flaky for cloud.

[flash1293]

Is it an issue the expression in the screenshot is broken?

[stratoula]

The expression brokes when the test fails, so it fails on expect(suggestions.length).to.eql(51); and it gets confused and then the steps are not followed correctly and the expression brokes. But the problem starts with the number of the suggestions that on 7.11 (haven't checked other versions tbh) are 53. Does it answer your question? Sorry, not sure if I got it correctly 🙂

[flash1293]

Got it, makes sense, thanks. LGTM to fix the test for now, but as it's loosening our test coverage a little, it would be cool to add back a better test for this later.

If I understood correctly, the suggestion list didn't updated yet and that's why the number is wrong, so we could also add a retry loop for the 51:

await retry.try(async () => {
  const suggestions = await PageObjects.timelion.getSuggestionItemsText();
  expect(suggestions.length).to.eql(51);
});

[stratoula]

Thanx Joe! I tried it but retry doesn't fix it. The suggestion list always returns a wrong number so I will create an issue to investigate it and also fix the coverage