Fix UI glitch on SOM delete confirmation modal #87623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
v7.11.1
v7.12.0
v8.0.0
release_note:skip
TinaHeiligers
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Code LGTM (I like the restructuring that makes the saved_objects_table more concise). I ran the code and it works great too!
I think it's worth documenting why we had to change from EuiConfirmModal to EuiModal so that other devs don't fall into this trap. If EUI isn't adding that to their docs as a warning, we should at the very least add it to our a11y docs.
Aside: There are now 3 modals in the components folder, maybe we should think about moving those to their own folder (e.g. components/modals). WDYT?
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jan 11, 2021
* extract delete confirm modal * extract the export modal * add data-test-subj to confirm modal * add comment on why we can't use EuiConfirmModal
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Jan 11, 2021
* extract delete confirm modal * extract the export modal * add data-test-subj to confirm modal * add comment on why we can't use EuiConfirmModal
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 11, 2021
* master: [APM] Define placement “Right” to offset tooltip (elastic#87729) Fix UI glitch on SOM delete confirmation modal (elastic#87623) Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies (elastic#86988) [Timelion] Fix tests flakiness on suggestion click (elastic#87273) [Uptime] Fix/details page tabs (elastic#86296) [ML] Fix earliest and latest texts for date fields (elastic#87482) chore(NA): move grokdebugger plugin test fixtures out of __tests__ folder (elastic#87765) [Security Solution] Refactor Cypress scenarios to use internal contex… (elastic#86609) [Security Solution] Unskip cypress tests (elastic#86653)
pgayvallet
added a commit
that referenced
this pull request
Jan 11, 2021
pgayvallet
added a commit
that referenced
this pull request
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #87232
Screenshots
Before
After
Checklist