[Security Solution] Fix Cypress scenarios to use internal contex… #86609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t instead of raw variables
patrykkopycinski
added
chore
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
MadameSheema
approved these changes
Dec 22, 2020
…-context # Conflicts: # x-pack/plugins/security_solution/cypress/integration/alerts.spec.ts # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules.spec.ts # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_custom.spec.ts # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_eql.spec.ts # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_export.spec.ts # x-pack/plugins/security_solution/cypress/integration/alerts_detection_rules_prebuilt.spec.ts # x-pack/plugins/security_solution/cypress/integration/alerts_timeline.spec.ts # x-pack/plugins/security_solution/cypress/integration/cases.spec.ts # x-pack/plugins/security_solution/cypress/integration/timeline_attach_to_case.spec.ts # x-pack/plugins/security_solution/cypress/integration/timeline_creation.spec.ts # x-pack/plugins/security_solution/cypress/integration/timeline_local_storage.spec.ts # x-pack/plugins/security_solution/cypress/integration/timeline_templates_export.spec.ts # x-pack/plugins/security_solution/cypress/integration/timeline_toggle_column.spec.ts # x-pack/plugins/security_solution/cypress/integration/timelines_export.spec.ts # x-pack/plugins/security_solution/cypress/integration/value_lists.spec.ts # x-pack/plugins/security_solution/cypress/screens/timeline.ts # x-pack/plugins/security_solution/cypress/tasks/common.ts # x-pack/plugins/security_solution/cypress/tasks/hosts/events.ts # x-pack/plugins/security_solution/cypress/tasks/timeline.ts
…ibana into chore/cypress-context
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
patrykkopycinski
added
bug
patrykkopycinski
changed the title
This was referenced Jan 8, 2021
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jan 8, 2021
patrykkopycinski
added a commit
to patrykkopycinski/kibana
that referenced
this pull request
Jan 8, 2021
patrykkopycinski
added a commit
that referenced
this pull request
Jan 8, 2021
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
patrykkopycinski
added a commit
that referenced
this pull request
Jan 8, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 11, 2021
* master: [APM] Define placement “Right” to offset tooltip (elastic#87729) Fix UI glitch on SOM delete confirmation modal (elastic#87623) Remove src/plugins/vis_default_editor -> src/plugins/visualizations cyclic dependencies (elastic#86988) [Timelion] Fix tests flakiness on suggestion click (elastic#87273) [Uptime] Fix/details page tabs (elastic#86296) [ML] Fix earliest and latest texts for date fields (elastic#87482) chore(NA): move grokdebugger plugin test fixtures out of __tests__ folder (elastic#87765) [Security Solution] Refactor Cypress scenarios to use internal contex… (elastic#86609) [Security Solution] Unskip cypress tests (elastic#86653)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t instead of raw variables
Summary
I've addressed 4 issues:
es_archiversometimes was taking more than 60s to finish the process, so it timeout out and caused tests to be flakyhttps://github.com/elastic/kibana/pull/86609/files#diff-b5d2a46b3a0ee15acb1ab8a5b3a43f12c7357327d1091e39c9ef54896a036df4R68
Sharing contextinstead of raw variableshttps://docs.cypress.io/guides/core-concepts/variables-and-aliases.html#Aliases
https://github.com/elastic/kibana/pull/86609/files#diff-f4573759efd270d01ba5b90d4884561abed6a0f8a0dc014b0ce24dfe44c5361aR123
should()instead ofthen()to support retry-ability of the assertionshttps://docs.cypress.io/guides/core-concepts/retry-ability.html#Use-should-with-a-callback
https://github.com/elastic/kibana/pull/86609/files#diff-f4573759efd270d01ba5b90d4884561abed6a0f8a0dc014b0ce24dfe44c5361aR209
Checklist