Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: temporarily disable checking some user_agent fields #14179

Closed
wants to merge 5 commits into from
Closed

Flaky test: temporarily disable checking some user_agent fields #14179

wants to merge 5 commits into from

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 21, 2019

Beats CI filebeat tests start failing caused by something changed with the user_agent plugin or regex, specifically user_agent.os.name, user_agent.name and user_agent.version field: https://travis-ci.org/elastic/beats/jobs/600418441#L2184

Removing some specific user_agent fields from checking instead of disabling the whole test_modules.py test.

Elasticsearch issue is created to track the real fix for the failing tests: elastic/elasticsearch#48318

@kaiyan-sheng kaiyan-sheng self-assigned this Oct 21, 2019
@kaiyan-sheng kaiyan-sheng added Team:Integrations Label for the Integrations team flaky-test Unstable or unreliable test cases. [zube]: In Review review labels Oct 21, 2019
@jsoriano
Copy link
Member

An alternative to this: #14190, although files will need to be regenerated again if some changes are done to fix elastic/elasticsearch#48318

@kaiyan-sheng
Copy link
Contributor Author

Actually I prefer Jaime's change #14190 in this case. So when the problem is fixed in ES, our CI will break again and we can regenerate the files to fix it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Unstable or unreliable test cases. review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants