-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate expected user agent fields #14190
Merged
ycombinator
merged 2 commits into
elastic:master
from
jsoriano:regenerate-expected-user-agent-fields
Oct 22, 2019
Merged
Regenerate expected user agent fields #14190
ycombinator
merged 2 commits into
elastic:master
from
jsoriano:regenerate-expected-user-agent-fields
Oct 22, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
approved these changes
Oct 22, 2019
jenkins, test this again please |
Travis CI is green. Jenkins CI failures are unrelated. Merging... |
This was referenced Oct 24, 2019
urso
pushed a commit
to urso/beats
that referenced
this pull request
Oct 30, 2019
This reverts commit 6acc229.
For the record, backport of this (or equivalent regeneration of expected outputs) to 7.x will be only needed if elastic/elasticsearch#47807 is backported to ES 7.x. |
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
* Regenerate expected user agent fields * Regenerate files of x-pack modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User agent plugin seems to have changed, and some expected
fields are different. Regenerate expected fields in golden files.
See #14179 and elastic/elasticsearch#48318 for more details.