Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: temporarily disable checking some user_agent fields #14179

Closed
wants to merge 5 commits into from
Closed

Flaky test: temporarily disable checking some user_agent fields #14179

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19b1007
Disable checking user_agent.os.name and user_agent.version
kaiyan-sheng Oct 21, 2019
8e72234
Add user_agent.name to the list
kaiyan-sheng Oct 22, 2019
58aa423
Add user_agent.device.name
kaiyan-sheng Oct 22, 2019
689b58d
Remove user_agent.original
kaiyan-sheng Oct 22, 2019
8589035
Run mage fmt
kaiyan-sheng Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion filebeat/tests/system/test_modules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,12 +231,16 @@ def clean_keys(obj):
('system.auth', 'timestamp.log')
}

# flaky test, temporarily remove user_agent fields
user_agent_keys = ["user_agent.os.name", "user_agent.version",
"user_agent.name", "user_agent.device.name", "user_agent.original"]

# Keep source log filename for exceptions
filename = None
if "log.file.path" in obj:
filename = os.path.basename(obj["log.file.path"]).lower()

for key in host_keys + time_keys + other_keys + ecs_key:
for key in host_keys + time_keys + other_keys + ecs_key + user_agent_keys:
delete_key(obj, key)

# Most logs from syslog need their timestamp removed because it doesn't
Expand Down