-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs on what privileges are needed for using metricbeat mongodb module #13932
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Hi @hwang381 thanks for working on this! In order to fix the failing test we need to execute In addition, I think we should also mention these privileges on each Metricset's documentation explicitly, for instance at https://www.elastic.co/guide/en/beats/metricbeat/current/metricbeat-metricset-mongodb-collstats.html we could mention that |
Thanks for the feedback @ChrsMark Regard documenting the privileges needed for every metricset in their respective doc page, do you think it would be better idea to just put the documentation in the respective metricset doc instead of putting it in the general module documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, I have only added some comments about punctuation.
@hwang381 did you have the chance of testing these privileges with metricbeat and a running MongoDB?
@hwang381 thanks for your work on this! After revisiting the issue and mongodb docs your patch refers to, I would propose to add small snippets on each metricset's docs which will show how one can create users and grant the right privileges on them. For example on Create user with proper privileges for the metricsetCreate the role
create the privileged user
So, the users will be able to easily create the mongo-user required to run the spesific metricset, but also we would be able to confirm that the privileges we document will do the job. Let me know what you think! @jsoriano feel free to add/comment on anything! |
+1 to that, maybe we can also add an example with a role with all the privileges in the module docs. |
I've integrated all the above suggestions :) |
ok to test |
jenkins, test this again please |
@ChrsMark I think we can merge this, metricbeat builds are green. |
I will go along and merge this! Thank you @hwang381 for working on this! |
…odule (elastic#13932) (cherry picked from commit 324e9a4)
…odule (elastic#13932) (cherry picked from commit 324e9a4)
…odule (elastic#13932) (cherry picked from commit 324e9a4)
…odule (elastic#13932) (cherry picked from commit 324e9a4)
…odule (elastic#13932) (elastic#14192) (cherry picked from commit f5feba4)
…odule (elastic#13932) (elastic#14194) (cherry picked from commit f5feba4)
resolves #13820