JIT: ARM64 SVE format encodings, SVE_HX_3A_B to SVE_JL_3A and SVE_IC_3A to SVE_IC_3A_C
#98332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsContributes to #94549 Adds formats:
Left: Capstone,
|
TIHan
changed the title
SVE_HX_3A_B to SVE_JL_3A' and SVE_IC_3A to SVE_IC_3A_C`SVE_HX_3A_B to SVE_JL_3A and SVE_IC_3A to SVE_IC_3A_C
|
@dotnet/jit-contrib @dotnet/arm64-contrib @kunalspathak @a74nh this is ready. |
Diff results for #98332Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64Overall (+0.04% to +0.08%)
MinOpts (+0.06% to +0.18%)
FullOpts (+0.04% to +0.08%)
Throughput diffs for osx/arm64 ran on windows/x64Overall (+0.04% to +0.08%)
MinOpts (+0.06% to +0.15%)
FullOpts (+0.03% to +0.08%)
Throughput diffs for windows/arm64 ran on windows/x64Overall (+0.04% to +0.08%)
MinOpts (+0.07% to +0.18%)
FullOpts (+0.04% to +0.08%)
Details here Throughput diffs for linux/arm64 ran on linux/x64MinOpts (-0.00% to +0.01%)
Details here |
a74nh
reviewed
Feb 13, 2024
amanasifkhalid
approved these changes
Feb 15, 2024
src/coreclr/jit/emitarm64.cpp
Outdated
| * | ||
| * Prints the encoding for format [<Zn>.D{, #<imm>}] | ||
| */ | ||
| void emitter::emitDispSveImmIndex(regNumber reg1, insOpts opt, ssize_t imm) |
There was a problem hiding this comment.
Can this logic be merged into emitDispSveImm in #98468 (or the other way around)?
There was a problem hiding this comment.
It doesn't matter either way. I'll have to resolve any conflicts when my PRs get merged, and that will include some cleanup.
|
Also do you know where the TP impact is coming from on Windows x64? Your changes look like they only affect SVE paths. |
|
It's probably just the additional cases in emitIns. Should split it out to see if the TP regressions clear up. |
Diff results for #98332Throughput diffsThroughput diffs for linux/arm64 ran on windows/x64MinOpts (-0.00% to +0.01%)
Throughput diffs for osx/arm64 ran on windows/x64MinOpts (-0.01% to +0.01%)
Details here |
|
Merging, failures are not related. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #94549
Adds formats:
Left: Capstone,
Right: Jit