Let the debugger knows DATAS is on #107115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc |
This was referenced Aug 29, 2024
mangod9
reviewed
Aug 29, 2024
cshung
force-pushed
the
public/datas-debugger
branch
from
bad6f39 to
9a23f47
Compare
This was referenced Jan 9, 2025
3 tasks
cshung
force-pushed
the
public/datas-debugger
branch
from
9a23f47 to
449dc49
Compare
hoyosjs
reviewed
Jan 10, 2025
mikem8361
pushed a commit
to dotnet/diagnostics
that referenced
this pull request
Jan 24, 2025
This PR is meant to support #5090. This PR is the diagnostics side of the work, this exposes a new field so that the debugger can display the information. There are two more PRs on different repos to support this: The code won't compile until the clrmd dependency is consumed. On runtime: dotnet/runtime#107115 On clrmd: microsoft/clrmd#1301
cshung
force-pushed
the
public/datas-debugger
branch
from
449dc49 to
1654a69
Compare
|
@hoyosjs, can you please take a look again? |
hoyosjs
approved these changes
Jan 31, 2025
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 4, 2025
* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is repurposed to support dotnet/diagnostics#5090.
This PR is the runtime side of the work, this exposes a new API so that the debugger can display the information.
There are two more PRs on different repos to support this:
On clrmd: microsoft/clrmd#1301
On diagnostics: dotnet/diagnostics#5164