Let the debugger knows DATAS is on #5164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2025
mikem8361
approved these changes
Jan 10, 2025
|
The required CLRMD change should be referenced by main now. If you rebase/merge the latest main branch, it should work/build. |
cshung
force-pushed
the
public/datas-debugger
branch
from
9c997f8 to
c3fba0d
Compare
|
@cshung you have Linux/Alpine build errors. |
I will take a look. |
cshung
force-pushed
the
public/datas-debugger
branch
from
c3fba0d to
17d1f77
Compare
mikem8361
approved these changes
Jan 24, 2025
danmoseley
reviewed
Jan 31, 2025
| @@ -448,6 +448,7 @@ private ulong PrintGCHeap(ClrRuntime clrRuntime) | |||
| { | |||
| Console.WriteLine(); | |||
| ClrHeap heap = clrRuntime.Heap; | |||
| Console.WriteLine("DATAS = " + heap.DynamicAdaptationMode); | |||
There was a problem hiding this comment.
I thought it was called dynamic GC now not DATAS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to support #5090.
This PR is the diagnostics side of the work, this exposes a new field so that the debugger can display the information.
There are two more PRs on different repos to support this:
The code won't compile until the clrmd dependency is consumed.
On runtime: dotnet/runtime#107115
On clrmd: microsoft/clrmd#1301