Change how we build the cross-OS DAC to support building in the VMR #111927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quite rare nowadays and we have CI protection against build failures. Remove the linux dac from the default build subsets to speed up the default build experience.
…sing a separate artifact
Download less and don't extract into the same folder our sources are in Correctly handle extracting nugets manually vs restoring them Extract with a one line powershell script instead Fix artifacts lookup folder. Fix the extraction root Just use Version for now and we'll figure out stabilization later Try extracting into a separate powershell script and not using Expand-Archive. Also, adjust the layout to match NuGet package layout if we're writing our own script
|
Tagging subscribers to this area: @hoyosjs |
… cross-dac invocation from the join jobs.
ViktorHofer
reviewed
Jan 28, 2025
3 tasks
This was referenced Jan 29, 2025
hoyosjs
reviewed
Feb 3, 2025
...r/.nuget/Microsoft.CrossOsDiag.Private.CoreCLR/Microsoft.CrossOsDiag.Private.CoreCLR.pkgproj
Show resolved
Hide resolved
...eclr/.nuget/Microsoft.CrossOsDiag.Private.CoreCLR/Microsoft.CrossOsDiag.Private.CoreCLR.proj
Show resolved
Hide resolved
|
Official build link with signing enabled: https://dev.azure.com/dnceng/internal/_build/results?buildId=2634189&view=results |
hoyosjs
approved these changes
Feb 4, 2025
grendello
added a commit
to grendello/runtime
that referenced
this pull request
Feb 4, 2025
* main: (30 commits) JIT: Optimize bit-wise AND with a constant mask in combination with a left shift in a compare (dotnet#111979) Change how we build the cross-OS DAC to support building in the VMR (dotnet#111927) Add Windows Server 2025 to test configurations (dotnet#111938) [PERF] Move performance testing YAML from dotnet/runtime to dotnet/performance (dotnet#111454) arm64: Add support for Bitwise OR NOT & XOR NOT (dotnet#111893) JIT: Fix cross crossgen comparison failures (dotnet#112078) Bump `StyleCop.Analyzers` to `1.2.0-beta.556` (dotnet#111278) Remove `RequiresProcessIsolation` on InterfaceFolding tests (dotnet#112098) Use hardlinks in helixpublishwitharcade (dotnet#112091) Update breaking change rules regarding byref/objref fields. (dotnet#112087) [daccess] Do not use USE_DAC_TABLE_RVA on Apple platforms (dotnet#112076) use collection syntax in illink (dotnet#108458) Include PDB for all TfmRuntimeSpecificPackageFile (dotnet#111879) [main] Update dependencies from dotnet/emsdk (dotnet#111690) Enable Mono tests (dotnet#111981) Let the debugger knows DATAS is on (dotnet#107115) Tests ran counter (dotnet#111145) Some System.Decimal performance improvements (dotnet#99212) [mono][mini] Remove support for the Xamarin.iOS and Xamarin.Mac assemblies in the AOT compiler. (dotnet#108886) Remove one usage of `Unsafe.AsPointer`. (dotnet#112079) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #111416 (as this also removes the signing steps in the cross-os DAC job so we can do everything in one invocation).
Contributes to dotnet/source-build#4631