Skip to content

Conversation

@333fred
Copy link
Member

@333fred 333fred commented Mar 11, 2025

Merge main to the feature branch

jjonescz and others added 30 commits January 28, 2025 14:08
* Parse partial events and constructors

* Update pre-existing tests

* Explain why partial ctors are sometimes disallowed

* Parse `partial` constructors unconditionally

* Gate parsing on LangVersion

* Extend tests and docs

* Fix indentation

* Rename combinatorial values

* Test more lang versions

* Parse partial events unconditionally
…ence-packages build 20250203.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.607901 -> To Version 10.0.610302
…ence-packages build 20250204.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.607901 -> To Version 10.0.610402
* Partial events and constructors: merge and check symbols

* Improve code

* Move partial availability check

* Improve code

* Fix duplicate definition diagnostic

* Test different ordering

* Avoid reporting diagnostic for escaped `partial`

* Clarify naming of AccessorsHaveImplementation property

* Add event definition accessor symbol

* Improve code

* Test sequence points

* Test extern IL

* Fix interface container diagnostics

* Fix sequence points issue in the test utility

* Ensure the new accessor owner is a definition
…ence-packages build 20250210.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.607901 -> To Version 10.0.611002
…211.5

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.XliffTasks
 From Version 9.0.0-beta.25077.4 -> To Version 9.0.0-beta.25111.5
* Partial events and constructors: check differences

* Improve code and tests

* Complete constructor implementation part

* Report error for tuple differences in constructors
…ence-packages build 20250212.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.608004 -> To Version 10.0.611203
This pull request updates the following dependencies

[marker]: <> (Begin:111cfc79-5f9f-4acd-d8a2-08dc0c5899fd)
## From https://github.com/dotnet/arcade
- **Subscription**: 111cfc79-5f9f-4acd-d8a2-08dc0c5899fd
- **Build**: 20250211.5
- **Date Produced**: February 11, 2025 11:57:34 PM UTC
- **Commit**: 5da211e1c42254cb35e7ef3d5a8428fb24853169
- **Branch**: refs/heads/release/9.0

[DependencyUpdate]: <> (Begin)

- **Updates**:
- **Microsoft.SourceBuild.Intermediate.arcade**: [from
9.0.0-beta.25077.4 to 9.0.0-beta.25111.5][1]
- **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.25077.4 to
9.0.0-beta.25111.5][1]
- **Microsoft.DotNet.Helix.Sdk**: [from 9.0.0-beta.25077.4 to
9.0.0-beta.25111.5][1]
- **Microsoft.DotNet.XliffTasks**: [from 9.0.0-beta.25077.4 to
9.0.0-beta.25111.5][1]

[1]: dotnet/arcade@bac7e1c...5da211e

[DependencyUpdate]: <> (End)

- **Updates to .NET SDKs:**
  - Updates sdk.version to 9.0.103
  - Updates tools.dotnet to 9.0.103

[marker]: <> (End:111cfc79-5f9f-4acd-d8a2-08dc0c5899fd)
…ence-packages build 20250218.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.608004 -> To Version 10.0.611801
Co-authored-by: Cyrus Najmabadi <cyrus.najmabadi@gmail.com>
…expression to an implicit object creation expression
* Partial events and constructors: attributes

* Update pre-existing tests

* Fixup expected PEVerify output

* Check a flag before materializing syntax nodes

* Assert that the definition part of an event doesn't have accessors

* Keep pre-existing event attribute target behavior

* Improve code

* Add WorkItem attribute

* Strengthen asserts

Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>

---------

Co-authored-by: Rikki Gibson <rikkigibson@gmail.com>
Etienne Baudoux and others added 12 commits March 7, 2025 15:00
…ence-packages build 20250306.1 (dotnet#77470)

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.615503 -> To Version 10.0.615601

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
# Problem

Rename flyout is being cropped on small screens. The issue being that:
1. The flyout is larger than the document's view port
2. The flyout's left position is negative (which makes it disappear to
the left).
3. Text within the flyout doesn't wrap.


![image](https://github.com/user-attachments/assets/c33a2b34-a942-409b-b87b-7016445a1df2)

# Solution

Basically, address all of the above:
1. Limit the size of the flyout to the width of the document's view
port.
2. Ensure the flyout's position is always positive.
3. Wrap text blocks.


![image](https://github.com/user-attachments/assets/d09f4013-f440-4c6d-8f2e-5d8064bc48d1)
This shouldn't be needed anymore, and prevents some design time build
breaks if NuGet restore wasn't able to get this package.

Fixes dotnet#74923
…ence-packages build 20250310.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.615601 -> To Version 10.0.616001
dotnet#77518)

This pull request updates the following dependencies

[marker]: <> (Begin:4e88e544-5668-4a45-0f48-08dc0c57b4c0)
## From https://github.com/dotnet/source-build-reference-packages
- **Subscription**: 4e88e544-5668-4a45-0f48-08dc0c57b4c0
- **Build**:
[20250310.1](https://dev.azure.com/dnceng/internal/_build/results?buildId=2659508)
- **Date Produced**: March 10, 2025 4:22:48 PM UTC
- **Commit**:
[8f9f6fa14523b2f2475ea0a86be1cf60b5de5336](dotnet/source-build-reference-packages@8f9f6fa)
- **Branch**: refs/heads/main

[DependencyUpdate]: <> (Begin)

- **Updates**:
-
**Microsoft.SourceBuild.Intermediate.source-build-reference-packages**:
[from 10.0.615601 to 10.0.616001][1]

[1]:
dotnet/source-build-reference-packages@232bcf3...8f9f6fa

[DependencyUpdate]: <> (End)


[marker]: <> (End:4e88e544-5668-4a45-0f48-08dc0c57b4c0)
* upstream/main: (134 commits)
  Mark partial events and ctors as complete (dotnet#77525)
  Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250310.1
  Remove unnecessary imports
  Update dev18 target branch (dotnet#77443)
  Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250306.1 (dotnet#77470)
  Remove BoundConversion.OriginalUserDefinedConversionsOpt property (dotnet#77465)
  Addressed feedback
  [Rename flyout] Fixed cropping issue on small screens
  Fix design time build error in Roslyn.VisualStudio.Setup
  Remove workaround of WPF bug
  Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20250305.3 (dotnet#77452)
  Small cleanup in the packages and editor factories (dotnet#77439)
  Auto merge PRs instead of just applying a label to them (dotnet#77438)
  Fix bot name (dotnet#77436)
  Add workitem
  Don't use an implicit-object if the lang version doesn't support it
  Configure main-vs-deps (dotnet#77408)
  Fix projects
  File scoped namespace
  Update formatting tests
  ...
@333fred 333fred requested review from a team as code owners March 11, 2025 18:36
@dotnet-policy-service dotnet-policy-service bot added VSCode Needs API Review Needs to be reviewed by the API review council labels Mar 11, 2025
@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 11, 2025
@dotnet-policy-service
Copy link
Contributor

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

@333fred 333fred enabled auto-merge March 11, 2025 18:52
@333fred 333fred merged commit c641c52 into dotnet:features/runtime-async Mar 11, 2025
26 of 29 checks passed
@333fred 333fred deleted the merge-main branch March 11, 2025 19:52
JoeRobich added a commit to dotnet/roslyn-tools that referenced this pull request Aug 29, 2025
46 PRs before and 36 after
```diff
+    * [Cache diagnostic analyzer computation](dotnet/roslyn#80045)
+    * [Remove parameter always passed the same value](dotnet/roslyn#80042)
     * [Update doc for IMethodSymbol.IsExtensionMethod](dotnet/roslyn#80016)
     * [Don't cache known-broken compositions](dotnet/roslyn#80021)
     * [Cleanup methods in DiagAnalyzerService](dotnet/roslyn#80013)
     * [Simplify processing of errors reported by the build](dotnet/roslyn#79964)
     * [Additional cleanup of the DiagnosticAnalyzerServier](dotnet/roslyn#80005)
     * [Fix Code Lens around source generated files](dotnet/roslyn#79992)
     * [Remove superflous DiagService api that can be achieved with existing apis](dotnet/roslyn#80007)
     * [Generate `init` accessor for required properties inside `readonly struct`s](dotnet/roslyn#80004)
     * [Remove existing low level diag oop code now that it's all handled at higher levels.](dotnet/roslyn#79994)
     * [Allow large InlineHint ArrayBuilder pooling](dotnet/roslyn#79857)
     * [Reduce allocations obtaining classified spans in ClassifierHelper](dotnet/roslyn#79856)
     * [Compute span diagnostics in oop](dotnet/roslyn#79991)
     * [Allow Razor cohosting to work with non-Razor SDK projects](dotnet/roslyn#79953)
     * [Move computation of deprioritized analyzers to oop](dotnet/roslyn#79989)
     * [EnC: Fix symbol mapping of delegates with indexed name](dotnet/roslyn#79837)
     * [Emit telemetry 'durations' with known radix point '.'](dotnet/roslyn#79988)
     * [Move logic up into DiagService](dotnet/roslyn#79985)
     * [Move the StateManager type up to the DiagnosticService from the DiagnosticIncrementalANalyzer](dotnet/roslyn#79984)
     * [Immediately remote diagnostics call to OOP](dotnet/roslyn#79983)
     * [Build Microsoft.CodeAnalysis.SemanticSearch.Extension ref assembly for use in semantic search queries](dotnet/roslyn#79972)
     * [Only cache compilation if we have the same set of analyzers](dotnet/roslyn#79978)
     * [Delete unused property](dotnet/roslyn#79963)
     * [Update 'use expr body' to be a purely syntactic analyzer](dotnet/roslyn#79979)
     * [Mark 'Use expr body' as a syntax-only fixer](dotnet/roslyn#79971)
     * [♻️ MSBuildWorkspaceDirectory - Fallback to AppContext.BaseDirectory when Assembly Location is empty](dotnet/roslyn#79934)
     * [Merge runtime async support into main](dotnet/roslyn#79833)
     * [Implement "Simplify property accessor" feature](dotnet/roslyn#79754)
-    * Merge main to runtime async branch (PR: [#79961](dotnet/roslyn#79961))
     * [Redo how and when we report source generator telemetry](dotnet/roslyn#79951)
     * [Allow MEF components to supply assembly path resolvers](dotnet/roslyn#79218)
     * [Allow Razor to hook up the source generator in misc files](dotnet/roslyn#79891)
     * [Block ENC for extension blocks](dotnet/roslyn#79883)
     * [Upgrade servicehub.client to fix test source discovery](dotnet/roslyn#79899)
     * [Update package restore error message.](dotnet/roslyn#79876)
-    * Merge main (PR: [#79834](dotnet/roslyn#79834))
-    * Merge main (PR: [#79830](dotnet/roslyn#79830))
     * [Baseline struct lifting tests](dotnet/roslyn#79505)
-    * Merge main to runtime async branch (PR: [#79582](dotnet/roslyn#79582))
-    * Merge main (PR: [#79424](dotnet/roslyn#79424))
-    * Merge main (PR: [#78994](dotnet/roslyn#78994))
-    * Merge main to runtime async branch (PR: [#78740](dotnet/roslyn#78740))
-    * Merge main to runtime async branch (PR: [#78517](dotnet/roslyn#78517))
-    * Merge main to runtime async branch (PR: [#78114](dotnet/roslyn#78114))
-    * Merge main to runtime async branch (PR: [#77700](dotnet/roslyn#77700))
-    * Merge main to runtime async branch (PR: [#77533](dotnet/roslyn#77533))
-    * Merge main to runtime async branch (PR: [#77265](dotnet/roslyn#77265))
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure Needs API Review Needs to be reviewed by the API review council untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.