Merge main to runtime async branch #77265

333fred · 2025-02-18T22:26:54Z

No description provided.

…dObjects package (dotnet#76971)

…77097) The calling MSBuild targets already specify inputs and outputs; skipping writing the output files if they're not changed prevents the output timestamp from being updated, so the builds always run (and then force a rebuild of our setup projects). Fixes dotnet#77039

…eld initializer (dotnet#76716)

…isService (dotnet#77094)

…ion>` (dotnet#77137) * Make `InterceptableLocation` implement `IEquatable<InterceptableLocation>` * Update src/Compilers/CSharp/Portable/Utilities/InterceptableLocation.cs Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> * Update src/Compilers/CSharp/Portable/Utilities/InterceptableLocation.cs Co-authored-by: Jan Jones <jan.jones.cz@gmail.com> * Record public API change --------- Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>

Once Web Tools has moved to System.Text.Json, we on Razor can move off of Visual Studio Lsp types, which resolves a licensing mismatch in the C# extension. To do this, we just need a bit more access to the Roslyn Lsp types. There was a couple of things missing, presumably added after forking, so I went ahead and added them, but only the minimum that Razor actually needs. Mikayla's PR probably already covers these too, and more obviously.

* Add missing word the documentation file A sentence in `Compiler Breaking Changes - DotNet 8.md` is because of a missing word. * Improve wording --------- Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>

* upstream/main: (576 commits) Add missing word to the documentation file (dotnet#77259) Make `InterceptableLocation` implement `IEquatable<InterceptableLocation>` (dotnet#77137) REvert REvert REvert rename Semantic document remove more inline inline Remove state type from 'move type' refactoring preserve behavior Simplify Remove dependency on semantics Simplify Simplify code Use property Properly pass progress object along in fix all provider fix syncing add background color for inline hints in high contrast mode ...

dotnet-policy-service · 2025-02-18T22:30:36Z

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

46 PRs before and 36 after ```diff + * [Cache diagnostic analyzer computation](dotnet/roslyn#80045) + * [Remove parameter always passed the same value](dotnet/roslyn#80042) * [Update doc for IMethodSymbol.IsExtensionMethod](dotnet/roslyn#80016) * [Don't cache known-broken compositions](dotnet/roslyn#80021) * [Cleanup methods in DiagAnalyzerService](dotnet/roslyn#80013) * [Simplify processing of errors reported by the build](dotnet/roslyn#79964) * [Additional cleanup of the DiagnosticAnalyzerServier](dotnet/roslyn#80005) * [Fix Code Lens around source generated files](dotnet/roslyn#79992) * [Remove superflous DiagService api that can be achieved with existing apis](dotnet/roslyn#80007) * [Generate `init` accessor for required properties inside `readonly struct`s](dotnet/roslyn#80004) * [Remove existing low level diag oop code now that it's all handled at higher levels.](dotnet/roslyn#79994) * [Allow large InlineHint ArrayBuilder pooling](dotnet/roslyn#79857) * [Reduce allocations obtaining classified spans in ClassifierHelper](dotnet/roslyn#79856) * [Compute span diagnostics in oop](dotnet/roslyn#79991) * [Allow Razor cohosting to work with non-Razor SDK projects](dotnet/roslyn#79953) * [Move computation of deprioritized analyzers to oop](dotnet/roslyn#79989) * [EnC: Fix symbol mapping of delegates with indexed name](dotnet/roslyn#79837) * [Emit telemetry 'durations' with known radix point '.'](dotnet/roslyn#79988) * [Move logic up into DiagService](dotnet/roslyn#79985) * [Move the StateManager type up to the DiagnosticService from the DiagnosticIncrementalANalyzer](dotnet/roslyn#79984) * [Immediately remote diagnostics call to OOP](dotnet/roslyn#79983) * [Build Microsoft.CodeAnalysis.SemanticSearch.Extension ref assembly for use in semantic search queries](dotnet/roslyn#79972) * [Only cache compilation if we have the same set of analyzers](dotnet/roslyn#79978) * [Delete unused property](dotnet/roslyn#79963) * [Update 'use expr body' to be a purely syntactic analyzer](dotnet/roslyn#79979) * [Mark 'Use expr body' as a syntax-only fixer](dotnet/roslyn#79971) * [♻️ MSBuildWorkspaceDirectory - Fallback to AppContext.BaseDirectory when Assembly Location is empty](dotnet/roslyn#79934) * [Merge runtime async support into main](dotnet/roslyn#79833) * [Implement "Simplify property accessor" feature](dotnet/roslyn#79754) - * Merge main to runtime async branch (PR: [#79961](dotnet/roslyn#79961)) * [Redo how and when we report source generator telemetry](dotnet/roslyn#79951) * [Allow MEF components to supply assembly path resolvers](dotnet/roslyn#79218) * [Allow Razor to hook up the source generator in misc files](dotnet/roslyn#79891) * [Block ENC for extension blocks](dotnet/roslyn#79883) * [Upgrade servicehub.client to fix test source discovery](dotnet/roslyn#79899) * [Update package restore error message.](dotnet/roslyn#79876) - * Merge main (PR: [#79834](dotnet/roslyn#79834)) - * Merge main (PR: [#79830](dotnet/roslyn#79830)) * [Baseline struct lifting tests](dotnet/roslyn#79505) - * Merge main to runtime async branch (PR: [#79582](dotnet/roslyn#79582)) - * Merge main (PR: [#79424](dotnet/roslyn#79424)) - * Merge main (PR: [#78994](dotnet/roslyn#78994)) - * Merge main to runtime async branch (PR: [#78740](dotnet/roslyn#78740)) - * Merge main to runtime async branch (PR: [#78517](dotnet/roslyn#78517)) - * Merge main to runtime async branch (PR: [#78114](dotnet/roslyn#78114)) - * Merge main to runtime async branch (PR: [#77700](dotnet/roslyn#77700)) - * Merge main to runtime async branch (PR: [#77533](dotnet/roslyn#77533)) - * Merge main to runtime async branch (PR: [#77265](dotnet/roslyn#77265)) ```

genlu and others added 30 commits February 6, 2025 17:38

Fix

b5ff756

fix

1a0521e

fix

c196fae

Update to fix the checked operator

a68f3e4

Remove unnecessary language tracking in the diagnostic service (dotne…

eeb5c70

…t#77100)

Move ArrayBuilder.GetInstance helpers to Microsoft.CodeAnalysis.Poole…

4253f32

…dObjects package (dotnet#76971)

Merge branch 'main' into inlineDiagMethods

85d5ea3

Handle nullable postcondition for non-static local function inside fi…

b2862ce

…eld initializer (dotnet#76716)

Remove arg

ff8346d

Simplify caching api between CodeAnalysisService and DiagnosticAnalys…

bd6ab1f

…isService (dotnet#77094)

Make DiagnosticIncrementalAnalyzer a nested private type (dotnet#77096)

459efff

Merge remote-tracking branch 'upstream/main' into inlineDiagMethods

fd0a9a7

Use common helper for diagnostics

9e30885

Add cache

e661250

in progress

56b5058

Merge base and parent type in diagnostic subsystem

66139ef

Merge branch 'combineDiagTypes' into diagNoMemorySave

06f237b

in progrss

f5d7181

Remove unneeded code

f4ef9a8

deletE

26cd9e5

rename

d34bbd7

Delete unused

84f284c

remove unneeded code from ProjectState

0e07eb2

Remove 'initial result' concept

61fd975

remove aggregated result concept

a23b304

Simplify

fb967b1

remove more unnecessary code

58d6940

Use cache if available

6619762

Remove project state concept

72ea224

CyrusNajmabadi and others added 12 commits February 15, 2025 14:43

inline

6042dd3

remove more

74659ba

Semantic document

46086b2

rename

cba9de6

REvert

254b024

REvert

deadb60

REvert

c127487

Remove state type from 'move type' refactoring (dotnet#77248)

d862b94

Add missing word to the documentation file (dotnet#77259)

a97fa11

* Add missing word the documentation file A sentence in `Compiler Breaking Changes - DotNet 8.md` is because of a missing word. * Improve wording --------- Co-authored-by: Jan Jones <jan.jones.cz@gmail.com>

333fred requested review from a team as code owners February 18, 2025 22:26

ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 18, 2025

dotnet-policy-service bot added VSCode Needs API Review Needs to be reviewed by the API review council labels Feb 18, 2025

JoeRobich approved these changes Feb 18, 2025

View reviewed changes

AlekseyTs approved these changes Feb 18, 2025

View reviewed changes

333fred merged commit b2779fc into dotnet:features/runtime-async Feb 19, 2025
28 checks passed

333fred deleted the merge-main branch February 19, 2025 02:18

This was referenced Aug 22, 2025

[Automated] PRs inserted in VS build main-10921.65 #80012

Closed

[Automated] PRs inserted in VS build feature.debugger.main-10921.158 #80015

Closed

davidwengier mentioned this pull request Aug 25, 2025

Allow Razor cohosting to work with non-Razor SDK projects dotnet/vscode-csharp#8559

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge main to runtime async branch #77265

Merge main to runtime async branch #77265

Uh oh!

333fred commented Feb 18, 2025 •

edited

Loading

Uh oh!

dotnet-policy-service bot commented Feb 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Merge main to runtime async branch #77265

Merge main to runtime async branch #77265

Uh oh!

Conversation

333fred commented Feb 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service bot commented Feb 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

333fred commented Feb 18, 2025 •

edited

Loading