Skip to content

Simplify processing of errors reported by the build #79964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 22, 2025
Merged

Simplify processing of errors reported by the build #79964

merged 7 commits into from
Aug 22, 2025

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Aug 19, 2025 •
edited
Loading

Have validated the build errors still report correclty (and correctly dedupe against live errors). Will do a test insertion as well.

Smoke validation was done for legacy csproj, asp web forms, and asp mvc.

Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=12227296&view=results
PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/663523

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner August 19, 2025 20:22
CyrusNajmabadi
CyrusNajmabadi commented Aug 19, 2025
View reviewed changes
src/Features/Core/Portable/Diagnostics/IDiagnosticAnalyzerService.cs Outdated
/// or an array containing both languages if the descriptor is defined for both languages.
/// </summary>
/// <param name="projectId">A project within <paramref name="solution"/> where <paramref name="analyzerReference"/> can be found</param>
Task<ImmutableDictionary<ImmutableArray<string>, ImmutableArray<DiagnosticDescriptor>>> GetLanguageKeyedDiagnosticDescriptorsAsync(
Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View with whitespacce off.

@CyrusNajmabadi
Copy link
Member Author

CyrusNajmabadi commented Aug 19, 2025

@jasonmalinowski ptal.

jasonmalinowski
jasonmalinowski approved these changes Aug 19, 2025
View reviewed changes
src/VisualStudio/Core/Def/TaskList/ProjectExternalErrorReporter.cs
language: language);
}

private static bool IsCompilerDiagnostic(string errorId)
Copy link
Member

@jasonmalinowski jasonmalinowski Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not your doing here, but it's deeply suspicious this is not using _errorCodePrefix...

@CyrusNajmabadi CyrusNajmabadi merged commit 96acf7f into dotnet:main Aug 22, 2025
24 of 25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the simplifyBuildNotifications branch August 22, 2025 04:28
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 22, 2025
@davidwengier davidwengier mentioned this pull request Aug 25, 2025
Merged
This was referenced Aug 29, 2025
Closed
Closed
JoeRobich added a commit to dotnet/roslyn-tools that referenced this pull request Aug 29, 2025
@JoeRobich
Update GitHub PR skip logic (#1501)
7053669 
46 PRs before and 36 after
```diff
+    * [Cache diagnostic analyzer computation](dotnet/roslyn#80045)
+    * [Remove parameter always passed the same value](dotnet/roslyn#80042)
     * [Update doc for IMethodSymbol.IsExtensionMethod](dotnet/roslyn#80016)
     * [Don't cache known-broken compositions](dotnet/roslyn#80021)
     * [Cleanup methods in DiagAnalyzerService](dotnet/roslyn#80013)
     * [Simplify processing of errors reported by the build](dotnet/roslyn#79964)
     * [Additional cleanup of the DiagnosticAnalyzerServier](dotnet/roslyn#80005)
     * [Fix Code Lens around source generated files](dotnet/roslyn#79992)
     * [Remove superflous DiagService api that can be achieved with existing apis](dotnet/roslyn#80007)
     * [Generate `init` accessor for required properties inside `readonly struct`s](dotnet/roslyn#80004)
     * [Remove existing low level diag oop code now that it's all handled at higher levels.](dotnet/roslyn#79994)
     * [Allow large InlineHint ArrayBuilder pooling](dotnet/roslyn#79857)
     * [Reduce allocations obtaining classified spans in ClassifierHelper](dotnet/roslyn#79856)
     * [Compute span diagnostics in oop](dotnet/roslyn#79991)
     * [Allow Razor cohosting to work with non-Razor SDK projects](dotnet/roslyn#79953)
     * [Move computation of deprioritized analyzers to oop](dotnet/roslyn#79989)
     * [EnC: Fix symbol mapping of delegates with indexed name](dotnet/roslyn#79837)
     * [Emit telemetry 'durations' with known radix point '.'](dotnet/roslyn#79988)
     * [Move logic up into DiagService](dotnet/roslyn#79985)
     * [Move the StateManager type up to the DiagnosticService from the DiagnosticIncrementalANalyzer](dotnet/roslyn#79984)
     * [Immediately remote diagnostics call to OOP](dotnet/roslyn#79983)
     * [Build Microsoft.CodeAnalysis.SemanticSearch.Extension ref assembly for use in semantic search queries](dotnet/roslyn#79972)
     * [Only cache compilation if we have the same set of analyzers](dotnet/roslyn#79978)
     * [Delete unused property](dotnet/roslyn#79963)
     * [Update 'use expr body' to be a purely syntactic analyzer](dotnet/roslyn#79979)
     * [Mark 'Use expr body' as a syntax-only fixer](dotnet/roslyn#79971)
     * [♻️ MSBuildWorkspaceDirectory - Fallback to AppContext.BaseDirectory when Assembly Location is empty](dotnet/roslyn#79934)
     * [Merge runtime async support into main](dotnet/roslyn#79833)
     * [Implement "Simplify property accessor" feature](dotnet/roslyn#79754)
-    * Merge main to runtime async branch (PR: [#79961](dotnet/roslyn#79961))
     * [Redo how and when we report source generator telemetry](dotnet/roslyn#79951)
     * [Allow MEF components to supply assembly path resolvers](dotnet/roslyn#79218)
     * [Allow Razor to hook up the source generator in misc files](dotnet/roslyn#79891)
     * [Block ENC for extension blocks](dotnet/roslyn#79883)
     * [Upgrade servicehub.client to fix test source discovery](dotnet/roslyn#79899)
     * [Update package restore error message.](dotnet/roslyn#79876)
-    * Merge main (PR: [#79834](dotnet/roslyn#79834))
-    * Merge main (PR: [#79830](dotnet/roslyn#79830))
     * [Baseline struct lifting tests](dotnet/roslyn#79505)
-    * Merge main to runtime async branch (PR: [#79582](dotnet/roslyn#79582))
-    * Merge main (PR: [#79424](dotnet/roslyn#79424))
-    * Merge main (PR: [#78994](dotnet/roslyn#78994))
-    * Merge main to runtime async branch (PR: [#78740](dotnet/roslyn#78740))
-    * Merge main to runtime async branch (PR: [#78517](dotnet/roslyn#78517))
-    * Merge main to runtime async branch (PR: [#78114](dotnet/roslyn#78114))
-    * Merge main to runtime async branch (PR: [#77700](dotnet/roslyn#77700))
-    * Merge main to runtime async branch (PR: [#77533](dotnet/roslyn#77533))
-    * Merge main to runtime async branch (PR: [#77265](dotnet/roslyn#77265))
```
This was referenced Sep 8, 2025
Closed
Closed
Closed
@akhera99 akhera99 modified the milestones: Next, 18.0 P1, 18.0 P2 Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees

No one assigned

Labels

Area-Analyzers VSCode

Projects

None yet

Milestone

18.0 P2

Development

Successfully merging this pull request may close these issues.

3 participants

@CyrusNajmabadi @jasonmalinowski @akhera99