Allow more of Razor to use Roslyn Lsp types #74597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
8 tasks
JoeRobich
approved these changes
Jul 30, 2024
davidwengier
force-pushed
the
RazorUsingMoreLspTypes
branch
from
a865562 to
4852886
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
dibarbet
approved these changes
Oct 8, 2024
Member
Author
|
Running a val build for this here: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/611598 This is source breaking, but not binary breaking, so VS still works fine (in my local testing of the install from that build) so I think we can get away without a dual insertion 🎉 |
JoeRobich
approved these changes
Feb 17, 2025
Member
Author
|
Okay, dotnet/razor#11504 will fix any source breaks this introduces, and the val build passed, so I'm merging this. |
davidwengier
added a commit
to dotnet/razor
that referenced
this pull request
Feb 18, 2025
Response to dotnet/roslyn#74597 to pave the way for #10682 once Web Tools inserts. The break from the Roslyn change is not binary breaking, so no need for dual insertion, and since this change doesn't break anything, we can get this in now, and whenever we happen to bump Roslyn next, there should be no build issues.
This was referenced Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once Web Tools has moved to System.Text.Json, we on Razor can move off of Visual Studio Lsp types, which resolves a licensing mismatch in the C# extension. To do this, we just need a bit more access to the Roslyn Lsp types.
There was a couple of things missing, presumably added after forking, so I went ahead and added them, but only the minimum that Razor actually needs. Mikayla's PR probably already covers these too, and more obviously.