Skip to content

[Rename flyout] Fixed cropping issue on small screens #77466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

[Rename flyout] Fixed cropping issue on small screens #77466

merged 2 commits into from
Mar 10, 2025

Conversation

@veler
Copy link
Contributor

@veler veler commented Mar 7, 2025

Problem

Rename flyout is being cropped on small screens. The issue being that:

  1. The flyout is larger than the document's view port
  2. The flyout's left position is negative (which makes it disappear to the left).
  3. Text within the flyout doesn't wrap.

image

Solution

Basically, address all of the above:

  1. Limit the size of the flyout to the width of the document's view port.
  2. Ensure the flyout's position is always positive.
  3. Wrap text blocks.

image

@veler veler requested a review from a team as a code owner March 7, 2025 22:45
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 7, 2025
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. Needs UX Triage labels Mar 7, 2025
@CyrusNajmabadi CyrusNajmabadi merged commit 42dd426 into dotnet:main Mar 10, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Mar 10, 2025
This was referenced Mar 11, 2025
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Mar 19, 2025
Closed
@jjonescz jjonescz modified the milestones: Next, 17.14 P3 Apr 1, 2025
@olegtk olegtk mentioned this pull request Jul 8, 2025
Merged
jasonmalinowski added a commit that referenced this pull request Jul 8, 2025
@jasonmalinowski
Fix Rename adornment positioning after scrolling (#79284)
42ba8b9 
When Rename is invoked after scrolling up, the adornment is occasionally
displayed misplaced out of viewport. See
https://developercommunity.visualstudio.com/t/Rename-dialog-opens-up-outside-of-editor/10919621.
.

This is a regression from #77466, which was a fix for horizontal
clipping but also changed vertical positioning to never be negative.
Unfortunately, when scrolling up, text view's viewport top and bottom
can be negative.
The fix is to remove unnecessary Math.Max on top position value.
@olegtk olegtk mentioned this pull request Jul 9, 2025
Merged
dibarbet added a commit that referenced this pull request Jul 9, 2025
@dibarbet
Fix Rename adornment positioning after scrolling (#79303)
6dbcfd2 
When Rename is invoked after scrolling up, the adornment is occasionally
displayed misplaced out of viewport. See
https://developercommunity.visualstudio.com/t/Rename-dialog-opens-up-outside-of-editor/10919621.


This is a regression from #77466, which was a fix for horizontal
clipping but also changed vertical positioning to never be negative.
Unfortunately, when scrolling up, text view's viewport top and bottom
can be negative.
The fix is to remove unnecessary Math.Max on top position value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

+1 more reviewer

@sandyarmstrong sandyarmstrong sandyarmstrong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. Needs UX Triage untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.14 P3

Development

Successfully merging this pull request may close these issues.

4 participants

@veler @sandyarmstrong @CyrusNajmabadi @jjonescz