Improve accessibility of notes

[joaofnfernandes]

Extends #2710 to
fix #2784

[mdlinville]

There is still nothing added to Important. The others are looking great!

[joaofnfernandes]

I don't understand the feedback. Can you detail or add a screenshot?

[mdlinville]

When I checked in /test in netlify I did not see the "Important:" on the important note. Let me double check.

[mdlinville]

https://deploy-preview-2795--docker-docs.netlify.com/test/#images

[mdlinville]

Oh I see. Is this the prefix we want to use?

[joaofnfernandes]

I'm using the warning and danger classes, since other front-end frameworks like bootstrap use classes like that with the same semantics.

[joaofnfernandes]

It the PR as is right now, you have 3 messages if you use two paragraphs in the blockquote style

[mdlinville]

Yes, I just don't like the Be careful. I do not think it aligns with admonition conventions that readers will have learned to understand, which tend to use words like Important or Caution or Info to denote severity level. I don't think we need to buck well-established trends.

[joaofnfernandes]

@mstanleyjones I know that there are a few docs out there that converged in a common terminology but I don't think they are well established trends. They are mostly conventions developed by older docsets. If you look at the new kids in the block, they have very few notes/warnings, and tend to only have a single style for them.

I'm shooting for a compromise between fun and accessibility. We're the fun side of enterprise 🐳

[joaofnfernandes]

@mstanleyjones the feedback was addressed. If you're ok merge this and label #2784 as counted.