clarified logging options in Compose, fixed glaring note formats #3272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 15, 2017 17:46
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
thaJeztah
reviewed
May 16, 2017
| > | ||
| >* Only the string form (`build: .`) is allowed - not the object | ||
| > form that is allowed in Version 2 and up. | ||
| > * Using `build` together with [`image`](#image) is not allowed. |
There was a problem hiding this comment.
The bullet aligning is a bit wonky here :D
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
|
LGTM |
added 2 commits
May 16, 2017 11:38
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging options on Compose
Notes and admonitions formats fixes
Fixed the most glaring problems with notes formats (double prefix words) in the files immediately relevant to this issue/PR as a result of the original CSS updates for admonitions (which automatically pre-pended a word to multi-line, untagged blockquote)
Added a new example to Admonitions topic in
test.mdWe should probably do a global scan of the docset to find any other admonitions which broke because of this one problem (automatically pre-pended words to multi-line, untagged blockquotes), and then further clarify note styles for all use cases, including one-liners and cases of multi note blocks that might benefit from a pre-pended word - this helps avoid stacked notes. See the Compose reference files for examples.
Direct preview links
https://deploy-preview-3272--docker-docs.netlify.com/compose/compose-file/#logging
https://deploy-preview-3272--docker-docs.netlify.com/test/#examples-with-both-prefixed-word-and-icon
https://deploy-preview-3272--docker-docs.netlify.com/compose/env-file/ (per issue #3241)
Related
#3178, #3243 (logging related)
#2795 (original admonitions formats PR)
Fixes #3241, further fixes #3178
Reviewers
@thaJeztah @tgjamin @johndmulhausen @joaofnfernandes @mstanleyjones @FredrikWendt @dnephin
Signed-off-by: Victoria Bialas victoria.bialas@docker.com