admonitions with icons and FontAwesome #3254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use these three icons for note, important, and warning: http://fontawesome.io/icon/check-circle |
added 2 commits
May 12, 2017 18:16
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Signed-off-by: Victoria Bialas <victoria.bialas@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed
Updated CSS style names for admonitions to better match content (
note,important,warning)Added Font Awesome unicode for icons to
contentelements in thevanillastyles to pull in icons ( @joaofnfernandes 's idea, worked!)Cleaned up descriptions of admonitions to demo the original styles and the new Font Awesome ones
Related
PR #3253 (Liquid variables approach with similar goals)
PR #2795 (original update to CSS for color-coded admonitions with pre-pended words)
Reviewers
@johndmulhausen @allejo @mstanleyjones @joaofnfernandes
Signed-off-by: Victoria Bialas victoria.bialas@docker.com