Skip to content

Adds style for warnings and notes #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

joaofnfernandes
Copy link
Contributor

@joaofnfernandes joaofnfernandes commented Apr 10, 2017

This PR adds a way for us to have warnings and notes.

screen shot 2017-04-11 at 14 41 23

It also maintains backwards compatibility with the older note style so that we can start migrating slowly (the first note in the screenshot).

@johndmulhausen
Copy link

johndmulhausen commented Apr 10, 2017

This is great! Can you do a yellow/gold variant for "Caution"/"Be Careful" messages?

@joaofnfernandes
Copy link
Contributor Author

I'd prefer to have just two colors, for the reasons pointed in #2563, but we can create 3 colors and. @jsouth what hex colors should we use for these banners? We need colors for:

  • info
  • caution
  • warning

Right now I'm using the colors of the bootstrap docs but I'd prefer if we had our own colors.

@joaofnfernandes joaofnfernandes changed the title [WIP] Adds style for warnings and notes Adds style for warnings and notes Apr 11, 2017
@joaofnfernandes
Copy link
Contributor Author

Now we have 3 colors. You can use regular blockquotes for the default blue, or add the class warning for yellow/brown, or danger for red.

@jsouth
Copy link
Contributor

jsouth commented Apr 12, 2017

@joaofnfernandes - I'll collect these intent colors today and post here :)

@joaofnfernandes
Copy link
Contributor Author

Merging. We can iterate the colors of a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants