-
Notifications
You must be signed in to change notification settings - Fork 4
Fix/seed deprecation and version issues #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Leaderboards destroy
Fix CORS config for Netlify
Add `badge_url` to team partial
Leaderboards index
Add PATCH to CORS methods
Added more memberships
More leaderboards
Adding Euros 2024
Update Predictions create and update actions to only allow upcoming matches
removed the filtering for global leaderboard
added a job to generate random results and then one to reset them
added copa america
added photos for all the competitions
|
👌 I suppose we can change it but we're not currently scraping at the moment.
I'm not super sure about this. I only had issues with the materialized views when i didnt have a I'm a little reluctant to change the version of Cloudinary while it's working. I did have the same issue but I ran |
d2313df to
afaf01a
Compare
|
@dmbf29 I removed the keys from that branch's history 👌 (hence the forced push above ⬆️ ) |
|
fix deprecated skip_callback syntax
add project installation details in readme
Noted, I removed the keys from the history and I will revert that commit. remove fix cloudinary version to accomodate to new v2 cloudinary lib
You are correct, a |

Changes in this PR
This PR contains multiple fix I figured while installing and seeding the app.
1. fix deprecated faker safe_email method
.safe_emailis deprecated since last year, I changed it to.email.2. fix deprecated watir browser option syntax
The error I got:
ArgumentError: {:args=>["--headless", "--no-sandbox", "--disable-dev-shm-usage", "--disable-gpu", "--remote-debugging-port=9230"]} are unrecognized arguments for Browser constructorThe syntax of WATIR seem to have changed according to this article.
3. fix deprecated skip_callback syntax⚠️ help needed
This is a band-aid not a fix. I got a
refresh_materialized_views not founderror that I shutdown with araise: falsefollowing that gh issue. I did that to move on in the seeding, we might want to keep that error raised actually. Now, the original problem is unknown to me... @trouni you might know better?4. add project installation details in readme
Added some details about running sidekiq and what the .env should look like for future new comers.
5. remove fix cloudinary version to accomodate to new v2 cloudinary lib
I removed the fixed cloudinary version as it was not accepting my
.envCLOUDINARY_URL. I think people starting their projects from today might stumble upon the same problem. I believe this gh issue talks about that same problem.