Adding Euros 2024 #115
Adding Euros 2024 #115
Conversation
|
Also, just added the API key to Heroku |
caiosantosss
left a comment
caiosantosss
left a comment
There was a problem hiding this comment.
Looks good for me.
trouni
left a comment
trouni
left a comment
There was a problem hiding this comment.
Didn't take a super deep dive, but it looks good to me!
Setup worked well on my computer as well 👍
| doug = User.find_by(email: 'douglasmberkley@gmail.com') || User.create(email: 'douglasmberkley@gmail.com', password: ENV['ADMIN_PASSWORD'], admin: true) | ||
| trouni = User.find_by(email: 'trouni@gmail.com') || User.create(email: 'trouni@gmail.com', password: ENV['ADMIN_PASSWORD'], admin: true) | ||
| james = User.find_by(email: 'devereuxjj@gmail.com') || User.create(email: 'devereuxjj@gmail.com', password: ENV['ADMIN_PASSWORD'], admin: true) | ||
| renato = User.find_by(email: 'renatonato_jr@hotmail.com') || User.create(email: 'renatonato_jr@hotmail.com', password: ENV['ADMIN_PASSWORD'], admin: true) | ||
| caio = User.find_by(email: 'caio.santos@msn.com') || User.create(email: 'caio.santos@msn.com', password: ENV['ADMIN_PASSWORD'], admin: true) |
There was a problem hiding this comment.
We probably did that before, but I guess it's not ideal to commit real emails on a public repo.
Don't think we've been using the Rails credentials for this repo, but we should probably start.
In any case, no need to fix this right away 👍
There was a problem hiding this comment.
ha yeah. i just copied what we had in the seeds but see what you mean
There was a problem hiding this comment.
we could move them to the .env file maybe
There was a problem hiding this comment.
Yeah the problem is that these are in the git commit history, so moving them to env or credentials now wouldn't fully resolve the issue. I'll create a separate issue.
Adding Euros 2024
The goal was to add both Euros and Copa America but the new Data-Football API only has the Euros.
I suggest each person create a free account so that you can get your own API Key
I created a rake task to setup the tournament
this will create the teams (with flag upload), groups, rounds, matches, leaderboards, and memberships