Update Predictions create and update actions to only allow upcoming matches #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I'm wondering if we should be validating it on the status or the actual kickoff time. Because we're reliant on the API to update the status, whereas we already know if a game as started technically. |
Collaborator
Author
|
@dmbf29 I think it would be reasonable to add a check on the time as well 👍 |
yannklein
pushed a commit
to yannklein/predictor-api
that referenced
this pull request
Jun 22, 2024
Update Predictions create and update actions to only allow upcoming matches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of this PR
This PR creates a new
editablescope for predictions and uses it in thepredictions#updateaction to prevent editing predictions on matches that are already started or finished.Didn't look into error handling, just protecting this for now as it should definitely be prevented.
Notes
We should really add RSpec 😓