Leaderboards index #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trouni
reviewed
May 25, 2021
app/models/user.rb
Outdated
Comment on lines
15
to
25
| if competition | ||
| Leaderboard.includes(:memberships).where( | ||
| competition: competition, | ||
| memberships: { user: self } | ||
| ).or(Leaderboard.where( | ||
| user: self, | ||
| competition: competition | ||
| )) | ||
| else | ||
| Leaderboard.includes(:memberships).where(memberships: { user: self }).or(Leaderboard.where(user: self)) | ||
| end |
Collaborator
There was a problem hiding this comment.
I think it could be simplified to:
leaderboards = Leaderboard.includes(:memberships).where(memberships: { user: self }).or(Leaderboard.where(user: self))
leaderboards = leaderboards.where(competition: competition) if competition
Owner
Author
There was a problem hiding this comment.
fixed. but also have to return leaderboards after if i do that.
| def index | ||
| @competition = Competition.find(params[:competition_id]) | ||
| # @leaderboards = current_user.leaderboards(@competition) | ||
| @ranking = 0 |
Owner
Author
There was a problem hiding this comment.
whoops. i was messing around and forgot to remove it.
yannklein
pushed a commit
to yannklein/predictor-api
that referenced
this pull request
Jun 22, 2024
Leaderboards index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30
This is not the ideal way to get the scores but something to start with