bottom-sheets 5.0.6 #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: updated dependencies * feat: rewrite the gesture api with gh2
* chore: updated dependencies * refactor: updated ReText view for web * chore: added cursor for handle container * chore: updated expo version for example project * feat: added scrollable component for web * feat: added gesture and scroll handler for web * chore: added getRefNativeTag for web * feat: rewrite gesture apis with gesture handler 2 (gorhom#1126) * chore: updated dependencies * feat: rewrite the gesture api with gh2 * fix(gorhom#1119): fixed race condition between onmount and keyboard animations * fix: update ref handler for web * chore: removed unused component * chore: updated expo * fix: detached example on web
* chore: updated react native to 71 * chore: updated reanimated to v3 * fix: added a fix for web initialization
* fix: react 18 types
@beqramo) * fix: keyboard on focus * fix: updated containerOffset top value to default to 0 --------- Co-authored-by: Mo Gorhom <gorhom.dev@gmail.com>
* chore: updated example to use expo and removed rn bare project * chore: updated expo v50 * chore: updated map example * chore: updated view pager example * chore: updated react navigation example * chore: updated native screens example * chore: updated dependencies
) * Added accessibility to the bottomSheet component * Accessibility changes - BottomSheetBackdrop * Accessibility changes - BottomSheetHandle * Minor adjustments after review * removed unused spread operator * fix: removed change announcement removed the change announcement part of the code, and the ..rest from the two mentioned files.
This style was originally added to address some lingering-sheet behavior, however, it seems that it also causes some kind of race condition or Reanimated bug. The presence of this opacity rule can cause the container to disappear on occasion. Others independently discovered the same problem here: gorhom#719 (comment) Since we can't seem to trigger the original problematic behavior, we are reverting this opacity rule.
…n a BottomSheet scrollable using preserveScrollMomentum
* chore: update reanimated and typescript deps * chore: misc other type updates
…lable is locked (#14)
ghost
changed the title
ghost
marked this pull request as ready for review
ghost
force-pushed
the
discord-fork-5.0.6
branch
from
e561b90 to
76c0fb4
Compare
ghost
force-pushed
the
discord-fork-5.0.6
branch
from
76c0fb4 to
bef45c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
39 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all of discords custom changes, for v4 these were:
gorhom/react-native-bottom-sheet@v4.6.1...discord:react-native-bottom-sheet:discord-fork-4.6.1
Discord App PR is over here:
Needs more testing and eventual adjustments