Skip to content

Add lockableScrollableContentOffsetY which does not change when scrollable is locked #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add lockableScrollableContentOffsetY which does not change when scrollable is locked #14

merged 1 commit into from
Dec 13, 2023
+14 −0

Conversation

@lsdimagine
Copy link
Collaborator

@lsdimagine lsdimagine commented Dec 12, 2023

Please provide enough information so that others can review your pull request:

Motivation

When scrollable is locked, we have no way to know the lock position as BottomSheet doesn't expose that value. This PR adds a new internal state lockableScrollableContentOffsetY:

  1. When scrollable is locked, it will be the value of lock position.
  2. When scrollable is not locked, it will be same as scrollable content offset.

@lsdimagine lsdimagine merged commit 859ab16 into discord-fork-4.5.1 Dec 13, 2023
lsdimagine added a commit that referenced this pull request Dec 13, 2023
@lsdimagine
Revert "Add lockableScrollableContentOffsetY which does not change wh…
d3651f7 
…en scrollable is locked (#14)"

This reverts commit 859ab16.
lsdimagine added a commit that referenced this pull request Dec 13, 2023
@lsdimagine
Move lockableScrollableContentOffsetY into scrollable props (#15)
7698f88 
* Revert "Add lockableScrollableContentOffsetY which does not change when scrollable is locked (#14)"

This reverts commit 859ab16.

* Move lockableScrollableContentOffsetY into scrollable props
@yayvery yayvery deleted the lsdimagine/add_lockable_content_offset branch February 24, 2024 19:14
yayvery pushed a commit that referenced this pull request Feb 24, 2024
@lsdimagine @yayvery
Add lockableScrollableContentOffsetY which does not change when scrol…
31b533d 
…lable is locked (#14)
yayvery pushed a commit that referenced this pull request Feb 24, 2024
@lsdimagine @yayvery
Move lockableScrollableContentOffsetY into scrollable props (#15)
c2ee40f 
* Revert "Add lockableScrollableContentOffsetY which does not change when scrollable is locked (#14)"

This reverts commit 859ab16.

* Move lockableScrollableContentOffsetY into scrollable props
yayvery pushed a commit that referenced this pull request Mar 13, 2024
@lsdimagine @yayvery
Add lockableScrollableContentOffsetY which does not change when scrol…
9a953d1 
…lable is locked (#14)
ghost pushed a commit that referenced this pull request Jan 7, 2025
@lsdimagine @hannojg
Add lockableScrollableContentOffsetY which does not change when scrol…
1c313fe 
…lable is locked (#14)
ghost pushed a commit that referenced this pull request Jan 7, 2025
@lsdimagine @hannojg
Move lockableScrollableContentOffsetY into scrollable props (#15)
4e2a111 
* Revert "Add lockableScrollableContentOffsetY which does not change when scrollable is locked (#14)"

This reverts commit 859ab16.

* Move lockableScrollableContentOffsetY into scrollable props
ghost pushed a commit that referenced this pull request Jun 11, 2025
@lsdimagine @hannojg
Add lockableScrollableContentOffsetY which does not change when scrol…
d5cde45 
…lable is locked (#14)
ghost pushed a commit that referenced this pull request Jun 11, 2025
@hannojg
Move lockableScrollableContentOffsetY into scrollable props (#15)
e424191 
* Revert "Add lockableScrollableContentOffsetY which does not change when scrollable is locked (#14)"

This reverts commit 859ab16.

* Move lockableScrollableContentOffsetY into scrollable props
ghost pushed a commit that referenced this pull request Jun 11, 2025
@hannojg
Move lockableScrollableContentOffsetY into scrollable props (#15)
1902dc4 
* Revert "Add lockableScrollableContentOffsetY which does not change when scrollable is locked (#14)"

This reverts commit 859ab16.

* Move lockableScrollableContentOffsetY into scrollable props
@lmle lmle mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huderlem huderlem Awaiting requested review from huderlem

1 more reviewer

@yayvery yayvery yayvery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lsdimagine @yayvery