fix(BottomSheetScrollView): Scroll responder types use mixin #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
Author
|
bump |
gorhom
added a commit
that referenced
this pull request
Apr 30, 2023
…)(by @eps1lon) * fix(BottomSheetScrollView): Scroll responder types use mixin * chore: removed unused import --------- Co-authored-by: gorhom <gorhom.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The scroll responders were typed as
ReactNodewhich only were usable becauseReactNodeincludes{}i.e. any non-nullish value. From React 18 going forward this is no longer the case so the types became unusable.I'm not sure if it actually returned a
ScrollResponderMixinin 0.62. Earliest (similar) usage ofgetScrollResponder: () => ScrollResponderMixinwas in 0.63.