feat: added default dynamic sizing (#1513)(with @Eli-Nathan & @ororsatti) #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yayvery
added a commit
to discord/react-native-bottom-sheet
that referenced
this pull request
Mar 14, 2024
…lt dynamic sizing not sure why provided content + handle height was removed in gorhom#1683, it significantly increases the mount cost because it now requires a full off-screen render pass of the content and handle components before the sheet can be displayed
yayvery
added a commit
to discord/react-native-bottom-sheet
that referenced
this pull request
Mar 14, 2024
…lt dynamic sizing not sure why provided content + handle height was removed in gorhom#1683, it significantly increases the mount cost because it now requires a full off-screen render pass of the content and handle components before the sheet can be displayed
yayvery
added a commit
to discord/react-native-bottom-sheet
that referenced
this pull request
Mar 14, 2024
…lt dynamic sizing not sure why provided content + handle height was removed in gorhom#1683, it significantly increases the mount cost because it now requires a full off-screen render pass of the content and handle components before the sheet can be displayed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #658, closes #32, closes #1363
Motivation
This PR is a replacement for #1510 by @Eli-Nathan & #1402 by @ororsatti, where the implementation been shifted into the core library allowing the removal of the
useBottomSheetDynamicSnapPointshook.Users will be able to enable dynamic sizing by default. And enable setting a limit for content height by providing a max value with
maxDynamicContentSize.Testing