fix(handlers_test.go): add unit tests for handlers by arschles · Pull Request #5 · deis/workflow-manager-api

arschles · 2016-03-18T22:12:15Z

This is a work in progress. It currently doesn't even compile...
Ref #3

so it can be used more effectively in tests

also, fill in tests for other endpoints (the tests are still TODO)

also remove the fake cluster, count and version implementations in favor of marshaling/unmarshmaling them to the in-memory DB

it will be written higher on the stack in server_test.go

… a DB it will be called in tests & the server, each with a different underlying database

arschles · 2016-03-21T20:27:37Z

At current, existing tests are compiling and running against an in-memory SQLite DB (using this driver). Currently, the below test failure is occurring:

ENG000656:workflow-manager-api aaronschlesinger$ go test -test.v .
=== RUN   TestGetVersions
--- SKIP: TestGetVersions (0.00s)
    server_test.go:29: TODO
=== RUN   TestPostVersions
--- SKIP: TestPostVersions (0.00s)
    server_test.go:34: TODO
=== RUN   TestGetClusters
2016/03/21 13:15:53 counted 0 records for versions table
2016/03/21 13:15:53 counted 0 records for clusters table
2016/03/21 13:15:53 counted 0 records for clusters_checkins table
--- PASS: TestGetClusters (0.00s)
=== RUN   TestGetClusterByID
--- SKIP: TestGetClusterByID (0.00s)
    server_test.go:59: TODO
=== RUN   TestPostClusters
2016/03/21 13:15:53 counted 0 records for versions table
2016/03/21 13:15:53 counted 0 records for clusters table
2016/03/21 13:15:53 counted 0 records for clusters_checkins table
2016/03/21 13:15:54 sql: Scan error on column index 1: unsupported driver -> Scan pair: []uint8 -> *time.Time
--- FAIL: TestPostClusters (0.00s)
    server_test.go:80: Received non-200 response: 500
FAIL
exit status 1
FAIL    github.com/deis/workflow-manager-api    0.023s

I believe that the error is related to mattn/go-sqlite3#190. I'm working on a fix.

it acts as a sql.Scanner and driver.Valuer implementation, to be used instead of time.Time in the DB

also, used a json Decoder instead of reading all bytes before decoding

jackfrancis · 2016-03-21T22:18:44Z

looks great

arschles · 2016-03-21T22:21:09Z

restarted travis, tests failed on fetching deps.....

mboersma · 2016-03-21T22:22:24Z

  - spew
 - name: github.com/deis/workflow-manager
  version: b37815165204e8a899ece414286fd8e7aba9f6f1
+  repo: git@github.com:deis/workflow-manager


In order to placate glide in #8, I had to remove the two lines that you've added here. Might be voodoo, but I see that Travis agrees with me...

Can confirm voodoo.

oof, ok thanks. I'll remove

fixed in c9f8f75

@mboersma

@mboersma says this makes travis happy as well

the vcs entry also makes it barf

arschles · 2016-03-21T22:43:25Z

latest travis failure found this: data/mem_db.go:7:2: C source files not allowed when not using cgo or SWIG: sqlite3.c, which will make it problematic to use sqlite for testing. I'll be looking for an alternative (it'll likely need to be pure Go)

since it can’t be built into the production binary (which turns off cgo, but cgo is required by sqlite), it has to be in a test file

arschles · 2016-03-21T23:03:41Z

@mboersma @jackfrancis I fixed the CGO issue in c9b0b3b (for now - I suspect we'll have to revisit this in the future).

arschles · 2016-03-21T23:15:53Z

@mboersma can I get a final review when you get a chance?

fix(handlers_test.go): add unit tests for handlers

arschles added enhancement in progress labels Mar 18, 2016

arschles self-assigned this Mar 18, 2016

arschles added this to the v2.0-beta1 milestone Mar 18, 2016

arschles added the showstopper label Mar 21, 2016

arschles mentioned this pull request Mar 21, 2016

fix(data): replace non-existent ParseJSONComponent func with internal implementation #10

Merged

Aaron Schlesinger added 6 commits March 21, 2016 10:48

fix(handlers_test.go): begin adding unit tests for handlers

738f96a

feat(tests): add fakes for DB and Count

702880c

fix(glide): add asserts library and sqlite3 lib

313c8c5

feat(handlers_test.go): add preliminary test for ClustersHandler

d63af6b

fix(handlers_test.go): add comma to fix compile err

7009144

fix(mem_db.go): open sqlite3 DB the canonical way

c0cfbcf

arschles force-pushed the unit-tests branch from 3b2cb2d to c0cfbcf Compare March 21, 2016 17:49

Aaron Schlesinger added 13 commits March 21, 2016 11:12

fix(handlers/handlers_test.go): add necessary imports

5aa7633

fix(handlers/handlers_test.go): fix compile err

450f417

doc(data/mem_db.go): add godoc for in-memory DB

ef2e316

fix(tests): make server tests compile

634b86d

fix(handlers/handlers_test.go): remove unused var

1e9cc5f

ref(server.go): parameterize the getRoutes func

d251afd

so it can be used more effectively in tests

ref(server_test.go): take advantage of new getRoutes func

fb09699

also, fill in tests for other endpoints (the tests are still TODO)

fix(server_test.go): get more tests passing

2c2a89b

also remove the fake cluster, count and version implementations in favor of marshaling/unmarshmaling them to the in-memory DB

fix(data/data.go): print error on creating checking record

8c77890

fix(handler_test.go): remove handlers test

9272ccc

it will be written higher on the stack in server_test.go

fix(data,server.go,server_test.go): make VerifyPersistentStorage take…

37f2093

… a DB it will be called in tests & the server, each with a different underlying database

fix(server_test.go): print more error details

423a36e

fix(handlers/handlers.go): add better internal logging

7684881

Aaron Schlesinger added 3 commits March 21, 2016 14:12

fix(data): add timestamp type

adc114b

it acts as a sql.Scanner and driver.Valuer implementation, to be used instead of time.Time in the DB

fix(server_test.go): add one more check to the post test

b314f87

also, used a json Decoder instead of reading all bytes before decoding

fix(data/timestamp.go): remove errant logging

2a52886

Aaron Schlesinger added 3 commits March 21, 2016 14:34

fix(data/timestamp.go): remove unused import

e7d50e0

fix(data/timestamp_test.go): add tests for Timestamp

e378605

fix(data/timestamp.go): return known error on invalid type

391a86d

arschles added awaiting review and removed in progress labels Mar 21, 2016

doc(data/timestamp_test.go): clarify comment

c0b76d2

jackfrancis added the LGTM1 label Mar 21, 2016

mboersma reviewed Mar 21, 2016
View reviewed changes

Aaron Schlesinger added 2 commits March 21, 2016 15:23

fix(glide.yaml): placate glide

c9f8f75

@mboersma says this makes travis happy as well

fix(glide): make glide happy, again

f8bef7b

the vcs entry also makes it barf

Aaron Schlesinger added 2 commits March 21, 2016 15:55

fix(data/data.go): split long line into multiple

8222183

fix(db): move the sqlite code into a test file

c9b0b3b

since it can’t be built into the production binary (which turns off cgo, but cgo is required by sqlite), it has to be in a test file

mboersma added LGTM2 and removed awaiting review labels Mar 22, 2016

arschles added a commit that referenced this pull request Mar 22, 2016

Merge pull request #5 from arschles/unit-tests

bfa7016

fix(handlers_test.go): add unit tests for handlers

arschles merged commit bfa7016 into deis:master Mar 22, 2016

arschles deleted the unit-tests branch March 22, 2016 16:26

arschles mentioned this pull request Mar 23, 2016

Unit tests #3

Closed

Navigation Menu

fix(handlers_test.go): add unit tests for handlers - #5

fix(handlers_test.go): add unit tests for handlers#5
arschles merged 30 commits into
deis:masterfrom
arschles:unit-tests

arschles commented Mar 18, 2016

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

jackfrancis commented Mar 21, 2016

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

mboersma Mar 21, 2016

Uh oh!

jackfrancis Mar 21, 2016

Uh oh!

arschles Mar 21, 2016

Uh oh!

arschles Mar 21, 2016

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

arschles commented Mar 18, 2016

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

jackfrancis commented Mar 21, 2016

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

mboersma Mar 21, 2016

Choose a reason for hiding this comment

Uh oh!

jackfrancis Mar 21, 2016

Choose a reason for hiding this comment

Uh oh!

arschles Mar 21, 2016

Choose a reason for hiding this comment

Uh oh!

arschles Mar 21, 2016

Choose a reason for hiding this comment

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

arschles commented Mar 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants