Skip to content

ref(*): add Makefile and Dockerfile #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2016

Conversation

mboersma
Copy link
Member

Although this isn't (yet) an open-source component, it still benefits from the prototype-repo style of development. This PR also adds a local implementation of ParseJSONComponent() in order to allow compiilation, and updates glide-vendored dependencies. With this PR, I can build a Docker image and run the server inside it:

$ make build docker-build
$ docker run 192.168.64.2:5000/deis/workflow-manager-api:git-807bfbd
2016/03/20 19:42:01 couldn't get a db connection
2016/03/20 19:42:01 unable to verify persistent storage

@mboersma mboersma self-assigned this Mar 20, 2016
@mboersma mboersma added this to the v2.0-beta1 milestone Mar 20, 2016
@jackfrancis
Copy link
Member

@arschles can you provide insight into why references to components.ParseJSONComponent were preventing local compilation?

@arschles
Copy link
Member

@jackfrancis I can't. FWIW the same compilation errors occur on master:

ENG000656:workflow-manager-api aaronschlesinger$ go build
# github.com/deis/workflow-manager-api/data
data/data.go:178: undefined: components.ParseJSONComponent

@jackfrancis
Copy link
Member

blech. Well, it's a simple helper function, so there's nothing out of bounds per-se in providing it to the data package locally; I just don't like not knowing what's going on is the thing. 🎱

@arschles
Copy link
Member

@jackfrancis I'll fix it and open a new PR

Related: #9 will help surface these kinds of issues, and I believe is important for beta

@mboersma
Copy link
Member Author

I can drop the ParseJSONComponent() commit if you think the Makefile / Dockerfile changes are useful on their own.

@arschles arschles added the LGTM1 label Mar 21, 2016
mboersma added a commit that referenced this pull request Mar 21, 2016
ref(*): add Makefile and Dockerfile
@mboersma mboersma merged commit 03577f3 into deis:master Mar 21, 2016
@mboersma mboersma deleted the prototype-repo branch March 21, 2016 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants