fix(mem_db.go): open sqlite3 DB the canonical way

Aaron Schlesinger · Aaron Schlesinger · commit 3b2cb2d4fe2b · 2016-03-18T15:50:15.000-07:00
diff --git a/data/mem_db.go b/data/mem_db.go
@@ -3,11 +3,12 @@ package data
 import (
 	"database/sql"
 
-	"github.com/mxk/go-sqlite/sqlite3"
+	_ "github.com/mxk/go-sqlite/sqlite3"
 )
 
 const (
-	memStr = ":memory:"
+	sqlite3Str = "sqlite3"
+	memStr     = ":memory:"
 )
 
 type memDB struct {
@@ -18,10 +19,10 @@ func (m memDB) Get() (*sql.DB, error) {
 	return m.db, nil
 }
 
-func NewMemDB() (*sql.DB, error) {
-	db, err := sqlite3.Open(memStr)
+func NewMemDB() (DB, error) {
+	db, err := sql.Open(sqlite3Str, memStr)
 	if err != nil {
 		return nil, err
 	}
-	return &memDB{db:db}, nil
+	return &memDB{db: db}, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -3,11 +3,12 @@ package data`
`3`	`3`	`import (`
`4`	`4`	`"database/sql"`
`5`	`5`
`6`		`- "github.com/mxk/go-sqlite/sqlite3"`
	`6`	`+ _ "github.com/mxk/go-sqlite/sqlite3"`
`7`	`7`	`)`
`8`	`8`
`9`	`9`	`const (`
`10`		`- memStr = ":memory:"`
	`10`	`+ sqlite3Str = "sqlite3"`
	`11`	`+ memStr = ":memory:"`
`11`	`12`	`)`
`12`	`13`
`13`	`14`	`type memDB struct {`
`@@ -18,10 +19,10 @@ func (m memDB) Get() (*sql.DB, error) {`
`18`	`19`	`return m.db, nil`
`19`	`20`	`}`
`20`	`21`
`21`		`-func NewMemDB() (*sql.DB, error) {`
`22`		`- db, err := sqlite3.Open(memStr)`
	`22`	`+func NewMemDB() (DB, error) {`
	`23`	`+ db, err := sql.Open(sqlite3Str, memStr)`
`23`	`24`	`if err != nil {`
`24`	`25`	`return nil, err`
`25`	`26`	`}`
`26`		`- return &memDB{db:db}, nil`
	`27`	`+ return &memDB{db: db}, nil`
`27`	`28`	`}`