Skip to content

fix(data): replace non-existent ParseJSONComponent func with internal implementation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2016

Conversation

arschles
Copy link
Member

this fixes the build

@arschles arschles self-assigned this Mar 21, 2016
@arschles arschles added this to the v2.0-beta1 milestone Mar 21, 2016
@arschles arschles changed the title fix(data): replace non-existent ParseJSONComponent func fix(data): replace non-existent ParseJSONComponent func with internal implementation Mar 21, 2016
@mboersma
Copy link
Member

I still get errors running the tests, but things compile now. I guess this is to be expected:

$ make test
docker run --rm -e GO15VENDOREXPERIMENT=1 -v /Users/matt/Projects/src/github.com/deis/workflow-manager-api:/go/src/github.com/deis/workflow-manager-api -w /go/src/github.com/deis/workflow-manager-api quay.io/deis/go-dev:0.9.1 sh -c 'go test $(glide nv)'
ok      github.com/deis/workflow-manager-api/data   0.014s
?       github.com/deis/workflow-manager-api/handlers   [no test files]
# github.com/deis/workflow-manager-api
./server_test.go:19: undefined: defaultHandler
./server_test.go:20: undefined: versionsHandler
./server_test.go:21: undefined: versionsPostHandler
./server_test.go:22: undefined: clustersPostHandler
FAIL    github.com/deis/workflow-manager-api [build failed]
make: *** [test] Error 2

@arschles
Copy link
Member Author

@mboersma thanks. I'll fix tests up in #5

arschles added a commit that referenced this pull request Mar 21, 2016
fix(data): replace non-existent ParseJSONComponent func with internal implementation
@arschles arschles merged commit eba71fb into deis:master Mar 21, 2016
@arschles arschles deleted the fix-compile branch March 21, 2016 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants