clang does not support -rpath-link #19137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
This was referenced Aug 10, 2023
Closed
This comment has been minimized.
This comment has been minimized.
jwillikers
suggested changes
Aug 10, 2023
| @@ -737,7 +740,7 @@ def build(self): | |||
|
|
|||
| libdirs = [l for dependency in self.dependencies.host.values() for l in dependency.cpp_info.aggregated_components().libdirs] | |||
| args.append("QMAKE_LIBDIR+=\"%s\"" % " ".join(libdirs)) | |||
| if not is_msvc(self): | |||
| if not is_msvc(self) and not self._is_clang(): | |||
There was a problem hiding this comment.
Is this a problem on newer versions of Clang or only on version 13? If it's only an issue for 13, I think we should only do this for that version of Clang. I think we want to keep RPATH enabled otherwise.
There was a problem hiding this comment.
well, I cannot really tell, I can confirm that the issue exist for clang 13 and 14 on Macos m1
There was a problem hiding this comment.
I beleive this is an issue with the linker and not the compiler. The linker in Apple platforms doesn't have -rpath-link, but on Linux (even with Clang), this should work.
Perhaps this conditional can be changed to if not is_msvc(self) and not is_apple_os(self): - or something along those lines.
There was a problem hiding this comment.
probably if not is_msvc(self) and not (is_apple_os(self) and self._is_clang()) : is more accurate, assuming -rpath-link is available for gcc on macos
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit 8ffe516qt/5.15.10qt/5.15.8qt/5.15.9qt/5.15.7 |
ghost
mentioned this pull request
3 tasks
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ghost
mentioned this pull request
3 tasks
ghost
mentioned this pull request
3 tasks
This was referenced Nov 7, 2023
ghost
mentioned this pull request
4 tasks
ghost
mentioned this pull request
3 tasks
ghost
mentioned this pull request
3 tasks
This was referenced Mar 18, 2024
ghost
mentioned this pull request
This was referenced Apr 13, 2024
This was referenced May 5, 2024
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'm investigating this issue and I'm a bit puzzled as to why it happens in the first place.
https://github.com/qt/qtbase/blob/v5.15.14-lts-lgpl/qmake/generators/unix/unixmake.cpp#L149-L155 From the above, the
The mkspec for macos is The looking at the I'm building this locally (takes a while), but will double check. Perhaps since this is qtwebengine we're talking about, there's additional logic somewhere. Update: indeed this the case, this line: is causing the issue. I'll issue a patch. This was confusing because technically - if |
|
Fixed in #24826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: qt/5.15
Compaling qt with qtwebengine enabled on m1 mac with clang 13 I got an error
it seems like Clang does not support
-rpath-linkThis is the same issue as #16639