-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt5: fix webengine build issues #24826
Merged
conan-center-bot
merged 10 commits into
conan-io:master
from
jcar87:lcc/bugfixes/qt5-webengine
Aug 6, 2024
Merged
qt5: fix webengine build issues #24826
conan-center-bot
merged 10 commits into
conan-io:master
from
jcar87:lcc/bugfixes/qt5-webengine
Aug 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
Hooks produced the following warnings for commit 7499ebeqt/5.15.14@#8588c2b06d465f08c7ece494d1bd7f51
|
AbrilRBS
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @jcar87 :)
franramirez688
approved these changes
Aug 6, 2024
uilianries
approved these changes
Aug 6, 2024
This was referenced Aug 6, 2024
uilianries
pushed a commit
to uilianries/conan-center-index
that referenced
this pull request
Aug 7, 2024
* qt5 webengine fixes * wip * fix * wip * wip * patch for QTBUG-117073 QtWebEngine build error for msvc 2022 * wip * Fix assembly error in qt5 webengine module with binutils >= 2.41 * wip * wip --------- Co-authored-by: Walid Boussafa <boussaffa.walid@outlook.com> Co-authored-by: Winfried Dobbe <winfried_mb2@xmsnet.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: qt/5.15.14
Motivation
Fix several issues building QtWebEngine on newer platforms
Details
Several bugfixes
macOS: fix compiler error for missing unary_function
Fix following compiler error, which happens when using XCode 14.3 or newer and c++17
Fixed by defining
_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION
as per Xcode release notesmacOS: fix errors due multiple template instantiations
The fix for https://bugreports.qt.io/browse/QTBUG-98813, which is part of 5.15.14, causes issues in newer versions of Xcode (12.3 or higher)/
A root cause analysis in https://stackoverflow.com/questions/69520633/undefined-symbols-of-shrink-to-fit-when-compiling-cronet-on-ios-15-with-xcod/70339311#70339311 suggests that the best fix is to remove the template instantiation and fix the issue in libc++.
The libc++ fix https://reviews.llvm.org/D115656 (inlining
shrink_to_fit()
) has made its way to newer versions of Xcode, which now cause errors. Fixed by "undoing" this fix in newer versions of the SDK by checking the__MAC_OS_X_VERSION_MAX_ALLOWED
macro (which should correlate with the version of the SDK the compiler is seeing).macOS: fix error no member named move in namespace std
Fix for the following compiler error:Close: #19141
macOS: prevent -rpath-link from being passed when building QtWebEngine
Fix issue where
-rpath-link
is passed when building QtWebEngine. As per qmake defaults,-rpath-link
should not be used when building on macOS.Close: #16639
Close: #19137
Qt Webengine spellcheck_buildflags.h not found on macOS
Backport fix for https://bugreports.qt.io/browse/QTBUG-124375msvc: fix compiler errors with Visual Studio 2022
Backport fix for https://bugreports.qt.io/browse/QTBUG-117073when using newer msvc toolchains
(cherry-picked from #24009)
Fix assembly error in qt5 webengine module with binutils >= 2.41
Backport https://bugreports.qt.io/browse/QTBUG-116649, which was also added to the chromium 87 branch which is used by Qt 5.15.x
cherry-picked from: #21026
Close: #21026
Tested locally:
Linux requires more fixes for Conan 2, but should work in Conan 1.x.