Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assembly error in qt5 webengine module with binutils >= 2.41 #21026

Closed

Conversation

wdobbe
Copy link
Contributor

@wdobbe wdobbe commented Nov 9, 2023

Specify library name and version: qt/5.15.11

The build of the qt5 qtwebengine module fails during the compilation of ffmpeg that comes with the chromium engine:
3rdparty/chromium/third_party/ffmpeg/libavcodec/x86/mathops.h:125: Error: operand type mismatch for shr'`

In qt6 this has been fixed upstream (see https://bugreports.qt.io/browse/QTBUG-116649).
Add this patch also to qt5.

Patch tested with Conan 2.0.13 on Linux x86_64.


Copy link
Contributor

github-actions bot commented Nov 9, 2023

🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'.

👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉

Copy link
Contributor

@jwillikers jwillikers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

recipes/qt/5.x.x/conandata.yml Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 92cd216
qt/5.15.11@#5590885b2bb50967c121d08d02582f88
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core_debug.5.15.dylib' links to system library 'DiskArbitration' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core_debug.dylib' links to system library 'DiskArbitration' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core_debug.5.15.11.dylib' links to system library 'DiskArbitration' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core_debug.5.dylib' links to system library 'DiskArbitration' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core_debug.5.15.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Test_debug.5.15.11.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport_debug.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport_debug.5.15.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core_debug.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Test_debug.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core_debug.5.15.11.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport_debug.5.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core_debug.5.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Test_debug.5.15.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Test_debug.5.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport_debug.5.15.11.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqminimal_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqoffscreen_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/printsupport/libcocoaprintersupport_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/styles/libqmacstyle_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/imageformats/libqico_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/imageformats/libqgif_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/imageformats/libqjpeg_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/generic/libqtuiotouchplugin_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Widgets_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5OpenGL_debug.5.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Gui_debug.5.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5OpenGL_debug.5.15.11.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5OpenGL_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Gui_debug.5.15.11.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport_debug.5.15.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Gui_debug.5.15.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Widgets_debug.5.15.11.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5OpenGL_debug.5.15.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Gui_debug.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport_debug.5.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport_debug.5.15.11.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Widgets_debug.5.15.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Widgets_debug.5.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Network_debug.5.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Network_debug.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Network_debug.5.15.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Network_debug.5.15.11.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport.5.15.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport.5.15.11.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core.5.15.11.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Test.5.15.11.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Test.5.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core.5.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport.5.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core.5.15.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Test.5.15.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Test.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqoffscreen.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqminimal.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/printsupport/libcocoaprintersupport.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/styles/libqmacstyle.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/imageformats/libqgif.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/imageformats/libqico.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/imageformats/libqjpeg.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './bin/archdatadir/plugins/generic/libqtuiotouchplugin.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Widgets.5.15.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport.5.15.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport.5.15.11.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Widgets.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Gui.5.15.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5PrintSupport.5.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Widgets.5.15.11.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Gui.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5OpenGL.5.15.11.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Gui.5.15.11.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Widgets.5.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5OpenGL.5.15.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5OpenGL.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Gui.5.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5OpenGL.5.dylib' links to system library 'AGL' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Network.5.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Network.5.15.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Network.5.15.11.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Network.dylib' links to system library 'CFNetwork' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core.5.15.11.dylib' links to system library 'DiskArbitration' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core.5.dylib' links to system library 'DiskArbitration' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core.dylib' links to system library 'DiskArbitration' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libQt5Core.5.15.dylib' links to system library 'DiskArbitration' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\libGLESv2.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\libGLESv2d.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Guid.dll' links to system library 'd3d11' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\archdatadir\plugins\platforms\qdirect2dd.dll' links to system library 'd3d11' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\archdatadir\plugins\sqldrivers\qsqlodbcd.dll' links to system library 'odbc32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Guid.dll' links to system library 'dxgi' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\archdatadir\plugins\platforms\qdirect2dd.dll' links to system library 'dwrite' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Cored.dll' links to system library 'mpr' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\archdatadir\plugins\platforms\qdirect2dd.dll' links to system library 'd2d1' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\archdatadir\plugins\platforms\qdirect2d.dll' links to system library 'd2d1' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\archdatadir\plugins\platforms\qdirect2d.dll' links to system library 'dwrite' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Core.dll' links to system library 'mpr' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Gui.dll' links to system library 'd3d11' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\archdatadir\plugins\platforms\qdirect2d.dll' links to system library 'd3d11' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\archdatadir\plugins\sqldrivers\qsqlodbc.dll' links to system library 'odbc32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt5Gui.dll' links to system library 'dxgi' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Nov 21, 2023
@ghost ghost mentioned this pull request Nov 25, 2023
3 tasks
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution and patience :)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for a sec until I check one last thing, sorry about the noise!

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question:

  • Why is it not applied to all 5.x versions?
  • Can the base_path be changed so that the patch itself can be the same used in upstream?

@wdobbe
Copy link
Contributor Author

wdobbe commented Nov 30, 2023

* Why is it not applied to all 5.x versions?

Because I have no time to check the patch with all older qt5 versions, qtwebengine takes forever to build.
CCI builds also don't build the qtwebengine module, I suppose for the same reason (build resources). So I didn't want to add a patch without knowing if it will apply correctly.
Qt5 has been end-of-life for some years and the opensource version is not maintained anymore by the Qt Company. KDE took over maintenance but they also maintain only qt 5.15.

* Can the base_path be changed so that the patch itself can be the same used in upstream?

Yes. The patch I added was taken from the Debian Qt package. I will change it then to the original ffmpeg patch even though I don't see the benefit.

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2023

CLA assistant check
All committers have signed the CLA.

@wdobbe wdobbe force-pushed the qt5_fix_webengine_build_err_binutils_2_41 branch from 233d380 to d06ef6c Compare November 30, 2023 15:09
@wdobbe
Copy link
Contributor Author

wdobbe commented Nov 30, 2023

Sorry, I noticed that the Conan Qt recipe also maintains only 5.15 so I added the patch to all 5.15.x patch releases even though I tested it only for 5.15.11.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center and removed Service Under Maintenance labels Dec 3, 2023
@conan-center-bot

This comment has been minimized.

@wdobbe wdobbe force-pushed the qt5_fix_webengine_build_err_binutils_2_41 branch from d5016bb to a27843e Compare December 5, 2023 14:21
@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Dec 5, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 13 (f79692a5aad5b17f8cc6a5af6850fa97bc942fcc):

  • qt/5.15.11:
    CI failed to create some packages (All logs)

    Logs for packageID 52cdc3d356cac053d77414153d68689cc90130a7:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    qt:shared=False
    
    [...]
        md4c/0.4.8:e3bbf246b1467814548fe44e0c394138dacdfd79 - Cache
        odbc/2.3.11:f2174f0708357d8e9606d39427b4984649903544 - Cache
        opengl/system:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Cache
        openssl/3.2.0:304480252b01879c8641f79a653b593b8f26cf9f - Cache
        pcre2/10.42:1dfef2d0e403379e1d4f34660b435fba4caeec11 - Cache
        qt/5.15.11:52cdc3d356cac053d77414153d68689cc90130a7 - Cache
        sqlite3/3.44.2:8fc930bdbf940331d9f322f454eac3dd06fd27e8 - Cache
        util-linux-libuuid/2.39.2:dfbe50feef7f3c6223a476cd5aeadb687084a646 - Cache
        wayland/1.22.0:75fce0356cb5cb051db7304f58922551d4ffb052 - Cache
        wayland-protocols/1.32:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Cache
        xkbcommon/1.5.0:2cf25f206848c950d17e61e191b8714acd0966b7 - Cache
        xkeyboard-config/system:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Cache
        xorg/system:5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9 - Cache
        zlib/1.3:dfbe50feef7f3c6223a476cd5aeadb687084a646 - Cache
        zstd/1.5.5:8016f3759d698995d987efa4b9ff23d4a4f30799 - Cache
    
    Installing (downloading, building) binaries...
    brotli/1.1.0: Already installed!
    bzip2/1.0.8: Already installed!
    double-conversion/3.3.0: Already installed!
    expat/2.5.0: Already installed!
    icu/73.2: Already installed!
    libffi/3.4.4: Already installed!
    libiconv/1.17: Already installed!
    libjpeg/9e: Already installed!
    libpq/15.4: Already installed!
    lz4/1.9.4: Already installed!
    m4/1.4.19: Already installed!
    md4c/0.4.8: Already installed!
    
    ----Running------
    > dpkg-query -W -f='${Status}' libgl-dev | grep -q "ok installed"
    -----------------
    
    ----Running------
    > dpkg-query -W -f='${Status}' libgl1-mesa-dev | grep -q "ok installed"
    -----------------
    dpkg-query: no packages found matching libgl-dev
    dpkg-query: no packages found matching libgl1-mesa-dev
    WARN: openssl/3.2.0: requirement zlib/[>=1.2.11 <2] overridden by qt/5.15.11 to zlib/1.3 
    WARN: pcre2/10.42: requirement zlib/[>=1.2.11 <2] overridden by qt/5.15.11 to zlib/1.3 
    WARN: freetype/2.13.2: requirement zlib/[>=1.2.10 <2] overridden by qt/5.15.11 to zlib/1.3 
    WARN: libpng/1.6.40: requirement zlib/[>=1.2.11 <2] overridden by freetype/2.13.2 to zlib/1.3 
    WARN: libmysqlclient/8.1.0: requirement openssl/[>=1.1 <4] overridden by qt/5.15.11 to openssl/3.2.0 
    WARN: libmysqlclient/8.1.0: requirement zlib/[>=1.2.11 <2] overridden by qt/5.15.11 to zlib/1.3 
    WARN: libxml2/2.12.2: requirement zlib/[>=1.2.11 <2] overridden by xkbcommon/1.5.0 to zlib/1.3 
    opengl/system: WARN: System requirements: 'libgl-dev' are missing but can't install because tools.system.package_manager:mode is 'check'.Please update packages manually or set 'tools.system.package_manager:mode' to 'install' in the [conf] section of the profile, or in the command line using '-c tools.system.package_manager:mode=install'
    opengl/system: WARN: System requirements: 'libgl1-mesa-dev' are missing but can't install because tools.system.package_manager:mode is 'check'.Please update packages manually or set 'tools.system.package_manager:mode' to 'install' in the [conf] section of the profile, or in the command line using '-c tools.system.package_manager:mode=install'
    opengl/system: ERROR: while executing system_requirements(): None of the installs for the package substitutes succeeded.
    ERROR: Error in system requirements
    
  • qt/5.15.10:
    Didn't run or was cancelled before finishing

  • qt/5.15.9:
    Didn't run or was cancelled before finishing

  • qt/5.15.8:
    Didn't run or was cancelled before finishing

  • qt/5.15.7:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 19 (f79692a5aad5b17f8cc6a5af6850fa97bc942fcc):

  • qt/5.15.10:
    Didn't run or was cancelled before finishing

  • qt/5.15.11:
    Didn't run or was cancelled before finishing

  • qt/5.15.9:
    CI failed to create some packages (All logs)

    Logs for packageID 185b85bc6cc80fb67907c68bc0de6d08021807d0:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=True
    
    [...]
        zlib/[>=1.2.11 <2]: zlib/1.3
    
    ======== Computing necessary packages ========
    Requirements
        autoconf/2.71#53be95d228b2dcb30dc199cb84262d8f:da39a3ee5e6b4b0d3255bfef95601890afd80709#ecdedaa05db7f162580f145df740c73b - Download (conan-center)
        automake/1.16.5#058bda3e21c36c9aa8425daf3c1faf50:9a4eb3c8701508aa9458b1a73d0633783ecc2270#9719e51a6a62041af6a63e00eef35434 - Download (conan-center)
        brotli/1.1.0#d56d7bb9ca722942aba17369cb5c0519:31b216f5bb11630e2c0601548f2a3d71f2558be9#43c8a9b3a8dc427d2dbcb60497cddf19 - Download (conan-center)
        bzip2/1.0.8#411fc05e80d47a89045edc1ee6f23c1d:582795513620c02434315fe471662206b3a90c44#b812d992549c98cd781d28fb30f67c84 - Download (conan-center)
        double-conversion/3.3.0#33321c201741cc32b51169c6d2d05e60:fc491156b442836722612d1aa8a8c57e406447b6#f1407535619b606d45f06ae81e56768b - Download (conan-center)
        expat/2.5.0#91e43e4544923e4c934bfad1fa4306f9:cb30f6fe72b581624d514ba67bfcf3b85327844a#473ccdfe4e45077157ca7e50c97d5837 - Download (conan-center)
        fontconfig/2.14.2#e43d6947356e29dee0ab8b05f75bd900:b871b671d2106209680b25f34fa7249904c34bfd#7302556031d6fbeca88928aa47d809eb - Download (conan-center)
        freetype/2.13.2#c9ee90dc6f88356febac6fcdba0b2249:9278f7ec43a6ecbe20123191128f92bc7a2d1cc8#5b12a71a267600c4c83c71886c2a26a5 - Download (conan-center)
        icu/73.2#2ac6430d9b0164fb3da98b705c65b3be:4ea1b1ec97e018654659ce99258a32ce545d80cd#f27324b75089ec3d21c5c6953f1738af - Download (conan-center)
        libffi/3.4.4#35eb63842b505824b70aedc1baefc916:abe5e2b04ea92ce2ee91bc9834317dbe66628206#df4f691365ba7fff0f3df7a2514eb530 - Download (conan-center)
        libiconv/1.17#fa54397801cd96911a8294bc5fc76335:abe5e2b04ea92ce2ee91bc9834317dbe66628206#3cbb797095f66828f6f09d715f77cb71 - Download (conan-center)
        libjpeg/9e#68269859e4325ddc3f995d1fd3fc9187:abe5e2b04ea92ce2ee91bc9834317dbe66628206#a678a07aec2e42ec348d068d356d87bc - Download (conan-center)
        libmysqlclient/8.1.0#d77b727e16905cbea932d90f01ed43e6:cbaa8238f2769372ba8b8199651c92f29a7800d5#bf99623e8244b05539926452398ca27b - Download (conan-center)
        libpng/1.6.40#0337b7b87ac125307ed70fd064c31eea:84ae3df57199b67cf54d99de695e2f68bbb208a8#f3a11d6d6ef6f6876db5b26b98a8f786 - Download (conan-center)
        libpq/15.4#886b735649233063640188e1d7892fd4:a4cad169c0d8c54dcac7a7aceabbd84f9d596e98#2a7f1737131806a0364a46db00bbdbf3 - Download (conan-center)
        libtool/2.4.7#525321775eb6780866f0bd534424aea1:abe5e2b04ea92ce2ee91bc9834317dbe66628206#501fcc0510dafe3c9148376374c36a50 - Download (conan-center)
        libxml2/2.12.2#fe7e33e87cf3d06ce4852c13e12e929c:7cc7ab6eee48ddfcfcd8a2299f259d106c16b91d#860b7ec1bf9649a48f6a7868e91d0fae - Download (conan-center)
        lz4/1.9.4#1217a03c990b79aa34ed0faede18f534:abe5e2b04ea92ce2ee91bc9834317dbe66628206#a6d6281bb7fc9d2c08b088011faaa66b - Download (conan-center)
        m4/1.4.19#b38ced39a01e31fef5435bc634461fd2:3593751651824fb813502c69c971267624ced41a#cd8019a4f9b70880d548f7cc26569604 - Download (conan-center)
        md4c/0.4.8#84b2885aa93a27653f5067a77044b0e3:7f95052682e340499993e6123025882982e455a6#eb9c9c0e58667627be1bafdded5b965a - Download (conan-center)
        odbc/2.3.11#84d32d803c970271eb2fc58d3e3cc2b5:f96b8c0b97d02e3279bf787eba1355f2bc667dc8#72808b82130d7c77e93707b994f779c2 - Download (conan-center)
        opengl/system#b29589c04d6df84c110d6acb066ab653:da39a3ee5e6b4b0d3255bfef95601890afd80709#0ba8627bd47edc3a501e8f0eb9a79e5e - Download (conan-center)
        openssl/3.2.0#d81e0a8c08372368fe7cb757280e2196:dfecdba757b18d23b9a7ef9d3d682ceaee6f602c#84fc82d1f442334e7081ab96c0f81135 - Download (conan-center)
        pcre2/10.42#74a354d74d291503aadffe6453d976f5:be7f50c28f3b93ddad2770a9a5d0a31ee941be4c#ba4ccbcad5e9900af03d2f4a7ede8ff7 - Download (conan-center)
        qt/5.15.9#3ae1aca17ae0c6a74fd28772ab123fbf:185b85bc6cc80fb67907c68bc0de6d08021807d0#30f7ccda83f79117dc4fc10074e1f052 - Download (c3i_PR-v2-21026)
        sqlite3/3.44.2#6aea4802c643c19f97b7f5a8a4b4f16d:5fb25314b9eee7af252cc47a613eea9d81e1d064#3b18a47d6a55126ec12259eef429dece - Download (conan-center)
        util-linux-libuuid/2.39.2#16074ebe9338e959492de3de88fe17ab:abe5e2b04ea92ce2ee91bc9834317dbe66628206#43b664355fe21d758d598d7a22dcf441 - Download (conan-center)
        wayland/1.22.0#931c887406a7759b0f44ea239488cf1c:6c0c20d40041519ef529f32aabb373f80efe59a9#e2fb79b8c5b36368e131e9bdf662ee30 - Download (conan-center)
        xkbcommon/1.5.0#aab6959d4528b1d56a00bd78d04900c1:8e411f12e308166b0015003548eea76415344a4e#ba38bcc1954a4568995d338eaf338f4c - Download (conan-center)
        xorg/system#de8fc1917bb3d11cf7a1d15eccf79c16:da39a3ee5e6b4b0d3255bfef95601890afd80709#0ba8627bd47edc3a501e8f0eb9a79e5e - Download (conan-center)
        zlib/1.3#06023034579559bb64357db3a53f88a4:abe5e2b04ea92ce2ee91bc9834317dbe66628206#be744f18843976f205e00744293521b8 - Download (conan-center)
        zstd/1.5.5#b87dc3b185caa4b122979ac4ae8ef7e8:43c10c705bb0f1d0030e597cb09a05ef5953fed9#82271e8cdb5bc29d590684c8834c5557 - Download (conan-center)
    Build requirements
    Skipped binaries
        xkeyboard-config/system, autoconf/2.71, automake/1.16.5, bison/3.8.2, expat/2.5.0, flex/2.6.4, gnu-config/cci.20210814, gperf/3.1, libffi/3.4.4, libiconv/1.17, libxml2/2.12.2, m4/1.4.19, meson/1.2.2, meson/1.2.3, meson/1.3.0, ninja/1.11.1, pkgconf/2.0.3, pkgconf/2.1.0, wayland-protocols/1.32, wayland/1.22.0, zlib/1.3
    opengl/system: RUN: dpkg-query -W -f='${Status}' libgl-dev | grep -q "ok installed"
    dpkg-query: no packages found matching libgl-dev
    
    opengl/system: RUN: dpkg-query -W -f='${Status}' libgl1-mesa-dev | grep -q "ok installed"
    dpkg-query: no packages found matching libgl1-mesa-dev
    
    opengl/system: WARN: System requirements: 'libgl-dev' are missing but can't install because tools.system.package_manager:mode is 'check'.Please update packages manually or set 'tools.system.package_manager:mode' to 'install' in the [conf] section of the profile, or in the command line using '-c tools.system.package_manager:mode=install'
    opengl/system: WARN: System requirements: 'libgl1-mesa-dev' are missing but can't install because tools.system.package_manager:mode is 'check'.Please update packages manually or set 'tools.system.package_manager:mode' to 'install' in the [conf] section of the profile, or in the command line using '-c tools.system.package_manager:mode=install'
    ERROR: opengl/system: Error in system_requirements() method, line 33
    	apt.install_substitutes(["libgl-dev"], ["libgl1-mesa-dev"], update=True, check=True)
    	ConanException: None of the installs for the package substitutes succeeded.
    
  • qt/5.15.8:
    Didn't run or was cancelled before finishing

  • qt/5.15.7:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ghost ghost mentioned this pull request Dec 26, 2023
3 tasks
@ghost ghost mentioned this pull request Jan 19, 2024
3 tasks
@ghost ghost mentioned this pull request Feb 5, 2024
3 tasks
@jcar87
Copy link
Contributor

jcar87 commented Aug 1, 2024

Thanks @wdobbe for your contribution and apologies it has taken long for us to review this. I'm preparing a PR with fixes to qt6 webengine for all platforms, and will cherry pick this and include this, preserving your authorship.

A couple of points:
Qt 5.15 is still maintained by the Qt company until 2025: https://www.qt.io/blog/qt-5.15-extended-support-for-subscription-license-holders - although for commercial customers. It has been observed that a year after their commercial release, the patch releases are made open source.

The most recent qt 5.15 relases (including qt 5.15.14 which the latest we maintin), are based on Chromium version 87 (see https://wiki.qt.io/QtWebEngine/ChromiumVersions)

The patch in question https://bugreports.qt.io/browse/QTBUG-116649 has been backported to their 87 branch as per https://codereview.qt-project.org/c/qt/qtwebengine-chromium/+/537257 - so this is enough for us to confirm that Qt has backported the fix to the chromium version in the 5.15.x branch. We are a bit more careful/skeptical when patches from Qt 6.x are backported when there is no indication that Qt themselves would do it - we have no intention to maintain Qt5 beyond the official open source releases - although in this case it is clear it is maintained and likely to be part of future 5.15.x releases.

@jcar87
Copy link
Contributor

jcar87 commented Aug 6, 2024

Fixed in #24826
(preserving the authorship in of this PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants