qt5: fix build with apple-clang 15 + add package_type + bump deps + use version range for zlib #20093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'. 👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉 |
|
There is another issue to fix: #20075 (comment) |
This was referenced Sep 24, 2023
Closed
jwillikers
approved these changes
Sep 24, 2023
|
Now it builds with apple-clang 15, but locally there is a SIP issue when zlib is shared... I though that I've fixed that in a previous PR, I hate Apple and their SIP. |
Fixed by latest commit f9c91fa |
SpaceIm
changed the title
SpaceIm
changed the title
jwillikers
approved these changes
Sep 25, 2023
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 9938bebqt/5.15.9@#550fa3129577bea32cbb7d6aba2eebdbqt/5.15.10@#6da4519e110f3ea68e3f956efc0654a9qt/5.15.8@#2254cef1caef0caefab3eff77d2e4363qt/5.15.7@#641a8bdca15589dcdb755939e65fe779 |
|
v2 pipeline: @RubenRBS I don't know if those one are available now. |
ghost
mentioned this pull request
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 9d78ba6qt/5.15.11@#4fc6000ad3b80c024813e94cecaedaa0qt/5.15.8@#cb3702e7ae007aa11f7cd1ab24886e47qt/5.15.10@#c3ec173dfb07eeb620fb8c9f42ef1370qt/5.15.9@#84678395fd7f2302a21b7e7494e3fbfdqt/5.15.7@#ab98648583e354cbc14ff4fc63476aa6 |
MartinDelille
approved these changes
Oct 9, 2023
AbrilRBS
reviewed
Oct 10, 2023
| # On macOS, SIP resets DYLD_LIBRARY_PATH injected by VirtualBuildEnv & VirtualRunEnv. | ||
| # Qt builds several executables (moc etc) which are called later on during build of | ||
| # libraries, and these executables link to several external dependencies in requirements(). | ||
| # If these external libs are shared, moc calls fail because its dylib dependencies |
There was a problem hiding this comment.
Where did the inspiration for this come from? Any extra insight would be appreciated :) but looks good to me
There was a problem hiding this comment.
I have this error locally without this workaround: #20093 (comment). Injection of VirtualRunEnv in build scope doesn't work on macOS due to SIP (at some point SIP resets DYLD_LIBRARY_PATH, I don't kno exactly when it happens during build, but it's a fact). Previous BASH_ENV workaround doesn't work either depending on terminal (zsh doesn't care for example). So if correct zlib version (matching the one installed by conan) is not installed on system, it fails.
The only workaround I've found is to add path to shared libs in LC_RPATH of runtimes built during qt build, SIP can't do anything against that.
There was a problem hiding this comment.
Actually, it's the same hack than the one in AutotoolsToolchain: https://github.com/conan-io/conan/blob/5f0dc4da2202069d20a59ccbbc17b179aaffed33/conan/tools/gnu/autotoolsdeps.py#L58-L60
There was a problem hiding this comment.
Might this cause rsulting binaries inside the package to have an absolute rpath to folders only present in the build machine? @SpaceIm
|
@RubenRBS is it fine for you? I already had to handle a new version in this PR which was not there when I've opened this PR, it's a lot of work to maintain a PR when other more recent PRs are merged. |
@SpaceIm I know it can get cumbersome, a high volume of PRs makes stuff like this happening more likely, so thanks again for taking the time to get it updated :) |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 9 (
Conan v2 pipeline ✔️
All green in build 8 ( |
Hooks produced the following warnings for commit 9d78ba6qt/5.15.11@#78842e8b97c929bda2231cbe3be86d2fqt/5.15.10@#475dc546bfb157c097e9652ee8174ea6qt/5.15.7@#4c60b3cf04a0bf4e6e1d38d838c4abd8qt/5.15.9@#f9116f3c9afcd936d09d586c561a0f6aqt/5.15.8@#02c1666fe5153ec98b5ea36ebecbcc36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<host_version>for wayland in build requirementscloses #20075