Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: bump dependencies #13906

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 31, 2022

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Oct 31, 2022

I detected other pull requests that are modifying ffmpeg/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Nov 1, 2022
@SpaceIm SpaceIm reopened this Nov 1, 2022
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 1, 2022

make: *** [/c/j/w/prod/buildsinglereference/.conan/data/ffmpeg/5.0/_/_/build/ad77562fc8851a7dea050484b3ad11a256f04262/source_subfolder/ffbuild/common.mak:100: libavfilter/x86/af_afir.o] Error 127

? I've just bumped few deps, so what's wrong?

@SSE4
Copy link
Contributor

SSE4 commented Nov 1, 2022

errno 127 is command not found
af_afir.o is af_afir.asm compiled with assembler.
it seems like assembler executable (nasm? yasm?) wasn't found for some reason? might it be because it suddenly resolved new package revision of build requirement?

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 1, 2022

yasm is indeed in build requirements, and was updated recently in #13185 & #13573 (these PRs have been merged after the last successful build of ffmpeg in c3i: #13387).

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 1, 2022

There was a major change in #13185, msvc build was migrated from sln files to CMake. @MartinDelille did you check that the build was similar?

@MartinDelille
Copy link
Contributor

No. The cmake build was done here: b482250

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 2, 2022

No. The cmake build was done here: b482250

@madebr any idea why yasm fails on Windows?

@madebr
Copy link
Contributor

madebr commented Nov 2, 2022

How is the configured script informed about yasm?
configure of current ffmpeg has:

  --x86asmexe=EXE          use nasm-compatible assembler EXE [nasm]

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 2, 2022

--x86asmexe is not passed to configure.

But during configure yasm seems to be detected:

install prefix            C:/J/w/prod/BuildSingleReference/.conan/data/ffmpeg/5.0/_/_/package/ad77562fc8851a7dea050484b3ad11a256f04262
source path               /c/j/w/prod/buildsinglereference/.conan/data/ffmpeg/5.0/_/_/build/ad77562fc8851a7dea050484b3ad11a256f04262/source_subfolder
C compiler                cl.exe
C library                 msvcrt
ARCH                      x86 (generic)
big-endian                no
runtime cpu detection     yes
standalone assembly       yes
x86 assembler             yasm
MMX enabled               yes
MMXEXT enabled            yes
3DNow! enabled            yes
3DNow! extended enabled   yes
SSE enabled               yes
SSSE3 enabled             yes
AESNI enabled             yes
AVX enabled               yes
AVX2 enabled              yes
AVX-512 enabled           yes
XOP enabled               yes
FMA3 enabled              yes
FMA4 enabled              yes
i686 features enabled     yes
CMOV is fast              yes
EBX available             no
EBP available             no
debug symbols             yes
strip symbols             no
optimize for size         no
optimizations             yes
static                    yes
shared                    no
postprocessing support    yes
network support           yes
threading support         w32threads
safe bitstream reader     yes
texi2html enabled         no
perl enabled              yes
pod2man enabled           yes
makeinfo enabled          yes
makeinfo supports HTML    yes
xmllint enabled           yes

moreover we can see bin dir of yasm package in environment:

----Running------
> C:\J\w\prod\BuildSingleReference\s\c5811a\1\bin\msys64\usr\bin\bash.exe --login -c ^"cd \^"/c/j/w/prod/buildsinglereference/.conan/data/ffmpeg/5.0/_/_/build/ad77562fc8851a7dea050484b3ad11a256f04262\^" ^&^& PATH=\^"/c/j/w/prod/buildsinglereference/.conan/data/yasm/1.3.0/_/_/package/0a420ff5c47119e668867cdb51baff0eca1fdb68/bin:/c/j/w/prod/buildsinglereference/.conan/data/pkgconf/1.9.3/_/_/package/0a420ff5c47119e668867cdb51baff0eca1fdb68/bin:/c/j/w/prod/buildsinglereference/s/c5811a/1/bin/msys64/usr/bin:/c/j/w/prod/buildsinglereference/.conan/data/libiconv/1.17/_/_/package/7bd6f2c3d5c4e48a75805376b58cde753392f711/bin:/c/j/w/prod/buildsinglereference/.conan/data/freetype/2.12.1/_/_/package/c2481f7bf9fa68e77ac5e32c67eff32d33d0909e/bin:/c/j/w/prod/buildsinglereference/.conan/data/bzip2/1.0.8/_/_/package/f346bbbb687a20f72b88f02617b6b8f1300bad72/bin:$PATH\^" ^&^& make -j8 ^"
-----------------

In the new build of yasm recipe, I see that more executables than before are packaged in windows build, and a dll which was not here in previous build. I don't know whether it changes anything.

after #13185:

yasm/1.3.0 package(): Packaged 3 '.exe' files: vsyasm.exe, yasm.exe, ytasm.exe
yasm/1.3.0 package(): Packaged 2 '.dll' files: yasm.dll, yasmstd.dll
yasm/1.3.0 package(): Packaged 1 '.txt' file: BSD.txt
yasm/1.3.0 package(): Packaged 1 file: COPYING

before #13185:

yasm/1.3.0 package(): Packaged 1 '.exe' file: yasm.exe
yasm/1.3.0 package(): Packaged 1 '.txt' file: BSD.txt
yasm/1.3.0 package(): Packaged 1 file: COPYING

@madebr
Copy link
Contributor

madebr commented Nov 2, 2022

72c8359 goes from using the visual studio project to a cmake project (that was my suggestion).
Maybe the executables are not 100% compatible/supported?

The main difference looks like BUILD_SHARED_LIBS being ON by default.
I think the visual studio project uses static libraries (or none at all).

@madebr
Copy link
Contributor

madebr commented Nov 6, 2022

I can reproduce this error when I build yasm with MT runtime, and not when yasm is built with MD runtime.
So when yasm is built with shared libraries, the runtime cannot be MT(d).

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Nov 7, 2022

Thanks. It might be a good idea to build static flavor by default on Windows, to be consistent with autotools build, and remove lib since it's not even propagated in package_info() of yasm recipe currently.

@madebr madebr mentioned this pull request Nov 7, 2022
4 tasks
@SpaceIm SpaceIm closed this Nov 9, 2022
@SpaceIm SpaceIm reopened this Nov 9, 2022
@SpaceIm SpaceIm closed this Nov 9, 2022
@SpaceIm SpaceIm reopened this Nov 9, 2022
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 6 (4ba3165b515321ef04c13b52072318041e90abc1):

  • ffmpeg/4.3.2@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py", line 7, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • ffmpeg/4.2.1@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py", line 7, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • ffmpeg/4.4@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py", line 7, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • ffmpeg/5.0@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py", line 7, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    
  • ffmpeg/4.4.3@:
    All packages built successfully! (All logs)

    🔸 Informative: This recipe is not ready for Conan v2

    We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.
    This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.
    See the recipe migration guide to know more about the changes required.

    ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py
      File "<frozen importlib._bootstrap_external>", line 728, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/conan/w/prod_cci_PR-13906/recipes/ffmpeg/all/conanfile.py", line 7, in <module>
        from conans import AutoToolsBuildEnvironment, tools
    ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)
    

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 4ba3165
ffmpeg/4.4.3
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\avcodec-58.dll' links to system library 'mfplat' but it is not in cpp_info.system_libs.

@conan-center-bot conan-center-bot merged commit 633499d into conan-io:master Nov 11, 2022
@SpaceIm SpaceIm deleted the ffmpeg-bump-deps branch November 11, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump dependencies Only bumping dependencies versions in the recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants