Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg] Conan v2 migration #13664

Closed

Conversation

MartinDelille
Copy link
Contributor

Specify library name and version: lib/1.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@ghost
Copy link

ghost commented Oct 21, 2022

I detected other pull requests that are modifying ffmpeg/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

# problem
del tc.configure_args[7] # --oldincludedir=${prefix}/include
del tc.configure_args[6] # --includedir=${prefix}/include
del tc.configure_args[4] # --sbin=${prefix}/bin
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a cleaner way to deal with this issue where ffmpeg doesn't accept this arguments ?

@conan-center-bot

This comment has been minimized.

@MartinDelille
Copy link
Contributor Author

After investigating this issue, it looks like the AutotoolsToolchain is adding the unsupported --host=aarch64-apple-darwin (which makes no sense since the host is supposed to be armv8) without way to deleting it like for oldincludedir, includedir and sbin.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

Failure in build 8 (790c71cadedf21f4f5373444d235bfdce0f17127):

  • ffmpeg/4.3.2@:
    CI failed to create some packages (All logs)

    Logs for packageID 10f8fb9c3a8f21b334dd23f84f4238b76a14f5ab:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=12.0
    os=Macos
    [options]
    ffmpeg:shared=True
    
    [...]
        openh264/2.1.1 from 'conan-center' - Downloaded
        openjpeg/2.5.0 from 'conan-center' - Downloaded
        openssl/1.1.1s from 'conan-center' - Downloaded
        opus/1.3.1 from 'conan-center' - Downloaded
        vorbis/1.3.7 from 'conan-center' - Downloaded
        xz_utils/5.2.5 from 'conan-center' - Downloaded
        zlib/1.2.13 from 'conan-center' - Downloaded
    Packages
        brotli/1.0.9:88f1a731f70eb2788d27d32c0bc1c301aae0bae4 - Download
        bzip2/1.0.8:75fe66fbfe61230e9fcbb361f13b6b3baa483e0a - Download
        ffmpeg/4.3.2:10f8fb9c3a8f21b334dd23f84f4238b76a14f5ab - Build
        freetype/2.12.1:f4924bd3b94e155cbf790d74ba3a3c29ccc81e89 - Download
        libfdk_aac/2.0.2:6a83d7f783e7ee89a83cf2fe72b5f5f67538e2a6 - Download
        libiconv/1.17:647afeb69d3b0a2d3d316e80b24d38c714cc6900 - Download
        libmp3lame/3.100:647afeb69d3b0a2d3d316e80b24d38c714cc6900 - Download
        libpng/1.6.38:ac5d0a30f12dfc11387a002e4010b156f3b7eda5 - Missing
        libvpx/1.11.0:d1d011496410e7824d399f9ed925cd1556894d02 - Download
        libwebp/1.2.4:2dbaf0210f4bb922bb094c944e22cc14a0bb05f6 - Download
        libx264/cci.20220602:164ce1f22baa425c7ab7ceb8e7c38914db295c36 - Download
        libx265/3.4:dfed11b76ca8cbdfe0c68910d615a3e14f42b423 - Download
        ogg/1.3.5:647afeb69d3b0a2d3d316e80b24d38c714cc6900 - Download
        openh264/2.1.1:6a83d7f783e7ee89a83cf2fe72b5f5f67538e2a6 - Download
        openjpeg/2.5.0:647afeb69d3b0a2d3d316e80b24d38c714cc6900 - Download
        openssl/1.1.1s:647afeb69d3b0a2d3d316e80b24d38c714cc6900 - Download
        opus/1.3.1:647afeb69d3b0a2d3d316e80b24d38c714cc6900 - Download
        vorbis/1.3.7:f3d27e66931814996d5618e827338786b77d4b6b - Download
        xz_utils/5.2.5:647afeb69d3b0a2d3d316e80b24d38c714cc6900 - Download
        zlib/1.2.13:647afeb69d3b0a2d3d316e80b24d38c714cc6900 - Download
    Build requirements
        pkgconf/1.9.3 from 'conan-center' - Downloaded
        yasm/1.3.0 from 'conan-center' - Downloaded
    Build requirements packages
        pkgconf/1.9.3:801752c0480319b8e090188c566245a78e9abcf4 - Download
        yasm/1.3.0:801752c0480319b8e090188c566245a78e9abcf4 - Download
    
    Installing (downloading, building) binaries...
    
    ERROR: Missing binary: libpng/1.6.38:ac5d0a30f12dfc11387a002e4010b156f3b7eda5
    libpng/1.6.38: WARN: Can't find a 'libpng/1.6.38' package for the specified settings, options and dependencies:
    - Settings: arch=x86_64, build_type=Release, compiler=apple-clang, compiler.version=12.0, os=Macos
    - Options: api_prefix=, fPIC=True, shared=False, sse=True, zlib:fPIC=True, zlib:shared=False
    - Dependencies: zlib/1.2.13
    - Requirements: zlib/1.Y.Z
    - Package ID: ac5d0a30f12dfc11387a002e4010b156f3b7eda5
    
    ERROR: Missing prebuilt package for 'libpng/1.6.38'
    Use 'conan search libpng/1.6.38@ --table=table.html -r=remote' and open the table.html file to see available packages
    Or try to build locally from sources with '--build=libpng'
    
    More Info at 'https://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package'
    
  • ffmpeg/5.0@:
    Didn't run or was cancelled before finishing

  • ffmpeg/4.2.1@:
    Didn't run or was cancelled before finishing

  • ffmpeg/4.4@:
    Didn't run or was cancelled before finishing

  • ffmpeg/4.4.3@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@stale
Copy link

stale bot commented Dec 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 16, 2022
@MartinDelille MartinDelille deleted the ffmpeg-conan-v2-bis branch December 31, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants