Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFmpeg conan v2 #13235

Closed
wants to merge 7 commits into from
Closed

FFmpeg conan v2 #13235

wants to merge 7 commits into from

Conversation

sorny92
Copy link
Contributor

@sorny92 sorny92 commented Sep 30, 2022

Specify library name and version: ffmpeg/x.x.x

Updating ffmpeg to conan v2 based on the work of #13143.

Also this PR adds support for 5.1and 5.1.2as they are the latests versions of the library.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Sep 30, 2022

I detected other pull requests that are modifying ffmpeg/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prsso don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request Sep 30, 2022
4 tasks
@sorny92 sorny92 changed the title Ffmpeg conan v2 FFmpeg conan v2 Sep 30, 2022
recipes/ffmpeg/all/conandata.yml Outdated Show resolved Hide resolved
recipes/ffmpeg/all/conanfile.py Show resolved Hide resolved
recipes/ffmpeg/all/conanfile.py Outdated Show resolved Hide resolved
recipes/ffmpeg/config.yml Outdated Show resolved Hide resolved
@@ -179,10 +185,6 @@ class FFMpegConan(ConanFile):
generators = "pkg_config"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really required??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove it you get the next error:

ERROR: ffmpeg/5.0@lumicks/cookbook-testing: Error in build() method, line 569
	shutil.copy("x264.pc", "libx264.pc")
	FileNotFoundError: [Errno 2] No such file or directory: 'x264.pc'

recipes/ffmpeg/all/conanfile.py Outdated Show resolved Hide resolved
recipes/ffmpeg/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Oct 21, 2022
4 tasks
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

Failure in build 11 (f8689a1a3830a7255faba96aab9072caa99ef746):

  • ffmpeg/4.2.1@:
    CI failed to create some packages (All logs)

    Logs for packageID 4d481ca703341d8b58965ab34913028d8e8af176:
    [settings]
    arch=armv8
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=12.0
    os=Macos
    [options]
    ffmpeg:shared=False
    
    [...]
    ffmpeg/4.2.1: Generator pkg_config created fdk-aac.pc
    ffmpeg/4.2.1: Generator pkg_config created libwebp.pc
    ffmpeg/4.2.1: Generator pkg_config created libwebpmux.pc
    ffmpeg/4.2.1: Generator pkg_config created libwebpdemux.pc
    ffmpeg/4.2.1: Generator pkg_config created libwebpdecoder.pc
    ffmpeg/4.2.1: Generator pkg_config created libwebp-all-do-not-use.pc
    ffmpeg/4.2.1: Generator pkg_config created libcrypto.pc
    ffmpeg/4.2.1: Generator pkg_config created libssl.pc
    ffmpeg/4.2.1: Generator pkg_config created openssl.pc
    ffmpeg/4.2.1: Generator pkg_config created bzip2.pc
    ffmpeg/4.2.1: Generator pkg_config created libpng.pc
    ffmpeg/4.2.1: Generator pkg_config created libbrotlicommon.pc
    ffmpeg/4.2.1: Generator pkg_config created libbrotlienc.pc
    ffmpeg/4.2.1: Generator pkg_config created libbrotlidec.pc
    ffmpeg/4.2.1: Generator pkg_config created brotli.pc
    ffmpeg/4.2.1: Generator pkg_config created ogg.pc
    ffmpeg/4.2.1: Generator pkg_config created zlib.pc
    ffmpeg/4.2.1: Calling generate()
    ffmpeg/4.2.1: Aggregating env generators
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK. 'fPIC' option found and apparently well managed
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
    ffmpeg/4.2.1: Calling build()
    ffmpeg/4.2.1: Calling:
     > "/Users/jenkins/w/prod/BuildSingleReference/.conan/data/ffmpeg/4.2.1/_/_/build/4d481ca703341d8b58965ab34913028d8e8af176/./configure" '--disable-shared' '--enable-static' '--prefix=/' '--bindir=${prefix}/bin' '--libdir=${prefix}/lib' '--incdir=${prefix}/include' '--pkg-config-flags=--static' '--disable-doc' '--enable-cross-compile' '--enable-asm' '--disable-shared' '--enable-static' '--enable-pic' '--enable-avdevice' '--enable-avcodec' '--enable-avformat' '--enable-swresample' '--enable-swscale' '--enable-postproc' '--enable-avfilter' '--enable-bzlib' '--enable-zlib' '--enable-lzma' '--enable-iconv' '--enable-libopenjpeg' '--enable-libopenh264' '--enable-libvorbis' '--enable-libopus' '--disable-libzmq' '--disable-sdl2' '--enable-libx264' '--enable-libx265' '--enable-libvpx' '--enable-libmp3lame' '--enable-libfdk-aac' '--enable-libwebp' '--enable-openssl' '--disable-alsa' '--disable-libpulse' '--disable-vaapi' '--disable-vdpau' '--disable-libxcb' '--disable-libxcb-shm' '--disable-libxcb-shape' '--disable-libxcb-xfixes' '--enable-appkit' '--enable-avfoundation' '--enable-coreimage' '--enable-audiotoolbox' '--enable-videotoolbox' '--disable-securetransport' '--disable-cuda' '--disable-cuvid' '--enable-nonfree' '--enable-gpl' '--install-name-dir=@rpath' '--arch=armv8' '--target-os=Macos' '--disable-outdev=audiotoolbox' '--extra-cflags=-arch arm64 -isysroot /Applications/conan/xcode/12/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk' '--extra-ldflags=-arch arm64 -isysroot /Applications/conan/xcode/12/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk' '--env=host=aarch64-apple-darwin,build=x86_64-apple-darwin' 
    
    ----Running------
    > . "/Users/jenkins/w/prod/BuildSingleReference/.conan/data/ffmpeg/4.2.1/_/_/build/4d481ca703341d8b58965ab34913028d8e8af176/build-release/conan/conanbuild.sh" && "/Users/jenkins/w/prod/BuildSingleReference/.conan/data/ffmpeg/4.2.1/_/_/build/4d481ca703341d8b58965ab34913028d8e8af176/./configure" '--disable-shared' '--enable-static' '--prefix=/' '--bindir=${prefix}/bin' '--libdir=${prefix}/lib' '--incdir=${prefix}/include' '--pkg-config-flags=--static' '--disable-doc' '--enable-cross-compile' '--enable-asm' '--disable-shared' '--enable-static' '--enable-pic' '--enable-avdevice' '--enable-avcodec' '--enable-avformat' '--enable-swresample' '--enable-swscale' '--enable-postproc' '--enable-avfilter' '--enable-bzlib' '--enable-zlib' '--enable-lzma' '--enable-iconv' '--enable-libopenjpeg' '--enable-libopenh264' '--enable-libvorbis' '--enable-libopus' '--disable-libzmq' '--disable-sdl2' '--enable-libx264' '--enable-libx265' '--enable-libvpx' '--enable-libmp3lame' '--enable-libfdk-aac' '--enable-libwebp' '--enable-openssl' '--disable-alsa' '--disable-libpulse' '--disable-vaapi' '--disable-vdpau' '--disable-libxcb' '--disable-libxcb-shm' '--disable-libxcb-shape' '--disable-libxcb-xfixes' '--enable-appkit' '--enable-avfoundation' '--enable-coreimage' '--enable-audiotoolbox' '--enable-videotoolbox' '--disable-securetransport' '--disable-cuda' '--disable-cuvid' '--enable-nonfree' '--enable-gpl' '--install-name-dir=@rpath' '--arch=armv8' '--target-os=Macos' '--disable-outdev=audiotoolbox' '--extra-cflags=-arch arm64 -isysroot /Applications/conan/xcode/12/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk' '--extra-ldflags=-arch arm64 -isysroot /Applications/conan/xcode/12/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk' '--env=host=aarch64-apple-darwin,build=x86_64-apple-darwin' 
    -----------------
    Capturing current environment in /Users/jenkins/w/prod/BuildSingleReference/.conan/data/ffmpeg/4.2.1/_/_/build/4d481ca703341d8b58965ab34913028d8e8af176/build-release/conan/deactivate_conanautotoolstoolchain.sh
    Configuring environment variables
    Capturing current environment in /Users/jenkins/w/prod/BuildSingleReference/.conan/data/ffmpeg/4.2.1/_/_/build/4d481ca703341d8b58965ab34913028d8e8af176/build-release/conan/deactivate_conanautotoolsdeps.sh
    Configuring environment variables
    Capturing current environment in /Users/jenkins/w/prod/BuildSingleReference/.conan/data/ffmpeg/4.2.1/_/_/build/4d481ca703341d8b58965ab34913028d8e8af176/build-release/conan/deactivate_conanbuildenv-release-armv8.sh
    Configuring environment variables
    gcc is unable to create an executable file.
    C compiler test failed.
    
    If you think configure made a mistake, make sure you are using the latest
    version from Git.  If the latest version fails, report the problem to the
    ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.freenode.net.
    Include the log file "ffbuild/config.log" produced by configure as this will help
    solve the problem.
    ffmpeg/4.2.1: 
    WARN: freetype/2.12.1: requirement zlib/1.2.13 overridden by ffmpeg/4.2.1 to zlib/1.2.12 
    WARN: libpng/1.6.38: requirement zlib/1.2.13 overridden by freetype/2.12.1 to zlib/1.2.12 
    ffmpeg/4.2.1: ERROR: Package '4d481ca703341d8b58965ab34913028d8e8af176' build failed
    ffmpeg/4.2.1: WARN: Build folder /Users/jenkins/w/prod/BuildSingleReference/.conan/data/ffmpeg/4.2.1/_/_/build/4d481ca703341d8b58965ab34913028d8e8af176/build-release
    ERROR: ffmpeg/4.2.1: Error in build() method, line 719
    	autotools.configure()
    	ConanException: Error 1 while executing "/Users/jenkins/w/prod/BuildSingleReference/.conan/data/ffmpeg/4.2.1/_/_/build/4d481ca703341d8b58965ab34913028d8e8af176/./configure" '--disable-shared' '--enable-static' '--prefix=/' '--bindir=${prefix}/bin' '--libdir=${prefix}/lib' '--incdir=${prefix}/include' '--pkg-config-flags=--static' '--disable-doc' '--enable-cross-compile' '--enable-asm' '--disable-shared' '--enable-static' '--enable-pic' '--enable-avdevice' '--enable-avcodec' '--enable-avformat' '--enable-swresample' '--enable-swscale' '--enable-postproc' '--enable-avfilter' '--enable-bzlib' '--enable-zlib' '--enable-lzma' '--enable-iconv' '--enable-libopenjpeg' '--enable-libopenh264' '--enable-libvorbis' '--enable-libopus' '--disable-libzmq' '--disable-sdl2' '--enable-libx264' '--enable-libx265' '--enable-libvpx' '--enable-libmp3lame' '--enable-libfdk-aac' '--enable-libwebp' '--enable-openssl' '--disable-alsa' '--disable-libpulse' '--disable-vaapi' '--disable-vdpau' '--disable-libxcb' '--disable-libxcb-shm' '--disable-libxcb-shape' '--disable-libxcb-xfixes' '--enable-appkit' '--enable-avfoundation' '--enable-coreimage' '--enable-audiotoolbox' '--enable-videotoolbox' '--disable-securetransport' '--disable-cuda' '--disable-cuvid' '--enable-nonfree' '--enable-gpl' '--install-name-dir=@rpath' '--arch=armv8' '--target-os=Macos' '--disable-outdev=audiotoolbox' '--extra-cflags=-arch arm64 -isysroot /Applications/conan/xcode/12/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk' '--extra-ldflags=-arch arm64 -isysroot /Applications/conan/xcode/12/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk' '--env=host=aarch64-apple-darwin,build=x86_64-apple-darwin' 
    
  • ffmpeg/5.0@:
    Didn't run or was cancelled before finishing

  • ffmpeg/4.4@:
    Didn't run or was cancelled before finishing

  • ffmpeg/4.3.2@:
    Didn't run or was cancelled before finishing

  • ffmpeg/4.4.3@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@stale
Copy link

stale bot commented Dec 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 16, 2022
@ghost ghost mentioned this pull request Dec 31, 2022
3 tasks
@sorny92 sorny92 closed this by deleting the head repository Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants