Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yasm: fix MinGW #13573

Merged
merged 1 commit into from
Oct 18, 2022
Merged

yasm: fix MinGW #13573

merged 1 commit into from
Oct 18, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Oct 18, 2022 •
edited
Loading

addresses reviews in #13185

closes #13574

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@SpaceIm SpaceIm mentioned this pull request Oct 18, 2022
Closed
@ghost
Copy link

ghost commented Oct 18, 2022

I detected other pull requests that are modifying yasm/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Oct 18, 2022
Closed
Closed
@github-actions github-actions bot mentioned this pull request Oct 18, 2022
Open
@conan-center-bot
Copy link
Collaborator

All green in build 3 (34334d8800766b51a87a42b1d9f48006337631e8):

  • yasm/1.3.0@:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 7eafaf9 into conan-io:master Oct 18, 2022
@SpaceIm SpaceIm deleted the fix/yasm branch October 18, 2022 19:12
@SpaceIm SpaceIm mentioned this pull request Nov 1, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@jwillikers jwillikers jwillikers approved these changes

@danimtb danimtb Awaiting requested review from danimtb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[package] yasm/1.3.0: can't build when MinGW is set as build profile
4 participants
@SpaceIm @conan-center-bot @uilianries @jwillikers