Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yasm/1.3.0 Globally available sources download URL #13370

Closed
wants to merge 1 commit into from

Conversation

VestniK
Copy link
Contributor

@VestniK VestniK commented Oct 9, 2022

URL from the yasm github releases page points to the archive with the same sha256 of the content. Some people reporting download failure of the http://www.tortall.net/projects/yasm/releases/yasm-1.3.0.tar.gz

Relevant issues:


  • [v] I've read the guidelines for contributing.
  • [v] I've followed the PEP8 style guides for Python code in the recipes.
  • [v] I've used the latest Conan client version.
  • [v] I've tried at least one configuration locally with the conan-center hook activated.

URL from the yasm github releases page points to the archive with the same
sha256 of the content. Some people reporting download failure of the
http://www.tortall.net/projects/yasm/releases/yasm-1.3.0.tar.gz

Relevant issues:
 * conan-io#13369
 * ydb-platform/ydb#123
@conan-center-bot

This comment has been minimized.

@VestniK
Copy link
Contributor Author

VestniK commented Oct 9, 2022

I can see several hook errors in the yasm package. I'll fix them in separate PR

@ghost
Copy link

ghost commented Oct 9, 2022

I detected other pull requests that are modifying yasm/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@VestniK
Copy link
Contributor Author

VestniK commented Oct 9, 2022

I can see several hook errors in the yasm package. I'll fix them in separate PR

Actually I was confused by the lines:

[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not found
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK

there are no actual errors as far as I can understand.

@conan-center-bot
Copy link
Collaborator

Failure in build 2 (c894df34f89dacd10766a62c2eceac419039ab96):

  • yasm/1.3.0@:
    CI failed to create some packages (All logs)

    Logs for packageID 0a420ff5c47119e668867cdb51baff0eca1fdb68:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=Visual Studio
    compiler.runtime=MT
    compiler.version=15
    os=Windows
    
    [...]
      nasm-token.c
    c:\j\w\prod\buildsinglereference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\modules\objfmts\xdf\xdf-objfmt.c(651): warning C4244: 'function': conversion from 'uintptr_t' to 'unsigned long', possible loss of data [C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\modules.vcxproj]
      nasm-eval.c
      nasm-pp.c
      nasm-preproc.c
      nasmlib.c
    c:\j\w\prod\buildsinglereference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\modules\preprocs\nasm\nasm-pp.c(884): warning C4244: '=': conversion from '__int64' to 'int', possible loss of data [C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\modules.vcxproj]
    c:\j\w\prod\buildsinglereference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\modules\preprocs\nasm\nasm-pp.c(957): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\modules.vcxproj]
    c:\j\w\prod\buildsinglereference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\modules\preprocs\nasm\nasm-pp.c(975): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\modules.vcxproj]
    c:\j\w\prod\buildsinglereference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\modules\preprocs\nasm\nasm-pp.c(987): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data [C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\modules.vcxproj]
    c:\j\w\prod\buildsinglereference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\modules\preprocs\nasm\nasm-pp.c(1025): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\modules.vcxproj]
    c:\j\w\prod\buildsinglereference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\modules\preprocs\nasm\nasm-pp.c(1026): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\modules.vcxproj]
      raw-preproc.c
    c:\j\w\prod\buildsinglereference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\modules\preprocs\raw\raw-preproc.c(84): warning C4244: 'function': conversion from '__int64' to 'int', possible loss of data [C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\modules.vcxproj]
      cpp-preproc.c
      nasm-listfmt.c
    c:\j\w\prod\buildsinglereference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\modules\preprocs\cpp\cpp-preproc.c(256): warning C4244: 'function': conversion from '__int64' to 'int', possible loss of data [C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\modules.vcxproj]
      modules.vcxproj -> C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\modules\x64\Release\modules.lib
      yasm-options.c
      yasm.c
      yasm.vcxproj -> C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68\source_subfolder\Mkfiles\vc10\x64\Release\yasm.exe
    yasm/1.3.0: Package '0a420ff5c47119e668867cdb51baff0eca1fdb68' built
    yasm/1.3.0: Build folder C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\build\0a420ff5c47119e668867cdb51baff0eca1fdb68
    yasm/1.3.0: Generated conaninfo.txt
    yasm/1.3.0: Generated conanbuildinfo.txt
    yasm/1.3.0: Generating the package
    yasm/1.3.0: Package folder C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\package\0a420ff5c47119e668867cdb51baff0eca1fdb68
    yasm/1.3.0: Calling package()
    [HOOK - conan-center.py] post_package(): [PACKAGE LICENSE (KB-H012)] OK
    [HOOK - conan-center.py] post_package(): [DEFAULT PACKAGE LAYOUT (KB-H013)] OK
    [HOOK - conan-center.py] post_package(): [MATCHING CONFIGURATION (KB-H014)] OK
    [HOOK - conan-center.py] post_package(): [SHARED ARTIFACTS (KB-H015)] OK
    [HOOK - conan-center.py] post_package(): [PC-FILES (KB-H020)] OK
    [HOOK - conan-center.py] post_package(): [CMAKE-MODULES-CONFIG-FILES (KB-H016)] OK
    [HOOK - conan-center.py] post_package(): [PDB FILES NOT ALLOWED (KB-H017)] OK
    [HOOK - conan-center.py] post_package(): [LIBTOOL FILES PRESENCE (KB-H018)] OK
    [HOOK - conan-center.py] post_package(): [MS RUNTIME FILES (KB-H021)] OK
    [HOOK - conan-center.py] post_package(): [SHORT_PATHS USAGE (KB-H066)] OK
    [HOOK - conan-center.py] post_package(): [MISSING SYSTEM LIBS (KB-H043)] OK
    yasm/1.3.0 package(): Packaged 1 '.exe' file: yasm.exe
    yasm/1.3.0 package(): Packaged 1 '.txt' file: BSD.txt
    yasm/1.3.0 package(): Packaged 1 file: COPYING
    yasm/1.3.0: Package '0a420ff5c47119e668867cdb51baff0eca1fdb68' created
    yasm/1.3.0: Created package revision 0f87a351b6f8aece01679f0daf9ba9bd
    yasm/1.3.0: Appending PATH environment variable: C:\J\w\prod\BuildSingleReference\.conan\data\yasm\1.3.0\_\_\package\0a420ff5c47119e668867cdb51baff0eca1fdb68\bin
    [HOOK - conan-center.py] post_package_info(): [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] OK
    [HOOK - conan-center.py] post_package_info(): [LIBRARY DOES NOT EXIST (KB-H054)] OK
    [HOOK - conan-center.py] post_package_info(): ERROR: [INCLUDE PATH DOES NOT EXIST (KB-H071)] Component yasm::yasm include dir 'include' is listed in the recipe, but not found in package folder. The include dir should probably be fixed or removed. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H071) 
    ERROR: 
    	ConanException: [HOOK - conan-center.py] post_package_info(): Some checks failed running the hook, check the output
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@@ -1,6 +1,6 @@
sources:
"1.3.0":
- url: "http://www.tortall.net/projects/yasm/releases/yasm-1.3.0.tar.gz"
- url: "https://github.com/yasm/yasm/releases/download/v1.3.0/yasm-1.3.0.tar.gz"
Copy link
Contributor

@Croydon Croydon Oct 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- url: "https://github.com/yasm/yasm/releases/download/v1.3.0/yasm-1.3.0.tar.gz"
- url: [
"https://github.com/yasm/yasm/releases/download/v1.3.0/yasm-1.3.0.tar.gz",
"https://www.tortall.net/projects/yasm/releases/yasm-1.3.0.tar.gz"
]

Let's add both

@ghost ghost mentioned this pull request Oct 18, 2022
4 tasks
@ghost ghost mentioned this pull request Nov 7, 2022
4 tasks
@stale
Copy link

stale bot commented Nov 19, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 19, 2022
@stale
Copy link

stale bot commented Dec 20, 2022

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants