-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor layouts #2643
Comments
Can I help? |
* Remove unused resource files * Remove unused layout files
Thank you so much for the offer of help - thinking more about the initial changes I want to make I think as they are large it'd be easier for one person to do them to avoid merge conflicts if I do them. For example, PRs #2641, #2645, and #2646 all touch over 10 layout files. Therefore I've marked this as assigned to me. However I'm sure later the changes will be more localized. Also for future people if this is still here and those PRs have been merged for a while (like a week) without new work being done on this, please do give me a mention to remind me about unassigning it. |
Summary:
There are an extreme number of layouts for an app with not that many different screens. This increases the opportunities for bugs to arise, and makes it difficult to find which layout might be useful to reuse when writing new code - leading to even more layouts!
It would be good to try to get a handle on some of the layouts, refactoring commonly used components out and using the same layouts for different activities (e.g. the structure of the tablayout for home, bookmarks, explore, search and category is very similar but they are all separate template files - leading to issues like #2186 taking ages to fix properly).
Would you like to work on the issue?
Yes, but there are so many layouts to try to simplify that others are welcome to work on it as well. Ideally keep PRs small so merge conflicts don't get too painful.
The text was updated successfully, but these errors were encountered: