Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Night mode: Tabs #2186

Closed
domdomegg opened this issue Dec 20, 2018 · 9 comments
Closed

Night mode: Tabs #2186

domdomegg opened this issue Dec 20, 2018 · 9 comments

Comments

@domdomegg
Copy link
Member

domdomegg commented Dec 20, 2018

Summary:

Tabs are inconsistent in how they are styled. I'm okay with MainActivity being different but Search and Category tabs should definitely look the same.

Should also probably standardise across non-night mode too.

Tabs are used in (edit this list if I've forgotten some):

  • MainActivity (Contributions/Nearby)
  • SearchActivity (Media/Categories)
  • Category page (Media/Subcategories/Parent categories)
  • Bookmarks page (Pictures/Locations)

Screen-shots:

MainActivity SearchActivity Category
screenshot_1545301973 screenshot_1545302017 screenshot_1545302049
@domdomegg domdomegg self-assigned this Dec 20, 2018
This was referenced Dec 20, 2018
@domdomegg domdomegg removed their assignment Dec 20, 2018
@borisenkotim
Copy link
Contributor

Hey, I would like to work on this issue.

@domdomegg
Copy link
Member Author

Assigned to @borisenkotim

@domdomegg
Copy link
Member Author

It's obviously up for debate, but I think the best look is having them look like part of the toolbar (as they are in the Category screenshot above).

@domdomegg
Copy link
Member Author

Or white on black is quite good. Basically just not something with a white background.

@neslihanturan
Copy link
Collaborator

Actually my favorite here is first (MainActivity) style, whoever create a PR please share 3 screenshots for dark theme like above and 3 for light theme.

But I think this PR requires discussion, so please do not start implementation before we find our path.

@borisenkotim
Copy link
Contributor

Working on it.

@domdomegg domdomegg changed the title Night mode: tabs Night mode: Tabs Dec 21, 2018
@borisenkotim
Copy link
Contributor

borisenkotim commented Dec 22, 2018

image
image

image

Thus far I made this change to the bookmarks bar. I think it looks better. Now it is the same as category tabs. The Main activity (home) as been left alone. I'm gonna try making the searchActivity section the same now.

@domdomegg
Copy link
Member Author

Looks good. I can have a look over the code so far if you'd like - push your changes to your fork on Github and start a pull request with [WIP] in the title (work in progress).

@borisenkotim
Copy link
Contributor

borisenkotim commented Dec 24, 2018

Before
searchb
After
searcha

Here is how the searchactivity page looks now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants