-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Night mode: Tabs #2186
Comments
Hey, I would like to work on this issue. |
Assigned to @borisenkotim |
It's obviously up for debate, but I think the best look is having them look like part of the toolbar (as they are in the |
Or white on black is quite good. Basically just not something with a white background. |
Actually my favorite here is first (MainActivity) style, whoever create a PR please share 3 screenshots for dark theme like above and 3 for light theme. But I think this PR requires discussion, so please do not start implementation before we find our path. |
Working on it. |
Looks good. I can have a look over the code so far if you'd like - push your changes to your fork on Github and start a pull request with |
Summary:
Tabs are inconsistent in how they are styled. I'm okay with MainActivity being different but Search and Category tabs should definitely look the same.
Should also probably standardise across non-night mode too.
Tabs are used in (edit this list if I've forgotten some):
Screen-shots:
The text was updated successfully, but these errors were encountered: